2008-11-12 22:03:44

by Alessandro Guido

Subject: [sony-laptop] Fix regression caused by "sony-laptop: fingers off backlight if video.ko is serving this functionality"

After commit 540b8bb9c33935183ceb5bed466a42ad72b2af56:

sony-laptop: fingers off backlight if video.ko is serving this functionality

I can't set brightness on my sony laptop (nothing in /sys/class/backlight).
dmesg says "sony-laptop: Sony: Brightness ignored, must be controlled by ACPI
video driver".
The function acpi_video_backlight_support returns 0 if we should use the
vendor-specific backlight support, while non-0 if the ACPI generic should
be used. Because of this, the check introduced by the said commit appears
reversed.

Signed-off-by: Alessandro Guido <[email protected]>
---
diff --git a/drivers/misc/sony-laptop.c b/drivers/misc/sony-laptop.c
index 7bcb810..2a613d4 100644
--- a/drivers/misc/sony-laptop.c
+++ b/drivers/misc/sony-laptop.c
@@ -1038,7 +1038,7 @@ static int sony_nc_add(struct acpi_device *device)
goto outinput;
}

- if (!acpi_video_backlight_support()) {
+ if (acpi_video_backlight_support()) {
printk(KERN_INFO DRV_PFX "Sony: Brightness ignored, must be "
"controlled by ACPI video driver\n");
} else if (ACPI_SUCCESS(acpi_get_handle(sony_nc_acpi_handle, "GBRT",

2008-11-12 22:27:29

by Thomas Renninger

Subject: Re: [sony-laptop] Fix regression caused by "sony-laptop: fingers off backlight if video.ko is serving this functionality"

On Wednesday 12 November 2008 04:03:28 pm Alessandro Guido wrote:
> After commit 540b8bb9c33935183ceb5bed466a42ad72b2af56:
>
> sony-laptop: fingers off backlight if video.ko is serving this
> functionality
>
> I can't set brightness on my sony laptop (nothing in /sys/class/backlight).
> dmesg says "sony-laptop: Sony: Brightness ignored, must be controlled by
> ACPI video driver".
> The function acpi_video_backlight_support returns 0 if we should use the
> vendor-specific backlight support, while non-0 if the ACPI generic should
> be used. Because of this, the check introduced by the said commit appears
> reversed.
>
> Signed-off-by: Alessandro Guido <[email protected]>

Thanks for finding this stupid typo,

Thomas

> ---
> diff --git a/drivers/misc/sony-laptop.c b/drivers/misc/sony-laptop.c
> index 7bcb810..2a613d4 100644
> --- a/drivers/misc/sony-laptop.c
> +++ b/drivers/misc/sony-laptop.c
> @@ -1038,7 +1038,7 @@ static int sony_nc_add(struct acpi_device *device)
> goto outinput;
> }
>
> - if (!acpi_video_backlight_support()) {
> + if (acpi_video_backlight_support()) {
> printk(KERN_INFO DRV_PFX "Sony: Brightness ignored, must be "
> "controlled by ACPI video driver\n");
> } else if (ACPI_SUCCESS(acpi_get_handle(sony_nc_acpi_handle, "GBRT",

2008-11-13 05:56:25

by Len Brown

Subject: Re: [sony-laptop] Fix regression caused by "sony-laptop: fingers off backlight if video.ko is serving this functionality"

applied.

thanks for testing!

-Len

On Wed, 12 Nov 2008, Alessandro Guido wrote:

> After commit 540b8bb9c33935183ceb5bed466a42ad72b2af56:
>
> sony-laptop: fingers off backlight if video.ko is serving this functionality
>
> I can't set brightness on my sony laptop (nothing in /sys/class/backlight).
> dmesg says "sony-laptop: Sony: Brightness ignored, must be controlled by ACPI
> video driver".
> The function acpi_video_backlight_support returns 0 if we should use the
> vendor-specific backlight support, while non-0 if the ACPI generic should
> be used. Because of this, the check introduced by the said commit appears
> reversed.
>
> Signed-off-by: Alessandro Guido <[email protected]>
> ---
> diff --git a/drivers/misc/sony-laptop.c b/drivers/misc/sony-laptop.c
> index 7bcb810..2a613d4 100644
> --- a/drivers/misc/sony-laptop.c
> +++ b/drivers/misc/sony-laptop.c
> @@ -1038,7 +1038,7 @@ static int sony_nc_add(struct acpi_device *device)
> goto outinput;
> }
>
> - if (!acpi_video_backlight_support()) {
> + if (acpi_video_backlight_support()) {
> printk(KERN_INFO DRV_PFX "Sony: Brightness ignored, must be "
> "controlled by ACPI video driver\n");
> } else if (ACPI_SUCCESS(acpi_get_handle(sony_nc_acpi_handle, "GBRT",
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>