Impact: cleanup
In future, accessing cpu numbers beyond nr_cpu_ids (the runtime limit)
will be undefined. We can avoid future problems by using
for_each_online_cpu() here.
Signed-off-by: Rusty Russell <[email protected]>
Cc: Hoang-Nam Nguyen <[email protected]>
Cc: Christoph Raisch <[email protected]>
---
drivers/infiniband/hw/ehca/ehca_irq.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff -r 38b459d1e9c7 drivers/infiniband/hw/ehca/ehca_irq.c
--- a/drivers/infiniband/hw/ehca/ehca_irq.c Fri Nov 07 22:33:08 2008 +1100
+++ b/drivers/infiniband/hw/ehca/ehca_irq.c Fri Nov 07 22:48:13 2008 +1100
@@ -922,10 +922,9 @@ void ehca_destroy_comp_pool(void)
unregister_hotcpu_notifier(&comp_pool_callback_nb);
- for (i = 0; i < NR_CPUS; i++) {
- if (cpu_online(i))
- destroy_comp_task(pool, i);
- }
+ for_each_online_cpu(i)
+ destroy_comp_task(pool, i);
+
free_percpu(pool->cpu_comp_tasks);
kfree(pool);
}
> Impact: cleanup
>
> In future, accessing cpu numbers beyond nr_cpu_ids (the runtime limit)
> will be undefined. We can avoid future problems by using
> for_each_online_cpu() here.
>
> Signed-off-by: Rusty Russell <[email protected]>
Acked-by: Hoang-Nam Nguyen <[email protected]>
Tested with latest kernel. Thanks for this!
Nam