2008-11-21 22:17:21

by Hannes Eder

Subject: [PATCH] x86: vmware - fix sparse warnings

Fix the following sparse warnings:

arch/x86/kernel/cpu/vmware.c:69:5: warning: symbol 'vmware_platform'
was not declared. Should it be static?
arch/x86/kernel/cpu/vmware.c:89:15: warning: symbol
'vmware_get_tsc_khz' was not declared. Should it be static?
arch/x86/kernel/cpu/vmware.c:107:16: warning: symbol
'vmware_set_feature_bits' was not declared. Should it be static?

Signed-off-by: Hannes Eder <[email protected]>
---
arch/x86/kernel/cpu/vmware.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kernel/cpu/vmware.c b/arch/x86/kernel/cpu/vmware.c
index c034bda..284c399 100644
--- a/arch/x86/kernel/cpu/vmware.c
+++ b/arch/x86/kernel/cpu/vmware.c
@@ -23,6 +23,7 @@

#include <linux/dmi.h>
#include <asm/div64.h>
+#include <asm/vmware.h>

#define CPUID_VMWARE_INFO_LEAF 0x40000000
#define VMWARE_HYPERVISOR_MAGIC 0x564D5868
--
1.5.6.3

2008-11-23 10:03:18

by Ingo Molnar

Subject: Re: [PATCH] x86: vmware - fix sparse warnings

* Hannes Eder <[email protected]> wrote:

> Fix the following sparse warnings:
>
> arch/x86/kernel/cpu/vmware.c:69:5: warning: symbol 'vmware_platform'
> was not declared. Should it be static?
> arch/x86/kernel/cpu/vmware.c:89:15: warning: symbol
> 'vmware_get_tsc_khz' was not declared. Should it be static?
> arch/x86/kernel/cpu/vmware.c:107:16: warning: symbol
> 'vmware_set_feature_bits' was not declared. Should it be static?
>
> Signed-off-by: Hannes Eder <[email protected]>
> ---
> arch/x86/kernel/cpu/vmware.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)

applied to tip/x86/detect-hyper, thanks Hannes!

Ingo