2008-11-25 13:13:21

by Julia Lawall

Subject: [PATCH 2/5] arch/x86/kernel/pci-calgary_64.c: change simple_strtol to simple_strtoul

From: Julia Lawall <[email protected]>

Since bridge is unsigned, it would seem better to use simple_strtoul that
simple_strtol.

A simplified version of the semantic patch that makes this change is as
follows: (http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@r2@
long e;
position p;
@@

e = simple_strtol@p(...)

@@
position p != r2.p;
type T;
T e;
@@

e =
- simple_strtol@p
+ simple_strtoul
(...)
// </smpl>

Signed-off-by: Julia Lawall <[email protected]>

---

arch/x86/kernel/pci-calgary_64.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff -u -p a/arch/x86/kernel/pci-calgary_64.c b/arch/x86/kernel/pci-calgary_64.c
--- a/arch/x86/kernel/pci-calgary_64.c
+++ b/arch/x86/kernel/pci-calgary_64.c
@@ -1567,7 +1567,7 @@ static int __init calgary_parse_options(
++p;
if (*p == '\0')
break;
- bridge = simple_strtol(p, &endp, 0);
+ bridge = simple_strtoul(p, &endp, 0);
if (p == endp)
break;

2008-11-25 14:47:58

by Muli Ben-Yehuda

Subject: Re: [PATCH 2/5] arch/x86/kernel/pci-calgary_64.c: change simple_strtol to simple_strtoul

On Tue, Nov 25, 2008 at 02:13:03PM +0100, Julia Lawall wrote:
> From: Julia Lawall <[email protected]>
>
> Since bridge is unsigned, it would seem better to use simple_strtoul that
> simple_strtol.
>
> A simplified version of the semantic patch that makes this change is as
> follows: (http://www.emn.fr/x-info/coccinelle/)
>
> // <smpl>
> @r2@
> long e;
> position p;
> @@
>
> e = simple_strtol@p(...)
>
> @@
> position p != r2.p;
> type T;
> T e;
> @@
>
> e =
> - simple_strtol@p
> + simple_strtoul
> (...)
> // </smpl>
>
> Signed-off-by: Julia Lawall <[email protected]>

Acked-by: Muli Ben-Yehuda <[email protected]>

Ingo, can you please push?

Thanks,
Muli
--
The First Workshop on I/O Virtualization (WIOV '08)
Dec 2008, San Diego, CA, http://www.usenix.org/wiov08/
<->
SYSTOR 2009---The Israeli Experimental Systems Conference
http://www.haifa.il.ibm.com/conferences/systor2009/

2008-11-26 03:10:29

by Ingo Molnar

Subject: Re: [PATCH 2/5] arch/x86/kernel/pci-calgary_64.c: change simple_strtol to simple_strtoul

* Muli Ben-Yehuda <[email protected]> wrote:

> On Tue, Nov 25, 2008 at 02:13:03PM +0100, Julia Lawall wrote:
> > From: Julia Lawall <[email protected]>
> >
> > Since bridge is unsigned, it would seem better to use simple_strtoul that
> > simple_strtol.
> >
> > A simplified version of the semantic patch that makes this change is as
> > follows: (http://www.emn.fr/x-info/coccinelle/)
> >
> > // <smpl>
> > @r2@
> > long e;
> > position p;
> > @@
> >
> > e = simple_strtol@p(...)
> >
> > @@
> > position p != r2.p;
> > type T;
> > T e;
> > @@
> >
> > e =
> > - simple_strtol@p
> > + simple_strtoul
> > (...)
> > // </smpl>
> >
> > Signed-off-by: Julia Lawall <[email protected]>
>
> Acked-by: Muli Ben-Yehuda <[email protected]>
>
> Ingo, can you please push?

Sure, applied to tip/x86/urgent, thanks guys!

Ingo