2008-11-26 21:02:25

by Cyrill Gorcunov

Subject: [PATCH] x86: uv bau interrupt -- use proper interrupt number

Signed-off-by: Cyrill Gorcunov <[email protected]>
CC: Andi Kleen <[email protected]>
---
arch/x86/kernel/entry_64.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.git/arch/x86/kernel/entry_64.S
===================================================================
--- linux-2.6.git.orig/arch/x86/kernel/entry_64.S
+++ linux-2.6.git/arch/x86/kernel/entry_64.S
@@ -945,7 +945,7 @@ apicinterrupt IRQ_MOVE_CLEANUP_VECTOR \
irq_move_cleanup_interrupt smp_irq_move_cleanup_interrupt
#endif

-apicinterrupt 220 \
+apicinterrupt UV_BAU_MESSAGE \
uv_bau_message_intr1 uv_bau_message_interrupt
apicinterrupt LOCAL_TIMER_VECTOR \
apic_timer_interrupt smp_apic_timer_interrupt

2008-11-26 21:19:45

by Cliff Wickman

Subject: Re: [PATCH] x86: uv bau interrupt -- use proper interrupt number

On Thu, Nov 27, 2008 at 12:02:10AM +0300, Cyrill Gorcunov wrote:
> Signed-off-by: Cyrill Gorcunov <[email protected]>
> CC: Andi Kleen <[email protected]>
> ---
> arch/x86/kernel/entry_64.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6.git/arch/x86/kernel/entry_64.S
> ===================================================================
> --- linux-2.6.git.orig/arch/x86/kernel/entry_64.S
> +++ linux-2.6.git/arch/x86/kernel/entry_64.S
> @@ -945,7 +945,7 @@ apicinterrupt IRQ_MOVE_CLEANUP_VECTOR \
> irq_move_cleanup_interrupt smp_irq_move_cleanup_interrupt
> #endif
>
> -apicinterrupt 220 \
> +apicinterrupt UV_BAU_MESSAGE \
> uv_bau_message_intr1 uv_bau_message_interrupt
> apicinterrupt LOCAL_TIMER_VECTOR \
> apic_timer_interrupt smp_apic_timer_interrupt
> --

The interrupt handler does not use the hardcoded 220, but
the declaration should indeed be fixed as above.
(such a fix was once submitted
http://marc.info/?l=linux-kernel&m=122350309029050&w=2 but didn't
go anywhere)
Thanks for the follow-up.

-Cliff
--
Cliff Wickman
Silicon Graphics, Inc.
[email protected]
(651) 683-3824

2008-11-28 13:18:19

by Ingo Molnar

Subject: Re: [PATCH] x86: uv bau interrupt -- use proper interrupt number

* Cliff Wickman <[email protected]> wrote:

> On Thu, Nov 27, 2008 at 12:02:10AM +0300, Cyrill Gorcunov wrote:
> > Signed-off-by: Cyrill Gorcunov <[email protected]>
> > CC: Andi Kleen <[email protected]>
> > ---
> > arch/x86/kernel/entry_64.S | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Index: linux-2.6.git/arch/x86/kernel/entry_64.S
> > ===================================================================
> > --- linux-2.6.git.orig/arch/x86/kernel/entry_64.S
> > +++ linux-2.6.git/arch/x86/kernel/entry_64.S
> > @@ -945,7 +945,7 @@ apicinterrupt IRQ_MOVE_CLEANUP_VECTOR \
> > irq_move_cleanup_interrupt smp_irq_move_cleanup_interrupt
> > #endif
> >
> > -apicinterrupt 220 \
> > +apicinterrupt UV_BAU_MESSAGE \
> > uv_bau_message_intr1 uv_bau_message_interrupt
> > apicinterrupt LOCAL_TIMER_VECTOR \
> > apic_timer_interrupt smp_apic_timer_interrupt
> > --
>
> The interrupt handler does not use the hardcoded 220, but
> the declaration should indeed be fixed as above.
> (such a fix was once submitted
> http://marc.info/?l=linux-kernel&m=122350309029050&w=2 but didn't
> go anywhere)
> Thanks for the follow-up.

applied to tip/x86/irq, thanks guys!

Ingo