2008-11-28 09:38:23

by Hannes Eder

Subject: [PATCH] pkt_sched: fix sparse warning

Impact: make global function static

Fix the following sparse warning:

net/sched/sch_api.c:192:14: warning: symbol 'qdisc_match_from_root' was not declared. Should it be static?

Signed-off-by: Hannes Eder <[email protected]>
---
net/sched/sch_api.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c
index f859dd5..6bc29e8 100644
--- a/net/sched/sch_api.c
+++ b/net/sched/sch_api.c
@@ -189,7 +189,7 @@ EXPORT_SYMBOL(unregister_qdisc);
(root qdisc, all its children, children of children etc.)
*/

-struct Qdisc *qdisc_match_from_root(struct Qdisc *root, u32 handle)
+static struct Qdisc *qdisc_match_from_root(struct Qdisc *root, u32 handle)
{
struct Qdisc *q;

--
1.5.6.3

2008-11-28 11:07:26

by David Miller

Subject: Re: [PATCH] pkt_sched: fix sparse warning

From: Hannes Eder <[email protected]>
Date: Thu, 27 Nov 2008 20:33:17 +0100

> Impact: make global function static
>
> Fix the following sparse warning:
>
> net/sched/sch_api.c:192:14: warning: symbol 'qdisc_match_from_root' was not declared. Should it be static?
>
> Signed-off-by: Hannes Eder <[email protected]>

Applied, thanks Hannes.