2008-11-18 11:39:22

by Hendrik Brueckner

Subject: [patch 1/1] hvc_console: fix: hp->ws winsize check runs out-of-sync

From: Hendrik Brueckner <[email protected]>

The test to check for a new winsize runs out-of-sync with the underlying
tty. After a tty has been released and initialized again, the winsize might
differ between the tty and the hp struct.
The solution is to simply remove the check and always schedule the resize work.

Signed-off-by: Hendrik Brueckner <[email protected]>
Acked-by: Christian Borntraeger <[email protected]>
---
drivers/char/hvc_console.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

--- a/drivers/char/hvc_console.c
+++ b/drivers/char/hvc_console.c
@@ -689,10 +689,8 @@ EXPORT_SYMBOL_GPL(hvc_poll);
*/
void hvc_resize(struct hvc_struct *hp, struct winsize ws)
{
- if ((hp->ws.ws_row != ws.ws_row) || (hp->ws.ws_col != ws.ws_col)) {
- hp->ws = ws;
- schedule_work(&hp->tty_resize);
- }
+ hp->ws = ws;
+ schedule_work(&hp->tty_resize);
}

/*

--
Hendrik Brueckner
D/3303 Linux on System z Development
Tel: +49 7031 16-1073
Fax: +49 7031 16-3456
eMail: [email protected]
IBM Deutschland Research & Development GmbH, Schoenaicher Str. 220, 71032 Boeblingen

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschaeftsfuehrung: Erich Baier
Sitz der Gesellschaft: Boeblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294

2008-12-03 09:17:43

by Paul Mackerras

Subject: Re: [patch 1/1] hvc_console: fix: hp->ws winsize check runs out-of-sync

Hendrik Brueckner writes:

> From: Hendrik Brueckner <[email protected]>
>
> The test to check for a new winsize runs out-of-sync with the underlying
> tty. After a tty has been released and initialized again, the winsize might
> differ between the tty and the hp struct.
> The solution is to simply remove the check and always schedule the resize work.

Looks OK. Is this going to go in via the s390 tree, or should I put
it in the powerpc tree?

Paul.

2008-12-03 09:29:16

by Hendrik Brueckner

Subject: Re: [patch 1/1] hvc_console: fix: hp->ws winsize check runs out-of-sync

Hi Paul,

On Wed, Dec 03, 2008 at 08:17:13PM +1100, Paul Mackerras wrote:
> Looks OK. Is this going to go in via the s390 tree, or should I put
> it in the powerpc tree?
The patch should go via the powerpc tree.

Thanks and regards,
Hendrik