2008-12-08 08:07:12

by David Miller

[permalink] [raw]
Subject: [GIT]: Networking


Here are the pending net fixes:

1) TPROXY code accesses invalid socket struct memory. Fix from
Balazs Scheidler.

2) listen() on ATM socket multiple times corrupts VCC table.
Fix thanks to Chas Williams.

3) TCP vegas congestion control doesn't hit ssthresh properly in
all cases, from Doug Leith.

4) Two CAN socket layer filtering API fixes from Oliver Hartkopp.

5) Really fix URG handling with TSO, from Ilpo J?rvinen.

6) netlabel OOPS'er fix from Paul Moore.

7) 32/64 bit field access bug in HYSDN isdn driver from Pascal Terjan.

8) A few small wireless driver bug fixes via John Linville.

9) netx-eth driver doesn't initialize the driver spinlock, resulting
in warnings from lock checking, from Uwe Kleine-K?nig.

10) Missing list_del() in policy flushing leads to complete
corruption of the policy tables. Fix from Wei Yongjun.

11) b1isa_exit() in isdn drivers does not release CAPI controllers
resulting in all kinds of problems. From Wilfried Klaebe.

12) Fix from R?mi Denis-Courmont to keep phonet socket layer from
dumping sockets outside of the current namespace.

13) Packet data read in enc28j60 driver doesn't use the correct buffer
offset in the wraparound cases, resulting in data loss. Fix from
Baruch Siach based upon suggestions from Shachar Shemesh.

Please pull, thanks a lot!

The following changes since commit f6f7b52e2f6149d2ee365717afff315b05720162:
Linus Torvalds (1):
Merge git://git.kernel.org/.../wim/linux-2.6-watchdog

are available in the git repository at:

master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6.git master

Balazs Scheidler (1):
tproxy: fixe a possible read from an invalid location in the socket match

Baruch Siach (1):
enc28j60: Fix sporadic packet loss (corrected again)

Chas Williams (1):
ATM: CVE-2008-5079: duplicate listen() on socket corrupts the vcc table

David S. Miller (1):
Merge branch 'master' of git://git.kernel.org/.../linville/wireless-2.6

Doug Leith (1):
tcp: tcp_vegas ssthresh bug fix

Ilpo J?rvinen (1):
tcp: make urg+gso work for real this time

Michael Chan (1):
bnx2: Add workaround to handle missed MSI.

Oliver Hartkopp (2):
can: Fix CAN_(EFF|RTR)_FLAG handling in can_filter
can: omit received RTR frames for single ID filter lists

Pascal Terjan (1):
hysdn: fix writing outside the field on 64 bits

Paul Moore (1):
netlabel: Fix a potential NULL pointer dereference

Shaddy Baddah (2):
mac80211: use unaligned safe memcmp() in-place of compare_ether_addr()
zd1211rw: use unaligned safe memcmp() in-place of compare_ether_addr()

Tomas Winkler (1):
iwlwifi: clean key table in iwl_clear_stations_table function

Uwe Kleine-K?nig (1):
netx-eth: initialize per device spinlock

Wei Yongjun (1):
xfrm: Fix kernel panic when flush and dump SPD entries

Wilfried Klaebe (1):
b1isa: fix b1isa_exit() to really remove registered capi controllers

Zhu Yi (1):
ipw2200: fix netif_*_queue() removal regression

remi.denis-courmont@nokia (1):
Phonet: do not dump addresses from other namespaces

drivers/isdn/hardware/avm/b1isa.c | 6 +--
drivers/isdn/hysdn/hysdn_net.c | 4 +-
drivers/net/bnx2.c | 35 ++++++++++++++-
drivers/net/bnx2.h | 6 +++
drivers/net/enc28j60.c | 16 ++++++-
drivers/net/netx-eth.c | 2 +
drivers/net/wireless/ipw2200.c | 4 ++
drivers/net/wireless/iwlwifi/iwl-core.c | 3 +
drivers/net/wireless/iwlwifi/iwl-sta.c | 24 +++++++++-
drivers/net/wireless/zd1211rw/zd_mac.c | 2 +-
include/linux/can/core.h | 2 +-
net/atm/svc.c | 6 ++-
net/can/af_can.c | 68 +++++++++++++++++++++++-------
net/can/bcm.c | 7 ++-
net/ipv4/tcp_output.c | 22 +++++-----
net/ipv4/tcp_vegas.c | 2 +
net/mac80211/sta_info.c | 2 +-
net/netfilter/xt_socket.c | 2 +-
net/netlabel/netlabel_unlabeled.c | 10 +++--
net/phonet/pn_netlink.c | 3 +
net/xfrm/xfrm_policy.c | 1 +
21 files changed, 173 insertions(+), 54 deletions(-)


2008-12-11 12:51:08

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [GIT]: Networking

On Mon, 8 Dec 2008, David Miller wrote:
> Here are the pending net fixes:
>
> 6) netlabel OOPS'er fix from Paul Moore.

> Paul Moore (1):
> netlabel: Fix a potential NULL pointer dereference

This introduced:

| net/netlabel/netlabel_unlabeled.c:567: warning: 'entry' may be used uninitialized in this function
| net/netlabel/netlabel_unlabeled.c:629: warning: 'entry' may be used uninitialized in this function

which may still oops, if the uninitialized entry pointer is dereferenced (in
case list_entry == NULL).

With kind regards,

Geert Uytterhoeven
Software Architect

Sony Techsoft Centre Europe
The Corporate Village ? Da Vincilaan 7-D1 ? B-1935 Zaventem ? Belgium

Phone: +32 (0)2 700 8453
Fax: +32 (0)2 700 8622
E-mail: [email protected]
Internet: http://www.sony-europe.com/

A division of Sony Europe (Belgium) N.V.
VAT BE 0413.825.160 ? RPR Brussels
Fortis ? BIC GEBABEBB ? IBAN BE41293037680010

2008-12-11 13:21:20

by Paul Moore

[permalink] [raw]
Subject: Re: [GIT]: Networking

On Thursday 11 December 2008 7:50:23 am Geert Uytterhoeven wrote:
> On Mon, 8 Dec 2008, David Miller wrote:
> > Here are the pending net fixes:
> >
> > 6) netlabel OOPS'er fix from Paul Moore.
> >
> > Paul Moore (1):
> > netlabel: Fix a potential NULL pointer dereference
>
> This introduced:
> | net/netlabel/netlabel_unlabeled.c:567: warning: 'entry' may be used
> | uninitialized in this function
> | net/netlabel/netlabel_unlabeled.c:629: warning: 'entry' may be used
> | uninitialized in this function
>
> which may still oops, if the uninitialized entry pointer is
> dereferenced (in case list_entry == NULL).

Hi Geert,

First of, a quick question: what version of gcc are you using? I'm
using gcc-4.3.2 and I don't get this warning/error. Regardless, I'll
send out a patch later today which should resolve the warning.

--
paul moore
linux @ hp

2008-12-11 14:01:28

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [GIT]: Networking

On Thu, 11 Dec 2008, Paul Moore wrote:
> On Thursday 11 December 2008 7:50:23 am Geert Uytterhoeven wrote:
> > On Mon, 8 Dec 2008, David Miller wrote:
> > > Here are the pending net fixes:
> > >
> > > 6) netlabel OOPS'er fix from Paul Moore.
> > >
> > > Paul Moore (1):
> > > netlabel: Fix a potential NULL pointer dereference
> >
> > This introduced:
> > | net/netlabel/netlabel_unlabeled.c:567: warning: 'entry' may be used
> > | uninitialized in this function
> > | net/netlabel/netlabel_unlabeled.c:629: warning: 'entry' may be used
> > | uninitialized in this function
> >
> > which may still oops, if the uninitialized entry pointer is
> > dereferenced (in case list_entry == NULL).
>
> Hi Geert,
>
> First of, a quick question: what version of gcc are you using? I'm
> using gcc-4.3.2 and I don't get this warning/error. Regardless, I'll
> send out a patch later today which should resolve the warning.

I'm using an m68k cross-compiler, built from Debian sources:

| gcc version 4.1.2 20061115 (prerelease) (Debian 4.1.1-21)

With kind regards,

Geert Uytterhoeven
Software Architect

Sony Techsoft Centre Europe
The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium

Phone: +32 (0)2 700 8453
Fax: +32 (0)2 700 8622
E-mail: [email protected]
Internet: http://www.sony-europe.com/

A division of Sony Europe (Belgium) N.V.
VAT BE 0413.825.160 · RPR Brussels
Fortis · BIC GEBABEBB · IBAN BE41293037680010