2008-12-16 14:53:26

by Metzger, Markus T

Subject: [patch 3/3] x86, bts: correctly report invalid bts records

Correctly report a cleared BTS record as invalid. Used to be reported
as branch from 0 to 0.


Signed-off-by: Markus Metzger <[email protected]>
---

Index: ftrace/arch/x86/kernel/ds.c
===================================================================
--- ftrace.orig/arch/x86/kernel/ds.c 2008-12-15 09:29:05.000000000 +0100
+++ ftrace/arch/x86/kernel/ds.c 2008-12-15 11:32:04.000000000 +0100
@@ -484,6 +484,9 @@
out->qualifier = bts_branch;
out->variant.lbr.from = bts_get(at, bts_from);
out->variant.lbr.to = bts_get(at, bts_to);
+
+ if (!out->variant.lbr.from && !out->variant.lbr.to)
+ out->qualifier = bts_invalid;
}

return ds_cfg.sizeof_rec[ds_bts];
---------------------------------------------------------------------
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen Germany
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer
Registergericht: Muenchen HRB 47456 Ust.-IdNr.
VAT Registration No.: DE129385895
Citibank Frankfurt (BLZ 502 109 00) 600119052

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

2008-12-16 17:29:20

by Ingo Molnar

Subject: Re: [patch 3/3] x86, bts: correctly report invalid bts records

* Markus Metzger <[email protected]> wrote:

> Correctly report a cleared BTS record as invalid. Used to be reported
> as branch from 0 to 0.
>
>
> Signed-off-by: Markus Metzger <[email protected]>

applied to tip/tracing/hw-branch-tracer, thanks,

Ingo