It's perfectly normal for no AMD GART to be present, e.g., if you have
Intel CPUs. None of the other iommu_init() functions makes noise when
it finds nothing.
Signed-off-by: Bjorn Helgaas <[email protected]>
---
arch/x86/kernel/pci-gart_64.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/arch/x86/kernel/pci-gart_64.c b/arch/x86/kernel/pci-gart_64.c
index ba7ad83..a35eaa3 100644
--- a/arch/x86/kernel/pci-gart_64.c
+++ b/arch/x86/kernel/pci-gart_64.c
@@ -745,10 +745,8 @@ void __init gart_iommu_init(void)
unsigned long scratch;
long i;
- if (cache_k8_northbridges() < 0 || num_k8_northbridges == 0) {
- printk(KERN_INFO "PCI-GART: No AMD GART found.\n");
+ if (cache_k8_northbridges() < 0 || num_k8_northbridges == 0)
return;
- }
#ifndef CONFIG_AGP_AMD64
no_agp = 1;
On Wed, Dec 17, 2008 at 03:27:24PM -0500, Dave Jones wrote:
> The Calgary stuff is pretty noisy in the face of non-existant hardware too.
> Makes for noisy distro kernels..
>
> Calgary: detecting Calgary via BIOS EBDA area
> Calgary: Unable to locate Rio Grande table in EBDA - bailing!
Feel free to nuke it.
Cheers,
Muli
--
SYSTOR 2009---The Israeli Experimental Systems Conference
May 4-6, 2009, Haifa, Israel
http://www.haifa.il.ibm.com/conferences/systor2009/
On Wed, Dec 17, 2008 at 12:52:34PM -0700, Bjorn Helgaas wrote:
> It's perfectly normal for no AMD GART to be present, e.g., if you have
> Intel CPUs. None of the other iommu_init() functions makes noise when
> it finds nothing.
True, there are even 64bit AMD processors without GART.
Ingo,
do you want to pick this patch up or should I do it?
> Signed-off-by: Bjorn Helgaas <[email protected]>
Acked-by: Joerg Roedel <[email protected]>
> ---
> arch/x86/kernel/pci-gart_64.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/kernel/pci-gart_64.c b/arch/x86/kernel/pci-gart_64.c
> index ba7ad83..a35eaa3 100644
> --- a/arch/x86/kernel/pci-gart_64.c
> +++ b/arch/x86/kernel/pci-gart_64.c
> @@ -745,10 +745,8 @@ void __init gart_iommu_init(void)
> unsigned long scratch;
> long i;
>
> - if (cache_k8_northbridges() < 0 || num_k8_northbridges == 0) {
> - printk(KERN_INFO "PCI-GART: No AMD GART found.\n");
> + if (cache_k8_northbridges() < 0 || num_k8_northbridges == 0)
> return;
> - }
>
> #ifndef CONFIG_AGP_AMD64
> no_agp = 1;
>
>
--
| AMD Saxony Limited Liability Company & Co. KG
Operating | Wilschdorfer Landstr. 101, 01109 Dresden, Germany
System | Register Court Dresden: HRA 4896
Research | General Partner authorized to represent:
Center | AMD Saxony LLC (Wilmington, Delaware, US)
| General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy
* Joerg Roedel <[email protected]> wrote:
> On Wed, Dec 17, 2008 at 12:52:34PM -0700, Bjorn Helgaas wrote:
> > It's perfectly normal for no AMD GART to be present, e.g., if you have
> > Intel CPUs. None of the other iommu_init() functions makes noise when
> > it finds nothing.
>
> True, there are even 64bit AMD processors without GART.
>
> Ingo,
>
> do you want to pick this patch up or should I do it?
>
> > Signed-off-by: Bjorn Helgaas <[email protected]>
>
> Acked-by: Joerg Roedel <[email protected]>
I have applied it to tip/x86/urgent, thanks guys!
Ingo
On Wed, Dec 17, 2008 at 12:52:34PM -0700, Bjorn Helgaas wrote:
> It's perfectly normal for no AMD GART to be present, e.g., if you have
> Intel CPUs.
Yes! That's annoyed me for some time too.
> None of the other iommu_init() functions makes noise when
> it finds nothing.
The Calgary stuff is pretty noisy in the face of non-existant hardware too.
Makes for noisy distro kernels..
Calgary: detecting Calgary via BIOS EBDA area
Calgary: Unable to locate Rio Grande table in EBDA - bailing!
Dave
--
http://www.codemonkey.org.uk
On Wednesday 17 December 2008 01:27:24 pm Dave Jones wrote:
> On Wed, Dec 17, 2008 at 12:52:34PM -0700, Bjorn Helgaas wrote:
> > It's perfectly normal for no AMD GART to be present, e.g., if you have
> > Intel CPUs.
>
> Yes! That's annoyed me for some time too.
>
> > None of the other iommu_init() functions makes noise when
> > it finds nothing.
>
> The Calgary stuff is pretty noisy in the face of non-existant hardware too.
> Makes for noisy distro kernels..
>
> Calgary: detecting Calgary via BIOS EBDA area
> Calgary: Unable to locate Rio Grande table in EBDA - bailing!
Yeah, I considered removing that, too. At least the Calgary stuff
is KERN_DEBUG, so it's not quite as visible. But I'm in favor of
removing it anyway.
Bjorn