2008-12-29 15:05:22

by Jaswinder Singh Rajput

Subject: [PATCH] x86_64: apic.c declare pic_mode before they get used

Impact: cleanup, avoid sparse warning

In asm/mpspec.h moved out pic_mode from CONFIG_X86_32 as it is common for both 32 and 64 bit.

Fixes this sparse warning for x86_64:
arch/x86/kernel/apic.c:128:5: warning: symbol 'pic_mode' was not declared. Should it be static?

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
arch/x86/include/asm/mpspec.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/include/asm/mpspec.h b/arch/x86/include/asm/mpspec.h
index 91885c2..62d14ce 100644
--- a/arch/x86/include/asm/mpspec.h
+++ b/arch/x86/include/asm/mpspec.h
@@ -6,13 +6,13 @@
#include <asm/mpspec_def.h>

extern int apic_version[MAX_APICS];
+extern int pic_mode;

#ifdef CONFIG_X86_32
#include <mach_mpspec.h>

extern unsigned int def_to_bigsmp;
extern u8 apicid_2_node[];
-extern int pic_mode;

#ifdef CONFIG_X86_NUMAQ
extern int mp_bus_id_to_node[MAX_MP_BUSSES];
--
1.5.5.1

2008-12-29 15:18:04

by Ingo Molnar

Subject: Re: [PATCH] x86_64: apic.c declare pic_mode before they get used

applied your patches to tip/x86/cleanups:

cf3874b: x86_64: pci-gart_64.c iommu_fullflush should be static
788983d: x86: efi.c declare add_efi_memmap before they get used
fa0cf44: x86: io_apic.c io_apic_sync should be static
8a4cfcf: x86: apic.c declare pic_mode before they get used

thanks,

Ingo