2008-12-29 15:06:39

by Jaswinder Singh Rajput

Subject: [PATCH] x86: io_apic.c io_apic_sync should be static

Impact: cleanup, reduce kernel size a bit, avoid sparse warning

Fixes sparse warning:
arch/x86/kernel/io_apic.c:709:6: warning: symbol 'io_apic_sync' was not declared. Should it be static?

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
arch/x86/kernel/io_apic.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/io_apic.c b/arch/x86/kernel/io_apic.c
index 62ecfc9..6991172 100644
--- a/arch/x86/kernel/io_apic.c
+++ b/arch/x86/kernel/io_apic.c
@@ -706,7 +706,7 @@ static void __unmask_IO_APIC_irq(struct irq_cfg *cfg)
}

#ifdef CONFIG_X86_64
-void io_apic_sync(struct irq_pin_list *entry)
+static void io_apic_sync(struct irq_pin_list *entry)
{
/*
* Synchronize the IO-APIC and the CPU by doing
--
1.5.5.1

2008-12-29 15:25:14

by Cyrill Gorcunov

Subject: Re: [PATCH] x86: io_apic.c io_apic_sync should be static

[Jaswinder Singh Rajput - Mon, Dec 29, 2008 at 08:34:35PM +0530]
| Impact: cleanup, reduce kernel size a bit, avoid sparse warning
|
| Fixes sparse warning:
| arch/x86/kernel/io_apic.c:709:6: warning: symbol 'io_apic_sync' was not declared. Should it be static?
|
| Signed-off-by: Jaswinder Singh Rajput <[email protected]>
| ---
| arch/x86/kernel/io_apic.c | 2 +-
| 1 files changed, 1 insertions(+), 1 deletions(-)
|
| diff --git a/arch/x86/kernel/io_apic.c b/arch/x86/kernel/io_apic.c
| index 62ecfc9..6991172 100644
| --- a/arch/x86/kernel/io_apic.c
| +++ b/arch/x86/kernel/io_apic.c
| @@ -706,7 +706,7 @@ static void __unmask_IO_APIC_irq(struct irq_cfg *cfg)
| }
|
| #ifdef CONFIG_X86_64
| -void io_apic_sync(struct irq_pin_list *entry)
| +static void io_apic_sync(struct irq_pin_list *entry)
| {
| /*
| * Synchronize the IO-APIC and the CPU by doing
| --
| 1.5.5.1

Thanks Jaswinder! It should be static.

- Cyrill -