Hi, Randy & James,
The cxgb3i driver was using the skb->sp for some internal stuff. I have just submitted a patch to remove the usage of it since it is not really related to the secure path.
The patch is submitted to the list (http://marc.info/?l=linux-scsi&m=123061555414193&w=2) and is also attached here.
Sorry for the late response, I am traveling this week.
Thanks,
Karen
-----Original Message-----
From: Randy Dunlap [mailto:[email protected]]
Sent: Mon 12/29/2008 2:10 PM
To: James Bottomley
Cc: Stephen Rothwell; scsi; [email protected]; LKML; Karen Xie
Subject: Re: linux-next: Tree for December 29 (cxgb3i)
James Bottomley wrote:
> On Mon, 2008-12-29 at 12:35 -0800, Randy Dunlap wrote:
>> On Tue, 30 Dec 2008 03:16:21 +1100 Stephen Rothwell wrote:
>>
>>> Hi all,
>>>
>>> Changes since 20081219:
>>>
>>> Undropped tree:
>>> scci
>>> mtd
>>>
>>> Dropped trees (temporarily):
>>> nfs (akpm request due to 2.6.30 features)
>>> kvm (build problem)
>>> rr (build poblem)
>>> semaphore-removal (due to unfixed conflicts against Linus' tree)
>>> cpu_alloc (build problem)
>>> audit (difficult conflicts)
>>>
>>> Linus' tree had three build failures requiring patches and one requiring
>>> a revert.
>>
>> linux-next-20081229/drivers/scsi/cxgb3i/cxgb3i_offload.c:499: error: 'struct sk_buff' has no member named 'sp'
>> linux-next-20081229/drivers/scsi/cxgb3i/cxgb3i_offload.c:512: error: 'struct sk_buff' has no member named 'sp'
>> linux-next-20081229/drivers/scsi/cxgb3i/cxgb3i_offload.c:532: error: 'struct sk_buff' has no member named 'sp'
>> linux-next-20081229/drivers/scsi/cxgb3i/cxgb3i_offload.c:533: error: 'struct sk_buff' has no member named 'sp'
>
> In the config 20 questions, my guess for this is CONFIG_XFRM=n
That's correct. config file is now attached.
> I'm not at all sure why this driver is playing with the secure path ...
> I suspect the use needs to be enclosed in #ifdef CONFIG_XFRM pairs, but
> I'd like the maintainers to verify.
--
andy