2017-11-02 14:28:39

by Jens Axboe

[permalink] [raw]
Subject: Re: [PATCH] skd: use ktime_get_real_seconds()

On 11/02/2017 05:42 AM, Arnd Bergmann wrote:
> Like many storage drivers, skd uses an unsigned 32-bit number for
> interchanging the current time with the firmware. This will overflow in
> y2106 and is otherwise safe.
>
> However, the get_seconds() function is generally considered deprecated
> since the behavior is different between 32-bit and 64-bit architectures,
> and using it may indicate a bigger problem.
>
> To annotate that we've thought about this, let's add a comment here
> and migrate to the ktime_get_real_seconds() function that consistently
> returns a 64-bit number.

Thanks Arnd, applied.

--
Jens Axboe


From 1582954444303175063@xxx Thu Nov 02 11:43:17 +0000 2017
X-GM-THRID: 1582954444303175063
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread