2008-10-30 23:01:00

by David Brownell

[permalink] [raw]
Subject: [patch 2.6.28-rc2] CORE_DUMP_DEFAULT_ELF_HEADERS depends on ELF_CORE

From: David Brownell <[email protected]>

Kernels that don't support ELF coredumps at all surely can't
be supporting new partial-segment flavored ELF coredumps ...
don't make folk answer Kconfig questions about that flavor.

Signed-off-by: David Brownell <[email protected]>
Cc: Roland McGrath <[email protected]>
---
fs/Kconfig.binfmt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/fs/Kconfig.binfmt
+++ b/fs/Kconfig.binfmt
@@ -43,7 +43,7 @@ config BINFMT_ELF_FDPIC
config CORE_DUMP_DEFAULT_ELF_HEADERS
bool "Write ELF core dumps with partial segments"
default n
- depends on BINFMT_ELF
+ depends on BINFMT_ELF && ELF_CORE
help
ELF core dump files describe each memory mapping of the crashed
process, and can contain or omit the memory contents of each one.


2009-01-06 20:37:20

by David Brownell

[permalink] [raw]
Subject: Re: [patch 2.6.28-rc2] CORE_DUMP_DEFAULT_ELF_HEADERS depends on ELF_CORE

On Thursday 30 October 2008, David Brownell wrote:
> From: David Brownell <[email protected]>
>
> Kernels that don't support ELF coredumps at all surely can't
> be supporting new partial-segment flavored ELF coredumps ...
> don't make folk answer Kconfig questions about that flavor.

PING?

>
> Signed-off-by: David Brownell <[email protected]>
> Cc: Roland McGrath <[email protected]>
> ---
> fs/Kconfig.binfmt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/fs/Kconfig.binfmt
> +++ b/fs/Kconfig.binfmt
> @@ -43,7 +43,7 @@ config BINFMT_ELF_FDPIC
> config CORE_DUMP_DEFAULT_ELF_HEADERS
> bool "Write ELF core dumps with partial segments"
> default n
> - depends on BINFMT_ELF
> + depends on BINFMT_ELF && ELF_CORE
> help
> ELF core dump files describe each memory mapping of the crashed
> process, and can contain or omit the memory contents of each one.
>

2009-01-07 00:45:16

by Roland McGrath

[permalink] [raw]
Subject: Re: [patch 2.6.28-rc2] CORE_DUMP_DEFAULT_ELF_HEADERS depends on ELF_CORE

Acked-by: Roland McGrath <[email protected]>

> On Thursday 30 October 2008, David Brownell wrote:
> > From: David Brownell <[email protected]>
> >
> > Kernels that don't support ELF coredumps at all surely can't
> > be supporting new partial-segment flavored ELF coredumps ...
> > don't make folk answer Kconfig questions about that flavor.
>
> PING?
>
> >
> > Signed-off-by: David Brownell <[email protected]>
> > Cc: Roland McGrath <[email protected]>
> > ---
> > fs/Kconfig.binfmt | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --- a/fs/Kconfig.binfmt
> > +++ b/fs/Kconfig.binfmt
> > @@ -43,7 +43,7 @@ config BINFMT_ELF_FDPIC
> > config CORE_DUMP_DEFAULT_ELF_HEADERS
> > bool "Write ELF core dumps with partial segments"
> > default n
> > - depends on BINFMT_ELF
> > + depends on BINFMT_ELF && ELF_CORE
> > help
> > ELF core dump files describe each memory mapping of the crashed
> > process, and can contain or omit the memory contents of each one.
> >
>
>