2009-01-05 15:17:34

by FUJITA Tomonori

Subject: [PATCH] AMD IOMMU: remove unnecessary ifdef

Hmm, why do we need this ifdef? We should avoid it, I think.

=
From: FUJITA Tomonori <[email protected]>
Subject: [PATCH] AMD IOMMU: remove unnecessary ifdef

We try to avoid this type of ifdef and we can safely remove this
ifdef.

Signed-off-by: FUJITA Tomonori <[email protected]>
---
arch/x86/kernel/amd_iommu.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/amd_iommu.c b/arch/x86/kernel/amd_iommu.c
index 5113c08..d7a7c4c 100644
--- a/arch/x86/kernel/amd_iommu.c
+++ b/arch/x86/kernel/amd_iommu.c
@@ -23,9 +23,7 @@
#include <linux/debugfs.h>
#include <linux/scatterlist.h>
#include <linux/iommu-helper.h>
-#ifdef CONFIG_IOMMU_API
#include <linux/iommu.h>
-#endif
#include <asm/proto.h>
#include <asm/iommu.h>
#include <asm/gart.h>
--
1.6.0.6

2009-01-06 14:27:46

by Joerg Roedel

Subject: Re: [PATCH] AMD IOMMU: remove unnecessary ifdef

On Tue, Jan 06, 2009 at 12:17:09AM +0900, FUJITA Tomonori wrote:
> Hmm, why do we need this ifdef? We should avoid it, I think.
>
> =
> From: FUJITA Tomonori <[email protected]>
> Subject: [PATCH] AMD IOMMU: remove unnecessary ifdef
>
> We try to avoid this type of ifdef and we can safely remove this
> ifdef.
>
> Signed-off-by: FUJITA Tomonori <[email protected]>

Applied to iommu/amd, thanks.

--
| Advanced Micro Devices GmbH
Operating | Karl-Hammerschmidt-Str. 34, 85609 Dornach bei München
System |
Research | Geschäftsführer: Jochen Polster, Thomas M. McCoy, Giuliano Meroni
Center | Sitz: Dornach, Gemeinde Aschheim, Landkreis München
| Registergericht München, HRB Nr. 43632