2009-01-06 23:00:22

by Leonardo Potenza

Subject: [PATCH] x86: fix section mismatch warnings in mcheck/mce_amd_64.c

From: Leonardo Potenza <[email protected]>

The function local_allocate_threshold_blocks() has been marked __cpuinit, in order to remove the following section mismatch messages:

WARNING: arch/x86/kernel/cpu/mcheck/built-in.o(.text+0x1363): Section mismatch in reference from the function local_allocate_threshold_blocks() to the function .cpuinit.text:allocate_threshold_blocks()
The function local_allocate_threshold_blocks() references
the function __cpuinit allocate_threshold_blocks().
This is often because local_allocate_threshold_blocks lacks a __cpuinit
annotation or the annotation of allocate_threshold_blocks is wrong.

WARNING: arch/x86/kernel/cpu/built-in.o(.text+0x1def): Section mismatch in reference from the function local_allocate_threshold_blocks() to the function .cpuinit.text:allocate_threshold_blocks()
The function local_allocate_threshold_blocks() references
the function __cpuinit allocate_threshold_blocks().
This is often because local_allocate_threshold_blocks lacks a __cpuinit
annotation or the annotation of allocate_threshold_blocks is wrong.

WARNING: arch/x86/kernel/built-in.o(.text+0xef2b): Section mismatch in reference from the function local_allocate_threshold_blocks() to the function .cpuinit.text:allocate_threshold_blocks()
The function local_allocate_threshold_blocks() references
the function __cpuinit allocate_threshold_blocks().
This is often because local_allocate_threshold_blocks lacks a __cpuinit
annotation or the annotation of allocate_threshold_blocks is wrong.

Signed-off-by: Leonardo Potenza <[email protected]>
---
Index: linux-2.6/arch/x86/kernel/cpu/mcheck/mce_amd_64.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/cpu/mcheck/mce_amd_64.c 2009-01-06 23:03:19.000000000 +0100
+++ linux-2.6/arch/x86/kernel/cpu/mcheck/mce_amd_64.c 2009-01-06 23:07:00.000000000 +0100
@@ -462,7 +462,7 @@ out_free:
return err;
}

-static long local_allocate_threshold_blocks(void *_bank)
+static __cpuinit long local_allocate_threshold_blocks(void *_bank)
{
unsigned int *bank = _bank;

2009-01-07 11:24:36

by Ingo Molnar

Subject: Re: [PATCH] x86: fix section mismatch warnings in mcheck/mce_amd_64.c

* Leonardo Potenza <[email protected]> wrote:

> From: Leonardo Potenza <[email protected]>
>
> The function local_allocate_threshold_blocks() has been marked
> __cpuinit, in order to remove the following section mismatch messages:

applied to tip/x86/urgent, thanks Leonardo!

Ingo