2009-01-07 17:11:56

by Dhaval Giani

Subject: rcu: Make a seperate Kconfig menu for RCU

Hi Paul, Ingo,

On selecting tree RCU, there are a total of 4 different RCU Kconfig options.
Maybe its time to give RCU a menu of its own.

Signed-off-by: Dhaval Giani <[email protected]>

---
init/Kconfig | 4 ++++
1 file changed, 4 insertions(+)

Index: linux-2.6/init/Kconfig
===================================================================
--- linux-2.6.orig/init/Kconfig 2009-01-07 10:18:17.000000000 +0530
+++ linux-2.6/init/Kconfig 2009-01-07 21:01:39.000000000 +0530
@@ -945,6 +945,8 @@ source "block/Kconfig"
config PREEMPT_NOTIFIERS
bool

+menu "RCU related options"
+
choice
prompt "RCU Implementation"
default CLASSIC_RCU
@@ -1032,3 +1034,5 @@ config PREEMPT_RCU_TRACE
help
This option provides tracing for the PREEMPT_RCU implementation,
permitting Makefile to trivially select kernel/rcupreempt_trace.c.
+
+endmenu
--
regards,
Dhaval

2009-01-07 17:19:13

by Paul E. McKenney

Subject: Re: rcu: Make a seperate Kconfig menu for RCU

On Wed, Jan 07, 2009 at 10:40:17PM +0530, Dhaval Giani wrote:
> Hi Paul, Ingo,
>
> On selecting tree RCU, there are a total of 4 different RCU Kconfig options.
> Maybe its time to give RCU a menu of its own.

Looks good to me!

Reviewed-by: Paul E. McKenneyh <[email protected]>

> Signed-off-by: Dhaval Giani <[email protected]>
>
> ---
> init/Kconfig | 4 ++++
> 1 file changed, 4 insertions(+)
>
> Index: linux-2.6/init/Kconfig
> ===================================================================
> --- linux-2.6.orig/init/Kconfig 2009-01-07 10:18:17.000000000 +0530
> +++ linux-2.6/init/Kconfig 2009-01-07 21:01:39.000000000 +0530
> @@ -945,6 +945,8 @@ source "block/Kconfig"
> config PREEMPT_NOTIFIERS
> bool
>
> +menu "RCU related options"
> +
> choice
> prompt "RCU Implementation"
> default CLASSIC_RCU
> @@ -1032,3 +1034,5 @@ config PREEMPT_RCU_TRACE
> help
> This option provides tracing for the PREEMPT_RCU implementation,
> permitting Makefile to trivially select kernel/rcupreempt_trace.c.
> +
> +endmenu
> --
> regards,
> Dhaval

2009-01-07 17:26:06

by Dhaval Giani

Subject: Re: rcu: Make a seperate Kconfig menu for RCU

On Wed, Jan 07, 2009 at 09:18:51AM -0800, Paul E. McKenney wrote:
> On Wed, Jan 07, 2009 at 10:40:17PM +0530, Dhaval Giani wrote:
> > Hi Paul, Ingo,
> >
> > On selecting tree RCU, there are a total of 4 different RCU Kconfig options.
> > Maybe its time to give RCU a menu of its own.
>
> Looks good to me!
>
> Reviewed-by: Paul E. McKenneyh <[email protected]>
>
> > Signed-off-by: Dhaval Giani <[email protected]>
> >

And I messed up Ingo's email address in the initial post. Correcting it!

> > ---
> > init/Kconfig | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > Index: linux-2.6/init/Kconfig
> > ===================================================================
> > --- linux-2.6.orig/init/Kconfig 2009-01-07 10:18:17.000000000 +0530
> > +++ linux-2.6/init/Kconfig 2009-01-07 21:01:39.000000000 +0530
> > @@ -945,6 +945,8 @@ source "block/Kconfig"
> > config PREEMPT_NOTIFIERS
> > bool
> >
> > +menu "RCU related options"
> > +
> > choice
> > prompt "RCU Implementation"
> > default CLASSIC_RCU
> > @@ -1032,3 +1034,5 @@ config PREEMPT_RCU_TRACE
> > help
> > This option provides tracing for the PREEMPT_RCU implementation,
> > permitting Makefile to trivially select kernel/rcupreempt_trace.c.
> > +
> > +endmenu

--
regards,
Dhaval