2009-01-08 16:12:37

by Heiko Carstens

Subject: [PATCH] wimax: fix compile bug

From: Heiko Carstens <[email protected]>

wimax should depend on INPUT:

net/built-in.o: In function `wimax_rfkill_rm':
linux-2.6/net/wimax/op-rfkill.c:428: undefined reference to `input_unregister_device'
net/built-in.o: In function `wimax_rfkill_add':
linux-2.6/net/wimax/op-rfkill.c:370: undefined reference to `input_allocate_device'
linux-2.6/net/wimax/op-rfkill.c:384: undefined reference to `input_register_device'
linux-2.6/net/wimax/op-rfkill.c:402: undefined reference to `input_unregister_device'
linux-2.6/net/wimax/op-rfkill.c:406: undefined reference to `input_free_device'
net/built-in.o: In function `input_report_key':
linux-2.6/include/linux/input.h:1285: undefined reference to `input_event'

Cc: Inaky Perez-Gonzalez <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Signed-off-by: Heiko Carstens <[email protected]>
---
net/wimax/Kconfig | 1 +
1 file changed, 1 insertion(+)

Index: linux-2.6/net/wimax/Kconfig
===================================================================
--- linux-2.6.orig/net/wimax/Kconfig
+++ linux-2.6/net/wimax/Kconfig
@@ -4,6 +4,7 @@

menuconfig WIMAX
tristate "WiMAX Wireless Broadband support"
+ depends on INPUT
help

Select to configure support for devices that provide

2009-01-08 16:54:34

by Greg KH

Subject: Re: [PATCH] wimax: fix compile bug

On Thu, Jan 08, 2009 at 05:12:22PM +0100, Heiko Carstens wrote:
> From: Heiko Carstens <[email protected]>
>
> wimax should depend on INPUT:

<snip>

Inaky just sent a series of 3 patches to the netdev mailing list fixing
this up in a much better way.

thanks,

greg k-h

2009-01-08 16:58:20

by David Miller

Subject: Re: [PATCH] wimax: fix compile bug

From: Greg KH <[email protected]>
Date: Thu, 8 Jan 2009 08:52:54 -0800

> On Thu, Jan 08, 2009 at 05:12:22PM +0100, Heiko Carstens wrote:
> > From: Heiko Carstens <[email protected]>
> >
> > wimax should depend on INPUT:
>
> <snip>
>
> Inaky just sent a series of 3 patches to the netdev mailing list fixing
> this up in a much better way.

Yep, I'll be integrating his patches during the course of
today.

2009-01-08 17:01:33

by Heiko Carstens

Subject: Re: [PATCH] wimax: fix compile bug

On Thu, Jan 08, 2009 at 08:58:06AM -0800, David Miller wrote:
> From: Greg KH <[email protected]>
> Date: Thu, 8 Jan 2009 08:52:54 -0800
>
> > On Thu, Jan 08, 2009 at 05:12:22PM +0100, Heiko Carstens wrote:
> > > From: Heiko Carstens <[email protected]>
> > >
> > > wimax should depend on INPUT:
> >
> > <snip>
> >
> > Inaky just sent a series of 3 patches to the netdev mailing list fixing
> > this up in a much better way.
>
> Yep, I'll be integrating his patches during the course of
> today.

Even better. Thanks!

2009-01-08 17:03:52

by Marcel Holtmann

Subject: Re: [PATCH] wimax: fix compile bug

Hi Heiko,

> wimax should depend on INPUT:
>
> net/built-in.o: In function `wimax_rfkill_rm':
> linux-2.6/net/wimax/op-rfkill.c:428: undefined reference to `input_unregister_device'
> net/built-in.o: In function `wimax_rfkill_add':
> linux-2.6/net/wimax/op-rfkill.c:370: undefined reference to `input_allocate_device'
> linux-2.6/net/wimax/op-rfkill.c:384: undefined reference to `input_register_device'
> linux-2.6/net/wimax/op-rfkill.c:402: undefined reference to `input_unregister_device'
> linux-2.6/net/wimax/op-rfkill.c:406: undefined reference to `input_free_device'
> net/built-in.o: In function `input_report_key':
> linux-2.6/include/linux/input.h:1285: undefined reference to `input_event'
>
> Cc: Inaky Perez-Gonzalez <[email protected]>
> Cc: Greg Kroah-Hartman <[email protected]>
> Signed-off-by: Heiko Carstens <[email protected]>

actually Inaky posted a different fix for this to netdev yesterday.

Regards

Marcel

2009-01-08 18:17:38

by Inaky Perez-Gonzalez

Subject: Re: [PATCH] wimax: fix compile bug

On Thursday 08 January 2009, David Miller wrote:
> From: Greg KH <[email protected]>
> Date: Thu, 8 Jan 2009 08:52:54 -0800
>
> > On Thu, Jan 08, 2009 at 05:12:22PM +0100, Heiko Carstens wrote:
> > > From: Heiko Carstens <[email protected]>
> > >
> > > wimax should depend on INPUT:
> >
> > <snip>
> >
> > Inaky just sent a series of 3 patches to the netdev mailing list fixing
> > this up in a much better way.
>
> Yep, I'll be integrating his patches during the course of
> today.

Thanks David

Please be sure to integrate v3 of the patchset
(http://lkml.org/lkml/2009/1/7/397), shows as the 1/4 series
in patchwork.ozlabs.org.

--
Inaky

2009-01-08 18:36:18

by David Miller

Subject: Re: [PATCH] wimax: fix compile bug

From: Inaky Perez-Gonzalez <[email protected]>
Date: Thu, 8 Jan 2009 10:11:56 -0800

> Please be sure to integrate v3 of the patchset
> (http://lkml.org/lkml/2009/1/7/397), shows as the 1/4 series
> in patchwork.ozlabs.org.

Right.