2009-01-13 05:06:20

by David Miller

[permalink] [raw]
Subject: pcf50663 MFD driver modular build failure


This started happening with Linus's pull from today for
sparc64 allmodconfig:

ERROR: "__set_irq_handler" [drivers/mfd/pcf50633-core.ko] undefined!
ERROR: "handle_level_irq" [drivers/mfd/pcf50633-core.ko] undefined!

Sure we can export __set_irq_handler() and handle_level_irq() to
modules to fix this, but that looks like some hokey stuff for
a MFD driver to be doing :-)


2009-01-13 06:52:50

by Balaji Rao

[permalink] [raw]
Subject: Re: pcf50663 MFD driver modular build failure

On Mon, Jan 12, 2009 at 09:05:01PM -0800, David Miller wrote:
>
> This started happening with Linus's pull from today for
> sparc64 allmodconfig:
>
> ERROR: "__set_irq_handler" [drivers/mfd/pcf50633-core.ko] undefined!
> ERROR: "handle_level_irq" [drivers/mfd/pcf50633-core.ko] undefined!
>
> Sure we can export __set_irq_handler() and handle_level_irq() to
> modules to fix this, but that looks like some hokey stuff for
> a MFD driver to be doing :-)

Yes, right! It's really not necessary. I've sent a patch to remove it.

Thanks,
Balaji

2009-01-14 01:29:47

by Kyle McMartin

[permalink] [raw]
Subject: Re: pcf50663 MFD driver modular build failure

On Tue, Jan 13, 2009 at 12:22:02PM +0530, Balaji Rao wrote:
> On Mon, Jan 12, 2009 at 09:05:01PM -0800, David Miller wrote:
> >
> > This started happening with Linus's pull from today for
> > sparc64 allmodconfig:
> >
> > ERROR: "__set_irq_handler" [drivers/mfd/pcf50633-core.ko] undefined!
> > ERROR: "handle_level_irq" [drivers/mfd/pcf50633-core.ko] undefined!
> >
> > Sure we can export __set_irq_handler() and handle_level_irq() to
> > modules to fix this, but that looks like some hokey stuff for
> > a MFD driver to be doing :-)
>
> Yes, right! It's really not necessary. I've sent a patch to remove it.
>

Thanks, I just hit this on a rawhide build as well...

2009-01-14 21:49:57

by Randy Dunlap

[permalink] [raw]
Subject: Re: pcf50663 MFD driver modular build failure

On Tue, 13 Jan 2009 12:22:02 +0530 Balaji Rao wrote:

> On Mon, Jan 12, 2009 at 09:05:01PM -0800, David Miller wrote:
> >
> > This started happening with Linus's pull from today for
> > sparc64 allmodconfig:
> >
> > ERROR: "__set_irq_handler" [drivers/mfd/pcf50633-core.ko] undefined!
> > ERROR: "handle_level_irq" [drivers/mfd/pcf50633-core.ko] undefined!
> >
> > Sure we can export __set_irq_handler() and handle_level_irq() to
> > modules to fix this, but that looks like some hokey stuff for
> > a MFD driver to be doing :-)
>
> Yes, right! It's really not necessary. I've sent a patch to remove it.

Who did you send the patch to and where is it in the queue??

thanks,
---
~Randy

2009-01-15 05:04:28

by Balaji Rao

[permalink] [raw]
Subject: Re: pcf50663 MFD driver modular build failure

On Wed, Jan 14, 2009 at 01:47:12PM -0800, Randy Dunlap wrote:
> On Tue, 13 Jan 2009 12:22:02 +0530 Balaji Rao wrote:
>
> > On Mon, Jan 12, 2009 at 09:05:01PM -0800, David Miller wrote:
> > >
> > > This started happening with Linus's pull from today for
> > > sparc64 allmodconfig:
> > >
> > > ERROR: "__set_irq_handler" [drivers/mfd/pcf50633-core.ko] undefined!
> > > ERROR: "handle_level_irq" [drivers/mfd/pcf50633-core.ko] undefined!
> > >
> > > Sure we can export __set_irq_handler() and handle_level_irq() to
> > > modules to fix this, but that looks like some hokey stuff for
> > > a MFD driver to be doing :-)
> >
> > Yes, right! It's really not necessary. I've sent a patch to remove it.
>
> Who did you send the patch to and where is it in the queue??

Samuel has taken it into his linux-mfd tree and should be sending a pull
request real soon.

Thanks,
Balaji