2009-01-14 15:10:59

by Jaswinder Singh Rajput

Subject: [PATCH -tip] time-sched.c: tick_nohz_update_jiffies should be static

Impact: cleanup, reduce kernel size a bit, avoid sparse warning

Fixes sparse warning:
kernel/time/tick-sched.c:137:6: warning: symbol 'tick_nohz_update_jiffies' was not declared. Should it be static?

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
kernel/time/tick-sched.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
index 1b6c05b..d3f1ef4 100644
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -134,7 +134,7 @@ __setup("nohz=", setup_tick_nohz);
* value. We do this unconditionally on any cpu, as we don't know whether the
* cpu, which has the update task assigned is in a long sleep.
*/
-void tick_nohz_update_jiffies(void)
+static void tick_nohz_update_jiffies(void)
{
int cpu = smp_processor_id();
struct tick_sched *ts = &per_cpu(tick_cpu_sched, cpu);
--
1.6.0.6

2009-01-15 11:07:43

by Ingo Molnar

Subject: Re: [PATCH -tip] time-sched.c: tick_nohz_update_jiffies should be static

* Jaswinder Singh Rajput <[email protected]> wrote:

> Impact: cleanup, reduce kernel size a bit, avoid sparse warning
>
> Fixes sparse warning:
> kernel/time/tick-sched.c:137:6: warning: symbol 'tick_nohz_update_jiffies' was not declared. Should it be static?
>
> Signed-off-by: Jaswinder Singh Rajput <[email protected]>
> ---
> kernel/time/tick-sched.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)

applied to tip/timers/urgent, thanks Jaswinder!

Ingo