2009-01-15 21:09:22

by Roland McGrath

Subject: [PATCH] trailing whitespace in kernel/ptrace.c

These bug me every time I want to touch ptrace.c, nix them.

Signed-off-by: Roland McGrath <[email protected]>
---
kernel/ptrace.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/ptrace.c b/kernel/ptrace.c
index c9cf48b..8f61ad8 100644
--- a/kernel/ptrace.c
+++ b/kernel/ptrace.c
@@ -48,7 +48,7 @@ void __ptrace_link(struct task_struct *child, struct task_struct *new_parent)
list_add(&child->ptrace_entry, &new_parent->ptraced);
child->parent = new_parent;
}
-
+
/*
* Turn a tracing stop into a normal stop now, since with no tracer there
* would be no way to wake it up with SIGCONT or SIGKILL. If there was a
@@ -283,7 +283,7 @@ int ptrace_readdata(struct task_struct *tsk, unsigned long src, char __user *dst
copied += retval;
src += retval;
dst += retval;
- len -= retval;
+ len -= retval;
}
return copied;
}
@@ -308,7 +308,7 @@ int ptrace_writedata(struct task_struct *tsk, char __user *src, unsigned long ds
copied += retval;
src += retval;
dst += retval;
- len -= retval;
+ len -= retval;
}
return copied;
}

2009-01-15 22:54:06

by Ingo Molnar

Subject: Re: [PATCH] trailing whitespace in kernel/ptrace.c

* Roland McGrath <[email protected]> wrote:

> These bug me every time I want to touch ptrace.c, nix them.
>
> Signed-off-by: Roland McGrath <[email protected]>
> ---
> kernel/ptrace.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)

btw., here's the checkpatch output from that file:

------------------>

WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
#26: FILE: ptrace.c:26:
+#include <asm/uaccess.h>

ERROR: trailing whitespace
#51: FILE: ptrace.c:51:
+ $

WARNING: braces {} are not necessary for any arm of this statement
#63: FILE: ptrace.c:63:
+ if (child->signal->flags & SIGNAL_STOP_STOPPED) {
[...]
+ } else {
[...]

CHECK: memory barrier without comment
#157: FILE: ptrace.c:157:
+ smp_rmb();

ERROR: return is not a function, parentheses are not required
#172: FILE: ptrace.c:172:
+ return (!err ? true : false);

WARNING: line over 80 characters
#266: FILE: ptrace.c:266:
+int ptrace_readdata(struct task_struct *tsk, unsigned long src, char __user *dst, int len)

ERROR: trailing whitespace
#286: FILE: ptrace.c:286:
+^I^Ilen -= retval;^I^I^I$

WARNING: line over 80 characters
#291: FILE: ptrace.c:291:
+int ptrace_writedata(struct task_struct *tsk, char __user *src, unsigned long dst, int len)

ERROR: trailing whitespace
#311: FILE: ptrace.c:311:
+^I^Ilen -= retval;^I^I^I$

ERROR: else should follow close brace '}'
#425: FILE: ptrace.c:425:
+ }
+ else

WARNING: line over 80 characters
#455: FILE: ptrace.c:455:
+ ret = put_user(child->ptrace_message, (unsigned long __user *) data);

total: 5 errors, 6 warnings, 1 checks, 741 lines checked

kernel/ptrace.c has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2009-01-16 20:45:27

by Andrew Morton

Subject: Re: [PATCH] trailing whitespace in kernel/ptrace.c

On Thu, 15 Jan 2009 23:11:35 +0100
Ingo Molnar <[email protected]> wrote:

>
> * Roland McGrath <[email protected]> wrote:
>
> > These bug me every time I want to touch ptrace.c, nix them.
> >
> > Signed-off-by: Roland McGrath <[email protected]>
> > ---
> > kernel/ptrace.c | 6 +++---
> > 1 files changed, 3 insertions(+), 3 deletions(-)
>
> btw., here's the checkpatch output from that file:

Yes, we might as well fix all of them while we're there.

> WARNING: line over 80 characters
> WARNING: line over 80 characters
> WARNING: line over 80 characters

but maybe not those.