2009-01-23 14:06:50

by Arnaldo Carvalho de Melo

[permalink] [raw]
Subject: [PATCH tip][0/2] ftrace interface for blktrace

Hi Jens,

Here is a third version, that also implements blk_add_trace_msg,
using ftrace_vprintk.

As soon as the TRACE_ITER_CONTEXT_INFO option is implemented
I'll provide the struct trace_event->bin() callback to synthesize the
old blktrace record format so that we can test the output of trace_pipe
with blkparse -i -.

Please let me know if this is acceptable for inclusion on
linux-tip.

Best Regards,

- Arnaldo

block/blktrace.c | 651 ++++++++++++++++++++++++++++++++++++++++++++++++-
fs/partitions/check.c | 7
include/linux/ftrace.h | 8
kernel/trace/trace.c | 9
kernel/trace/trace.h | 1
5 files changed, 671 insertions(+), 5 deletions(-)


2009-01-26 11:44:14

by Jens Axboe

[permalink] [raw]
Subject: Re: [PATCH tip][0/2] ftrace interface for blktrace

On Fri, Jan 23 2009, Arnaldo Carvalho de Melo wrote:
> Hi Jens,
>
> Here is a third version, that also implements blk_add_trace_msg,
> using ftrace_vprintk.
>
> As soon as the TRACE_ITER_CONTEXT_INFO option is implemented
> I'll provide the struct trace_event->bin() callback to synthesize the
> old blktrace record format so that we can test the output of trace_pipe
> with blkparse -i -.
>
> Please let me know if this is acceptable for inclusion on
> linux-tip.

Sure, go ahead and add it!

--
Jens Axboe

2009-01-26 13:43:47

by Ingo Molnar

[permalink] [raw]
Subject: Re: [PATCH tip][0/2] ftrace interface for blktrace


* Jens Axboe <[email protected]> wrote:

> On Fri, Jan 23 2009, Arnaldo Carvalho de Melo wrote:
> > Hi Jens,
> >
> > Here is a third version, that also implements blk_add_trace_msg,
> > using ftrace_vprintk.
> >
> > As soon as the TRACE_ITER_CONTEXT_INFO option is implemented
> > I'll provide the struct trace_event->bin() callback to synthesize the
> > old blktrace record format so that we can test the output of trace_pipe
> > with blkparse -i -.
> >
> > Please let me know if this is acceptable for inclusion on
> > linux-tip.
>
> Sure, go ahead and add it!

Cool - i've started tracking Arnaldo's patch by picking up the latest
version into tip/tracing/blktrace and merging it into tip/master.

Arnaldo, could you please check latest tip/master:

http://people.redhat.com/mingo/tip.git/README

to see whether it's all OK, integrated with the latest tracing bits?

Ingo