2009-01-29 15:29:22

by Roel Kluin

Subject: [PATCH] mfd: tries reaches -1

With a postfix decrement tries will reach -1 rather than 0,
so the warning will not be issued even upon timeout.

Signed-off-by: Roel Kluin <[email protected]>
---
diff --git a/drivers/mfd/wm8350-core.c b/drivers/mfd/wm8350-core.c
index f92595c..2e0e5c2 100644
--- a/drivers/mfd/wm8350-core.c
+++ b/drivers/mfd/wm8350-core.c
@@ -1111,7 +1111,7 @@ int wm8350_read_auxadc(struct wm8350 *wm8350, int channel, int scale, int vref)
do {
schedule_timeout_interruptible(1);
reg = wm8350_reg_read(wm8350, WM8350_DIGITISER_CONTROL_1);
- } while (tries-- && (reg & WM8350_AUXADC_POLL));
+ } while (--tries && (reg & WM8350_AUXADC_POLL));

if (!tries)
dev_err(wm8350->dev, "adc chn %d read timeout\n", channel);

2009-01-29 18:29:24

by Mark Brown

Subject: Re: [PATCH] mfd: tries reaches -1

On Thu, Jan 29, 2009 at 04:29:09PM +0100, Roel Kluin wrote:
> With a postfix decrement tries will reach -1 rather than 0,
> so the warning will not be issued even upon timeout.

> Signed-off-by: Roel Kluin <[email protected]>

Applied, thanks. I'll add this to my queue of things I'm pushing to
Samuel.

Acked-by: Mark Brown <[email protected]>