2009-03-09 20:29:23

by Mikael Pettersson

[permalink] [raw]
Subject: [BUG] 2.6.29-rc7 broke r8169 MAC on Thecus n2100 ARM board

With the 2.6.29-rc7 kernel I'm unable to 'ifup' eth0 on my ARM-based
Thecus n2100 NAS box, which has an RTL8169 NIC (10ec:8169 (rev 10)).
A diff of the kernel logs from 2.6.29-rc6 and -rc7 shows that -rc7
first mangles and then zaps the MAC addresses:

--- dmesg-2.6.29-rc6 2009-03-09 20:27:49.000000000 +0100
+++ dmesg-2.6.29-rc7 2009-03-09 20:25:54.000000000 +0100
@@ -145,11 +145,13 @@
r8169 Gigabit Ethernet driver 2.3LK-NAPI loaded
r8169 0000:00:01.0: enabling Mem-Wr-Inval
r8169 0000:00:01.0: no PCI Express capability
-eth0: RTL8169sb/8110sb at 0xe080c200, 00:14:fd:30:11:78, XID 10000000 IRQ 27
+r8169 0000:00:01.0: MAC address found in EEPROM: 00:14:fd:10:00:00
+eth0: RTL8169sb/8110sb at 0xe080c200, 00:00:00:00:00:00, XID 10000000 IRQ 27
r8169 Gigabit Ethernet driver 2.3LK-NAPI loaded
r8169 0000:00:02.0: enabling Mem-Wr-Inval
r8169 0000:00:02.0: no PCI Express capability
-eth1: RTL8169sb/8110sb at 0xe0810300, 00:14:fd:30:11:79, XID 10000000 IRQ 30
+r8169 0000:00:02.0: MAC address found in EEPROM: 00:14:fd:10:00:00
+eth1: RTL8169sb/8110sb at 0xe0810300, 00:00:00:00:00:00, XID 10000000 IRQ 30
Driver 'sd' needs updating - please use bus_type methods
sata_sil 0000:00:03.0: version 2.4
sata_sil 0000:00:03.0: Applying R_ERR on DMA activate FIS errata fix
@@ -242,6 +244,4 @@
EXT3 FS on sda5, internal journal
EXT3-fs: mounted filesystem with ordered data mode.
Adding 2008116k swap on /dev/sda3. Priority:-1 extents:1 across:2008116k
-r8169: eth0: link up
-r8169: eth0: link up
warning: `dbus-daemon' uses 32-bit capabilities (legacy support in use)

Reverting 6709fe9a27e43a4931938fe0d7f2cc5edef31386
"r8169: read MAC address from EEPROM on init (2nd attempt)"
fixes the problem on this machine.

/Mikael


2009-03-13 20:12:27

by Francois Romieu

[permalink] [raw]
Subject: Re: [BUG] 2.6.29-rc7 broke r8169 MAC on Thecus n2100 ARM board

Mikael Pettersson <[email protected]> :
> With the 2.6.29-rc7 kernel I'm unable to 'ifup' eth0 on my ARM-based
> Thecus n2100 NAS box, which has an RTL8169 NIC (10ec:8169 (rev 10)).
> A diff of the kernel logs from 2.6.29-rc6 and -rc7 shows that -rc7
> first mangles and then zaps the MAC addresses:

Can you apply the attached patch and see if it fixes any of these
problems ?

Tim, could you give it a try too ? It applies with "patch -p1" from
the kernel tree directory.

--
Ueimor


Attachments:
(No filename) (483.00 B)
r8169-init-mac-20.patch (2.03 kB)
Download all attachments

2009-03-14 02:29:38

by Tim Durack

[permalink] [raw]
Subject: Re: [BUG] 2.6.29-rc7 broke r8169 MAC on Thecus n2100 ARM board

On Fri, Mar 13, 2009 at 4:15 PM, Francois Romieu <[email protected]> wrote:
> Mikael Pettersson <[email protected]> :
>> With the 2.6.29-rc7 kernel I'm unable to 'ifup' eth0 on my ARM-based
>> Thecus n2100 NAS box, which has an RTL8169 NIC (10ec:8169 (rev 10)).
>> A diff of the kernel logs from 2.6.29-rc6 and -rc7 shows that -rc7
>> first mangles and then zaps the MAC addresses:
>
> Can you apply the attached patch and see if it fixes any of these
> problems ?
>
> Tim, could you give it a try too ? It applies with "patch -p1" from
> the kernel tree directory.
>
> --
> Ueimor
>

No luck:

B-25-1NOC-CFG-1:~# modprobe -if r8169
[ 120.938729] r8169 Gigabit Ethernet driver 2.3LK-NAPI loaded
[ 120.945018] r8169 0000:00:09.0: PCI INT A -> GSI 18 (level, low) -> IRQ 18
[ 120.953409] r8169 0000:00:09.0: no PCI Express capability
[ 120.960359] r8169 0000:00:09.0: MAC address found in EEPROM:
00:30:18:ab:f0:34
[ 120.978441] eth1: RTL8169sc/8110sc at 0xf8154000,
00:00:00:00:f0:34, XID 18000000 IRQ 18
[ 120.988468] r8169 Gigabit Ethernet driver 2.3LK-NAPI loaded
[ 120.994119] r8169 0000:00:0b.0: PCI INT A -> GSI 19 (level, low) -> IRQ 19
[ 121.001139] r8169 0000:00:0b.0: no PCI Express capability
[ 121.006922] r8169 0000:00:0b.0: MAC address found in EEPROM:
00:30:18:ab:f0:35
[ 121.063615] eth2: RTL8169sc/8110sc at 0xf801e000,
00:00:00:00:f0:35, XID 18000000 IRQ 19
[ 121.072495] r8169 Gigabit Ethernet driver 2.3LK-NAPI loaded
[ 121.078188] r8169 0000:00:0c.0: PCI INT A -> GSI 16 (level, low) -> IRQ 16
[ 121.085239] r8169 0000:00:0c.0: no PCI Express capability
[ 121.091025] r8169 0000:00:0c.0: MAC address found in EEPROM:
00:30:18:ab:f0:36
[ 121.147502] eth3: RTL8169sc/8110sc at 0xf8022000,
00:00:00:00:f0:36, XID 18000000 IRQ 16

Tim:>

2009-03-14 11:40:00

by Mikael Pettersson

[permalink] [raw]
Subject: Re: [BUG] 2.6.29-rc7 broke r8169 MAC on Thecus n2100 ARM board

Tim Durack writes:
> On Fri, Mar 13, 2009 at 4:15 PM, Francois Romieu <[email protected]>wrote:
>
> > Mikael Pettersson <[email protected]> :
> > > With the 2.6.29-rc7 kernel I'm unable to 'ifup' eth0 on my ARM-based
> > > Thecus n2100 NAS box, which has an RTL8169 NIC (10ec:8169 (rev 10)).
> > > A diff of the kernel logs from 2.6.29-rc6 and -rc7 shows that -rc7
> > > first mangles and then zaps the MAC addresses:
> >
> > Can you apply the attached patch and see if it fixes any of these
> > problems ?
> >
> > Tim, could you give it a try too ? It applies with "patch -p1" from
> > the kernel tree directory.
> >
> > --
> > Ueimor
> >
>
> No luck:

No joy here either. 2.6.29-rc8 + this patch shows the same misbehaviour
as 2.6.29-rc7 had. Here's a minicom log of an attempted boot:

(kernel messages)

r8169 Gigabit Ethernet driver 2.3LK-NAPI loaded
r8169 0000:00:01.0: no PCI Express capability
r8169 0000:00:01.0: MAC address found in EEPROM: 00:14:fd:10:00:00
eth0: RTL8169sb/8110sb at 0xe080c200, 00:00:00:00:00:00, XID 10000000 IRQ 27
r8169 Gigabit Ethernet driver 2.3LK-NAPI loaded
r8169 0000:00:02.0: no PCI Express capability
r8169 0000:00:02.0: MAC address found in EEPROM: 00:14:fd:10:00:00
eth1: RTL8169sb/8110sb at 0xe0810300, 00:00:00:00:00:00, XID 10000000 IRQ 30

(init messages)

Bringing up interface eth0: RTNETLINK answers: Cannot assign requested address
Failed to bring up eth0.

May I suggest that 6709fe9a27e43a4931938fe0d7f2cc5edef31386 is reverted
until this regression is debugged and fixed?

/Mikael

2009-03-15 10:07:58

by Francois Romieu

[permalink] [raw]
Subject: Re: [BUG] 2.6.29-rc7 broke r8169 MAC on Thecus n2100 ARM board

Mikael Pettersson <[email protected]> :
[...]
> May I suggest that 6709fe9a27e43a4931938fe0d7f2cc5edef31386 is reverted
> until this regression is debugged and fixed?

Yes.

--
Ueimor