From: Jing Huang <[email protected]>
This is the an interim submission of Brocade BFA FC SCSI Driver for code review.
We moved FC protocol/port state machine part of the driver to the firmware to
make the driver simpler. We also implemented the code review comments received
from last submission which includes: 1) replaced bfa specific list management
routines by standard linux list implemetation. 2) Other minor fixes such as
namming, kconfig etc.
Please note that this driver is still not fully functioning. We expect to do
anoher submssion next week after we complete all the changes.
It contains a serial of 5 patches generated using 2.6.29-rc8 kernel. Here is
a brief description of each patch:
[PATCH 1/5]: Linux driver specific code, things such as module load/unload,
PCI probe/release, interrupt handler, and sysfs interface etc. All the files
start with "bfad_" prefix.
[PATCH 2/5]: Hardware/FW access code. All files start with "bfa_" prefix.
[PATCH 3/5]: Common header files shared by linux driver specific and
hardware/FW access code.
[PATCH 4/5]: Updated Kconfig and Makefile for driver/scsi, and Makefile
for bfa driver
[PATCH 5/5]: Updated MAINTAINER file.
Signed-off-by: Jing Huang <[email protected]>
---
On Sat, Mar 14, 2009 at 12:52:40PM -0700, Jing Huang wrote:
> From: Jing Huang <[email protected]>
>
> This is the an interim submission of Brocade BFA FC SCSI Driver for code review.
> We moved FC protocol/port state machine part of the driver to the firmware to
> make the driver simpler. We also implemented the code review comments received
> from last submission which includes: 1) replaced bfa specific list management
> routines by standard linux list implemetation. 2) Other minor fixes such as
> namming, kconfig etc.
>
> Please note that this driver is still not fully functioning. We expect to do
> anoher submssion next week after we complete all the changes.
>
> It contains a serial of 5 patches generated using 2.6.29-rc8 kernel. Here is
> a brief description of each patch:
>
> [PATCH 1/5]: Linux driver specific code, things such as module load/unload,
> PCI probe/release, interrupt handler, and sysfs interface etc. All the files
> start with "bfad_" prefix.
>
> [PATCH 2/5]: Hardware/FW access code. All files start with "bfa_" prefix.
>
> [PATCH 3/5]: Common header files shared by linux driver specific and
> hardware/FW access code.
>
> [PATCH 4/5]: Updated Kconfig and Makefile for driver/scsi, and Makefile
> for bfa driver
>
> [PATCH 5/5]: Updated MAINTAINER file.
Your submission was screwed up somehow?
You had plenty of [0/5]....
Have you ran this through checkpatch - and what is the result?
Have you run this through sparse - and what is the result?
If you have done it - please document it.
If not then please do - fix relevant issues - and document it.
Sam
>
> Your submission was screwed up somehow?
> You had plenty of [0/5]....
>
Yes, I forgot to increment the number so I sent them again. Sorry about
the mess.
> Have you ran this through checkpatch - and what is the result?
> Have you run this through sparse - and what is the result?
>
We did ran checkpatch and sparse, it used to be 100% clean, but recently
we made a lot of changes to our driver, and some new issues have been
introduced, we will fix them in next submission.
Thanks for the reviewing the code!