2009-03-15 01:33:40

by Robin H. Johnson

[permalink] [raw]
Subject: [PATCH UVC] Add UVC entry for Logitech Quickcam Orbit AF.

Need explicit entry like many of the other Logitech devices as it does
not match the class otherwise.

Signed-off-by: Robin H. Johnson <[email protected]>
---
drivers/media/video/uvc/uvc_driver.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/drivers/media/video/uvc/uvc_driver.c b/drivers/media/video/uvc/uvc_driver.c
index b128732..f5e76c8 100644
--- a/drivers/media/video/uvc/uvc_driver.c
+++ b/drivers/media/video/uvc/uvc_driver.c
@@ -1801,6 +1801,14 @@ static struct usb_device_id uvc_ids[] = {
.bInterfaceClass = USB_CLASS_VENDOR_SPEC,
.bInterfaceSubClass = 1,
.bInterfaceProtocol = 0 },
+ /* Logitech Quickcam Orbit AF */
+ { .match_flags = USB_DEVICE_ID_MATCH_DEVICE
+ | USB_DEVICE_ID_MATCH_INT_INFO,
+ .idVendor = 0x046d,
+ .idProduct = 0x0994,
+ .bInterfaceClass = USB_CLASS_VENDOR_SPEC,
+ .bInterfaceSubClass = 1,
+ .bInterfaceProtocol = 0 },
/* Logitech Quickcam Pro for Notebook */
{ .match_flags = USB_DEVICE_ID_MATCH_DEVICE
| USB_DEVICE_ID_MATCH_INT_INFO,
--
1.6.2


2009-03-15 10:53:20

by Laurent Pinchart

[permalink] [raw]
Subject: Re: [PATCH UVC] Add UVC entry for Logitech Quickcam Orbit AF.

Hi Robin,

On Sunday 15 March 2009 02:26:45 Robin H. Johnson wrote:
> Need explicit entry like many of the other Logitech devices as it does
> not match the class otherwise.

Are you sure about that ? The Logitech Quickcam Orbit AF I got here matches
the standard UVC class. Could you please post the output of

lsusb -v -d 046d:0994

on your system with the camera plugged in ?

Best regards,

Laurent Pinchart

2009-03-15 20:01:40

by Robin H. Johnson

[permalink] [raw]
Subject: Re: [PATCH UVC] Add UVC entry for Logitech Quickcam Orbit AF.

On Sun, Mar 15, 2009 at 11:53:36AM +0100, Laurent Pinchart wrote:
> Hi Robin,
>
> On Sunday 15 March 2009 02:26:45 Robin H. Johnson wrote:
> > Need explicit entry like many of the other Logitech devices as it does
> > not match the class otherwise.
>
> Are you sure about that ? The Logitech Quickcam Orbit AF I got here matches
> the standard UVC class. Could you please post the output of
> lsusb -v -d 046d:0994
> on your system with the camera plugged in ?
See attached camera-046d-0994

I meant to send in the patch sooner, but I've been carrying it in my
local tree since 2.6.28 in December.

If the automatic detection and PTZ control work fine now, then I
apologize for the spurious patch, but booting back to my older kernels
finds it not working in stock 2.6.28.

--
Robin Hugh Johnson
E-Mail : [email protected]
Home Page : http://www.orbis-terrarum.net/?l=people.robbat2
ICQ# : 30269588 or 41961639
GnuPG FP : 11AC BA4F 4778 E3F6 E4ED F38E B27B 944E 3488 4E85


Attachments:
(No filename) (0.00 B)
(No filename) (330.00 B)
Download all attachments

2009-03-15 23:02:35

by Laurent Pinchart

[permalink] [raw]
Subject: Re: [PATCH UVC] Add UVC entry for Logitech Quickcam Orbit AF.

Hi Robin,

On Sunday 15 March 2009 16:28:45 Robin H. Johnson wrote:
> On Sun, Mar 15, 2009 at 11:53:36AM +0100, Laurent Pinchart wrote:
> > Hi Robin,
> >
> > On Sunday 15 March 2009 02:26:45 Robin H. Johnson wrote:
> > > Need explicit entry like many of the other Logitech devices as it does
> > > not match the class otherwise.
> >
> > Are you sure about that ? The Logitech Quickcam Orbit AF I got here
> > matches the standard UVC class. Could you please post the output of
> > lsusb -v -d 046d:0994
> > on your system with the camera plugged in ?
>
> See attached camera-046d-0994

Thanks. Your camera descriptors are definitely UVC compliant, the patch is
thus unneeded.

> I meant to send in the patch sooner, but I've been carrying it in my
> local tree since 2.6.28 in December.
>
> If the automatic detection and PTZ control work fine now, then I
> apologize for the spurious patch, but booting back to my older kernels
> finds it not working in stock 2.6.28.

Pan and tilt controls on Logitech devices require an external tool called
uvcdynctrl to configure the driver.

Best regards,

Laurent Pinchart