2009-03-17 08:26:19

by Alexander Beregalov

Subject: [PATCH next] slob: fix build problem

mm/slob.c: In function '__kmalloc_node':
mm/slob.c:480: error: 'flags' undeclared (first use in this function)

Signed-off-by: Alexander Beregalov <[email protected]>
---

mm/slob.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/mm/slob.c b/mm/slob.c
index 081cf1e..e49b258 100644
--- a/mm/slob.c
+++ b/mm/slob.c
@@ -477,7 +477,7 @@ void *__kmalloc_node(size_t size, gfp_t gfp, int node)
int align = max(ARCH_KMALLOC_MINALIGN, ARCH_SLAB_MINALIGN);
void *ret;

- lockdep_trace_alloc(flags);
+ lockdep_trace_alloc(gfp);

if (size < PAGE_SIZE - align) {
if (!size)

2009-03-17 08:28:20

by Alexander Beregalov

Subject: Re: [PATCH next] slob: fix build problem

2009/3/17 Alexander Beregalov <[email protected]>:
> mm/slob.c: In function '__kmalloc_node':
> mm/slob.c:480: error: 'flags' undeclared (first use in this function)

Oh, I see yesterday discussion, sorry.

2009-03-17 09:04:51

by Ingo Molnar

Subject: Re: [PATCH next] slob: fix build problem

* Alexander Beregalov <[email protected]> wrote:

> mm/slob.c: In function '__kmalloc_node':
> mm/slob.c:480: error: 'flags' undeclared (first use in this function)
>
> Signed-off-by: Alexander Beregalov <[email protected]>

thanks, fixed it two days ago:

bf722c9: lockdep: annotate reclaim context (__GFP_NOFS), fix SLOB

also posted on lkml.

Ingo