2009-03-24 12:11:45

by Adrian Hunter

Subject: MMC: Accept EXT_CSD rev 1.3 assuming it is backwards compatible with 1.2

>From a939998e34cbc263317d51b21ab52c8d5863a913 Mon Sep 17 00:00:00 2001
From: Jarkko Lavinen <[email protected]>
Date: Thu, 27 Nov 2008 14:30:32 +0200
Subject: MMC: Accept EXT_CSD rev 1.3 assuming it is backwards compatible with 1.2

Signed-off-by: Jarkko Lavinen <[email protected]>
---
drivers/mmc/core/mmc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
index fdd7c76..3f5b089 100644
--- a/drivers/mmc/core/mmc.c
+++ b/drivers/mmc/core/mmc.c
@@ -208,7 +208,7 @@ static int mmc_read_ext_csd(struct mmc_card *card)
}

ext_csd_struct = ext_csd[EXT_CSD_REV];
- if (ext_csd_struct > 2) {
+ if (ext_csd_struct > 3) {
printk(KERN_ERR "%s: unrecognised EXT_CSD structure "
"version %d\n", mmc_hostname(card->host),
ext_csd_struct);
--
1.5.4.3

2009-03-24 20:10:51

by Pierre Ossman

Subject: Re: MMC: Accept EXT_CSD rev 1.3 assuming it is backwards compatible with 1.2

On Tue, 24 Mar 2009 14:12:11 +0200
Adrian Hunter <[email protected]> wrote:

> From a939998e34cbc263317d51b21ab52c8d5863a913 Mon Sep 17 00:00:00 2001
> From: Jarkko Lavinen <[email protected]>
> Date: Thu, 27 Nov 2008 14:30:32 +0200
> Subject: MMC: Accept EXT_CSD rev 1.3 assuming it is backwards compatible with 1.2
>
> Signed-off-by: Jarkko Lavinen <[email protected]>
> ---

I don't like the whole "assuming" part. Do the specs back this up?

Rgds
--
-- Pierre Ossman

Linux kernel, MMC maintainer http://www.kernel.org
rdesktop, core developer http://www.rdesktop.org

WARNING: This correspondence is being monitored by the
Swedish government. Make sure your server uses encryption
for SMTP traffic and consider using PGP for end-to-end
encryption.

2009-03-25 08:06:01

by Adrian Hunter

Subject: Re: MMC: Accept EXT_CSD rev 1.3 assuming it is backwards compatible with 1.2

Pierre Ossman wrote:
> On Tue, 24 Mar 2009 14:12:11 +0200
> Adrian Hunter <[email protected]> wrote:
>
>> From a939998e34cbc263317d51b21ab52c8d5863a913 Mon Sep 17 00:00:00 2001
>> From: Jarkko Lavinen <[email protected]>
>> Date: Thu, 27 Nov 2008 14:30:32 +0200
>> Subject: MMC: Accept EXT_CSD rev 1.3 assuming it is backwards compatible with 1.2
>>
>> Signed-off-by: Jarkko Lavinen <[email protected]>
>> ---
>
> I don't like the whole "assuming" part. Do the specs back this up?
>
> Rgds

Yes.

Please swap "assuming" for "because".

2009-03-25 19:36:18

by Pierre Ossman

Subject: Re: MMC: Accept EXT_CSD rev 1.3 assuming it is backwards compatible with 1.2

On Wed, 25 Mar 2009 10:05:37 +0200
Adrian Hunter <[email protected]> wrote:

> Pierre Ossman wrote:
> >
> > I don't like the whole "assuming" part. Do the specs back this up?
> >
> > Rgds
>
> Yes.
>
> Please swap "assuming" for "because".

Ok then. Queued.

Thanks
--
-- Pierre Ossman

Linux kernel, MMC maintainer http://www.kernel.org
rdesktop, core developer http://www.rdesktop.org

WARNING: This correspondence is being monitored by the
Swedish government. Make sure your server uses encryption
for SMTP traffic and consider using PGP for end-to-end
encryption.