2009-03-26 21:40:36

by Alan

Subject: [PATCH] firedtv: wrong types in printk

size_t is not int...

Signed-off-by: Alan Cox <[email protected]>
---

drivers/media/dvb/firewire/firedtv-avc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/drivers/media/dvb/firewire/firedtv-avc.c b/drivers/media/dvb/firewire/firedtv-avc.c
index b55d9cc..424ed5d 100644
--- a/drivers/media/dvb/firewire/firedtv-avc.c
+++ b/drivers/media/dvb/firewire/firedtv-avc.c
@@ -150,7 +150,7 @@ static void debug_fcp(const u8 *data, size_t length)
subunit_type = data[1] >> 3;
subunit_id = data[1] & 7;
op = subunit_type == 0x1e || subunit_id == 5 ? ~0 : data[2];
- printk(KERN_INFO "%ssu=%x.%x l=%d: %-8s - %s\n",
+ printk(KERN_INFO "%ssu=%x.%x l=%Zd: %-8s - %s\n",
prefix, subunit_type, subunit_id, length,
debug_fcp_ctype(data[0]),
debug_fcp_opcode(op, data, length));

2009-03-27 18:10:49

by Stefan Richter

Subject: Re: [PATCH] firedtv: wrong types in printk

Alan Cox wrote:
> --- a/drivers/media/dvb/firewire/firedtv-avc.c
> +++ b/drivers/media/dvb/firewire/firedtv-avc.c
> @@ -150,7 +150,7 @@ static void debug_fcp(const u8 *data, size_t length)
> subunit_type = data[1] >> 3;
> subunit_id = data[1] & 7;
> op = subunit_type == 0x1e || subunit_id == 5 ? ~0 : data[2];
> - printk(KERN_INFO "%ssu=%x.%x l=%d: %-8s - %s\n",
> + printk(KERN_INFO "%ssu=%x.%x l=%Zd: %-8s - %s\n",
> prefix, subunit_type, subunit_id, length,
> debug_fcp_ctype(data[0]),
> debug_fcp_opcode(op, data, length));

This is already fixed in -next via linux1394-2.6.git. (1394 git pull
request follows later today.)
--
Stefan Richter
-=====-==--= --== ==-==
http://arcgraph.de/sr/