2009-03-26 20:03:55

by Pekka Paalanen

[permalink] [raw]
Subject: Re: [tip:x86/urgent] x86: mmiotrace: quieten spurious warning message

On Wed, 11 Mar 2009 20:45:45 GMT
Stuart Bennett <[email protected]> wrote:

> Commit-ID: afcfe024aebd74b0984a41af9a34e009cf5badaf
> Gitweb: http://git.kernel.org/tip/afcfe024aebd74b0984a41af9a34e009cf5badaf
> Author: "Stuart Bennett" <[email protected]>
> AuthorDate: Wed, 11 Mar 2009 20:29:45 +0000
> Commit: Ingo Molnar <[email protected]>
> CommitDate: Wed, 11 Mar 2009 21:41:58 +0100
>
> x86: mmiotrace: quieten spurious warning message
>
> This message was being incorrectly emitted when using gdb,
> so compile it out by default for now; there will be a
> better fix in v2.6.30.
>
> Reported-by: Ingo Molnar <[email protected]>
> Signed-off-by: Stuart Bennett <[email protected]>
> Acked-by: Pekka Paalanen <[email protected]>
> Signed-off-by: Ingo Molnar <[email protected]>
>

Guys,

wasn't this supposed to go into 2.6.29?
I don't see this in Linus' master, was it too late?

>
> ---
> arch/x86/mm/kmmio.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/mm/kmmio.c b/arch/x86/mm/kmmio.c
> index 6a518dd..4f115e0 100644
> --- a/arch/x86/mm/kmmio.c
> +++ b/arch/x86/mm/kmmio.c
> @@ -310,7 +310,7 @@ static int post_kmmio_handler(unsigned long condition, struct pt_regs *regs)
> struct kmmio_context *ctx = &get_cpu_var(kmmio_ctx);
>
> if (!ctx->active) {
> - pr_warning("kmmio: spurious debug trap on CPU %d.\n",
> + pr_debug("kmmio: spurious debug trap on CPU %d.\n",
> smp_processor_id());
> goto out;
> }
>


--
Pekka Paalanen
http://www.iki.fi/pq/


2009-04-01 10:21:32

by Ingo Molnar

[permalink] [raw]
Subject: Re: [tip:x86/urgent] x86: mmiotrace: quieten spurious warning message


* Pekka Paalanen <[email protected]> wrote:

> On Wed, 11 Mar 2009 20:45:45 GMT
> Stuart Bennett <[email protected]> wrote:
>
> > Commit-ID: afcfe024aebd74b0984a41af9a34e009cf5badaf
> > Gitweb: http://git.kernel.org/tip/afcfe024aebd74b0984a41af9a34e009cf5badaf
> > Author: "Stuart Bennett" <[email protected]>
> > AuthorDate: Wed, 11 Mar 2009 20:29:45 +0000
> > Commit: Ingo Molnar <[email protected]>
> > CommitDate: Wed, 11 Mar 2009 21:41:58 +0100
> >
> > x86: mmiotrace: quieten spurious warning message
> >
> > This message was being incorrectly emitted when using gdb,
> > so compile it out by default for now; there will be a
> > better fix in v2.6.30.
> >
> > Reported-by: Ingo Molnar <[email protected]>
> > Signed-off-by: Stuart Bennett <[email protected]>
> > Acked-by: Pekka Paalanen <[email protected]>
> > Signed-off-by: Ingo Molnar <[email protected]>
> >
>
> Guys,
>
> wasn't this supposed to go into 2.6.29?
> I don't see this in Linus' master, was it too late?

Correct. There was no showstopper bug in the x86 tree
that necessiated a final post-rc8 push to Linus so this
did not get in.

We'll forward it to -stable once the tracing tree hits
upstream (this week). It could thus be part of .29.1.

Ingo