2009-03-31 07:24:32

by Krzysztof Helt

[permalink] [raw]
Subject: Re: [Linux-fbdev-devel] [PATCH] cirrusfb: fix color component length for pseudocolor modes

Michal Januszewski napisa?(a):
> cirrusfb incorrectly sets the length of the color fields to 6 bits
> for PSEUDOCOLOR modes, even though 8 bits are always used per pixel.
> Fix this by setting the length to 8.
>
> Signed-off-by: Michal Januszewski >[email protected]>
> ---
> diff --git a/drivers/video/cirrusfb.c b/drivers/video/cirrusfb.c
> index a2aa6dd..2dfe0e7 100644
> --- a/drivers/video/cirrusfb.c
> +++ b/drivers/video/cirrusfb.c
> @@ -550,7 +550,7 @@ static int cirrusfb_check_var(struct fb_var_screeninfo
> *var,
>
> case 8:
> var->red.offset = 0;
> - var->red.length = 6;
> + var->red.length = 8;
> var->green = var->red;
> var->blue = var->red;
> break;
>

This is already fixed in the -mm tree (cirrusfb-check_var-improvements.patch).

Regards,
Krzysztof

----------------------------------------------------------------------
Widziales zajaca? Zgubil nagrody!
Sprawdz >>> http://link.interia.pl/f20e9