2009-03-31 22:34:26

by Alexander Beregalov

[permalink] [raw]
Subject: [PATCH] sony-laptop should depend on RFKILL

Fixes this build error when RFKILL is not set:

drivers/platform/x86/sony-laptop.c:1050: undefined reference to `rfkill_unregister'
and so on..

Signed-off-by: Alexander Beregalov <[email protected]>
---

drivers/platform/x86/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 3608081..36b1628 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -165,6 +165,7 @@ config SONY_LAPTOP
depends on ACPI
select BACKLIGHT_CLASS_DEVICE
depends on INPUT
+ depends on RFKILL
---help---
This mini-driver drives the SNC and SPIC devices present in the ACPI
BIOS of the Sony Vaio laptops.


2009-03-31 22:36:19

by Matthew Garrett

[permalink] [raw]
Subject: Re: [PATCH] sony-laptop should depend on RFKILL

On Wed, Apr 01, 2009 at 02:34:07AM +0400, Alexander Beregalov wrote:
> Fixes this build error when RFKILL is not set:
>
> drivers/platform/x86/sony-laptop.c:1050: undefined reference to `rfkill_unregister'
> and so on..
>
> Signed-off-by: Alexander Beregalov <[email protected]>

Acked-by: Matthew Garrett <[email protected]>

--
Matthew Garrett | [email protected]

2009-04-01 12:59:50

by Mattia Dongili

[permalink] [raw]
Subject: Re: [PATCH] sony-laptop should depend on RFKILL

On Tue, Mar 31, 2009 at 11:35:55PM +0100, Matthew Garrett wrote:
> On Wed, Apr 01, 2009 at 02:34:07AM +0400, Alexander Beregalov wrote:
> > Fixes this build error when RFKILL is not set:
> >
> > drivers/platform/x86/sony-laptop.c:1050: undefined reference to `rfkill_unregister'
> > and so on..
> >
> > Signed-off-by: Alexander Beregalov <[email protected]>
>
> Acked-by: Matthew Garrett <[email protected]>

Thanks, applied and forwarding it to Len now with other fixes for
2.6.30.
--
mattia
:wq!