2009-03-31 23:25:49

by Chris Wright

[permalink] [raw]
Subject: [patch 30/45] ARM: cumana: Fix a long standing bogon

-stable review patch. If anyone has any objections, please let us know.
---------------------

From: Alan Cox <[email protected]>

upstream commit: ecbf61e7357d5c7047c813edd6983902d158688c

Should be using strncmp as the data from user space may be unterminated

(Bug #8004)

Signed-off-by: Alan Cox <[email protected]>
Signed-off-by: Russell King <[email protected]>
Signed-off-by: Chris Wright <[email protected]>
---
drivers/scsi/arm/cumana_2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/scsi/arm/cumana_2.c
+++ b/drivers/scsi/arm/cumana_2.c
@@ -318,7 +318,7 @@ cumanascsi_2_set_proc_info(struct Scsi_H
{
int ret = length;

- if (length >= 11 && strcmp(buffer, "CUMANASCSI2") == 0) {
+ if (length >= 11 && strncmp(buffer, "CUMANASCSI2", 11) == 0) {
buffer += 11;
length -= 11;