2009-04-01 10:50:31

by Anton Blanchard

[permalink] [raw]
Subject: [PATCH] Align cache_clean work


Align cache_clean work.

Signed-off-by: Anton Blanchard <[email protected]>
---

Index: linux-2.6/net/sunrpc/cache.c
===================================================================
--- linux-2.6.orig/net/sunrpc/cache.c 2009-04-01 15:47:38.000000000 +1100
+++ linux-2.6/net/sunrpc/cache.c 2009-04-01 16:32:44.000000000 +1100
@@ -488,7 +488,7 @@
{
int delay = 5;
if (cache_clean() == -1)
- delay = 30*HZ;
+ delay = round_jiffies_relative(30*HZ);

if (list_empty(&cache_list))
delay = 0;


2009-04-01 19:47:58

by Andrew Morton

[permalink] [raw]
Subject: Re: [PATCH] Align cache_clean work

> Subject: [PATCH] Align cache_clean work

better titles, please. Of the form

subsystem-identifier: what-i-did-to-it

On Wed, 1 Apr 2009 21:45:18 +1100
Anton Blanchard <[email protected]> wrote:

>
> Align cache_clean work.
>
> Signed-off-by: Anton Blanchard <[email protected]>
> ---
>
> Index: linux-2.6/net/sunrpc/cache.c
> ===================================================================
> --- linux-2.6.orig/net/sunrpc/cache.c 2009-04-01 15:47:38.000000000 +1100
> +++ linux-2.6/net/sunrpc/cache.c 2009-04-01 16:32:44.000000000 +1100
> @@ -488,7 +488,7 @@
> {
> int delay = 5;
> if (cache_clean() == -1)
> - delay = 30*HZ;
> + delay = round_jiffies_relative(30*HZ);
>
> if (list_empty(&cache_list))
> delay = 0;

the people who will merge this patch (nfs/net) will be wondering why
they were asked to do so.

iow: better changelogs please ;)