2009-04-01 10:50:48

by Anton Blanchard

[permalink] [raw]
Subject: [PATCH] Align vmstat_work


Even though vmstat_work is marked deferrable, there are still benefits to
aligning it. For certain applications we want to keep OS jitter as low as
possible and aligning timers and work so they occur together can reduce their
overall impact.

Signed-off-by: Anton Blanchard <[email protected]>
---

diff --git a/mm/vmstat.c b/mm/vmstat.c
index 9114974..493c89d 100644
--- a/mm/vmstat.c
+++ b/mm/vmstat.c
@@ -898,7 +898,7 @@ static void vmstat_update(struct work_struct *w)
{
refresh_cpu_vm_stats(smp_processor_id());
schedule_delayed_work(&__get_cpu_var(vmstat_work),
- sysctl_stat_interval);
+ round_jiffies_relative(sysctl_stat_interval));
}

static void __cpuinit start_cpu_timer(int cpu)
@@ -906,7 +906,8 @@ static void __cpuinit start_cpu_timer(int cpu)
struct delayed_work *vmstat_work = &per_cpu(vmstat_work, cpu);

INIT_DELAYED_WORK_DEFERRABLE(vmstat_work, vmstat_update);
- schedule_delayed_work_on(cpu, vmstat_work, HZ + cpu);
+ schedule_delayed_work_on(cpu, vmstat_work,
+ __round_jiffies_relative(HZ, cpu));
}

/*