2009-03-31 07:56:14

by Hidetoshi Seto

Subject: [RESEND][PATCH -tip] x86: smarten /proc/interrupts output for new counters

Now /proc/interrupts of tip tree has new counters:
CNT: Performance counter interrupts
PLT: Platform interrupts

Format change of output as like that by commit:
commit 7a81d9a7da03d2f27840d659f97ef140d032f609
x86: smarten /proc/interrupts output
should be applied to these new counters too.

Signed-off-by: Hidetoshi Seto <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Jan Beulich <[email protected]>
---
arch/x86/kernel/irq.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c
index 9c27543..35b3725 100644
--- a/arch/x86/kernel/irq.c
+++ b/arch/x86/kernel/irq.c
@@ -63,13 +63,13 @@ static int show_other_interrupts(struct seq_file *p, int prec)
for_each_online_cpu(j)
seq_printf(p, "%10u ", irq_stats(j)->irq_spurious_count);
seq_printf(p, " Spurious interrupts\n");
- seq_printf(p, "CNT: ");
+ seq_printf(p, "%*s: ", prec, "CNT");
for_each_online_cpu(j)
seq_printf(p, "%10u ", irq_stats(j)->apic_perf_irqs);
seq_printf(p, " Performance counter interrupts\n");
#endif
if (generic_interrupt_extension) {
- seq_printf(p, "PLT: ");
+ seq_printf(p, "%*s: ", prec, "PLT");
for_each_online_cpu(j)
seq_printf(p, "%10u ", irq_stats(j)->generic_irqs);
seq_printf(p, " Platform interrupts\n");
--
1.6.2.1

2009-03-31 08:07:38

by Jan Beulich

Subject: Re: [RESEND][PATCH -tip] x86: smarten /proc/interrupts output for newcounters

Acked-by: Jan Beulich <[email protected]>

>>> Hidetoshi Seto <[email protected]> 31.03.09 09:55 >>>
Now /proc/interrupts of tip tree has new counters:
CNT: Performance counter interrupts
PLT: Platform interrupts

Format change of output as like that by commit:
commit 7a81d9a7da03d2f27840d659f97ef140d032f609
x86: smarten /proc/interrupts output
should be applied to these new counters too.

Signed-off-by: Hidetoshi Seto <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Jan Beulich <[email protected]>
---
arch/x86/kernel/irq.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c
index 9c27543..35b3725 100644
--- a/arch/x86/kernel/irq.c
+++ b/arch/x86/kernel/irq.c
@@ -63,13 +63,13 @@ static int show_other_interrupts(struct seq_file *p, int prec)
for_each_online_cpu(j)
seq_printf(p, "%10u ", irq_stats(j)->irq_spurious_count);
seq_printf(p, " Spurious interrupts\n");
- seq_printf(p, "CNT: ");
+ seq_printf(p, "%*s: ", prec, "CNT");
for_each_online_cpu(j)
seq_printf(p, "%10u ", irq_stats(j)->apic_perf_irqs);
seq_printf(p, " Performance counter interrupts\n");
#endif
if (generic_interrupt_extension) {
- seq_printf(p, "PLT: ");
+ seq_printf(p, "%*s: ", prec, "PLT");
for_each_online_cpu(j)
seq_printf(p, "%10u ", irq_stats(j)->generic_irqs);
seq_printf(p, " Platform interrupts\n");
--
1.6.2.1

2009-04-01 14:43:19

by Ingo Molnar

Subject: Re: [RESEND][PATCH -tip] x86: smarten /proc/interrupts output for newcounters

* Jan Beulich <[email protected]> wrote:

> Acked-by: Jan Beulich <[email protected]>

Thanks, we can apply this one once -tip merges latest -git.
(which is any day now)

Ingo