2009-04-03 11:16:46

by Alexander Beregalov

Subject: [PATCH] input: hp_sdc_rtc should depend on serio

Fix this build error when CONFIG_SERIO is not set
hp_sdc_rtc.c:691: undefined reference to `hp_sdc_request_timer_irq'
and so on..

"select should be used with care. select will force
a symbol to a value without visiting the dependencies."

Signed-off-by: Alexander Beregalov <[email protected]>
---

drivers/input/misc/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
index 203abac..ae5d7dc 100644
--- a/drivers/input/misc/Kconfig
+++ b/drivers/input/misc/Kconfig
@@ -215,6 +215,7 @@ config INPUT_SGI_BTNS
config HP_SDC_RTC
tristate "HP SDC Real Time Clock"
depends on GSC || HP300
+ select SERIO
select HP_SDC
help
Say Y here if you want to support the built-in real time clock

2009-04-09 16:44:52

by Dmitry Torokhov

Subject: Re: [PATCH] input: hp_sdc_rtc should depend on serio

Hi Alexander,

On Fri, Apr 03, 2009 at 03:16:21PM +0400, Alexander Beregalov wrote:
> Fix this build error when CONFIG_SERIO is not set
> hp_sdc_rtc.c:691: undefined reference to `hp_sdc_request_timer_irq'
> and so on..
>
> "select should be used with care. select will force
> a symbol to a value without visiting the dependencies."
>
> Signed-off-by: Alexander Beregalov <[email protected]>
> ---
>
> drivers/input/misc/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
> index 203abac..ae5d7dc 100644
> --- a/drivers/input/misc/Kconfig
> +++ b/drivers/input/misc/Kconfig
> @@ -215,6 +215,7 @@ config INPUT_SGI_BTNS
> config HP_SDC_RTC
> tristate "HP SDC Real Time Clock"
> depends on GSC || HP300
> + select SERIO

Why don'we make it "depend on SERIO"?

--
Dmitry