2009-04-09 02:26:26

by Jeff Kirsher

Subject: Re: [E1000-devel] [PATCH] Be explict with what we are !'ing in ixgbe_sfp_config_module_task()

On Tue, Apr 7, 2009 at 9:44 PM, Tony Breeds <[email protected]> wrote:
> GCC warns:
> drivers/net/ixgbe/ixgbe_main.c: In function 'ixgbe_sfp_config_module_task':
> drivers/net/ixgbe/ixgbe_main.c:3920: warning: suggest parentheses around operand of '!' or change '&' to '&&' or '!' to '~'
>
> Which I think is right.  Bracket to remove ambiguity.
>
> Signed-off-by: Tony Breeds <[email protected]>
> ---

Thanks, I will add it to my queue of ixgbe patches.
Remember to CC netdev mailing list for networking patches.

--
Cheers,
Jeff

2009-04-09 03:50:13

by Tony Breeds

Subject: Re: [E1000-devel] [PATCH] Be explict with what we are !'ing in ixgbe_sfp_config_module_task()

On Wed, Apr 08, 2009 at 07:26:08PM -0700, Jeff Kirsher wrote:

> Thanks, I will add it to my queue of ixgbe patches.

Thanks.

> Remember to CC netdev mailing list for networking patches.

I did but due to a misconfiguration on my latop all the lisst on
vger.kernel.org rejected the messsages and I didn't get a bounce :(

I think I've fix it now though.

Yours Tony