2009-04-09 03:40:00

by Li Zefan

[permalink] [raw]
Subject: [PATCH] tracing: consolidate documents

Move tracepoints.txt, ftrace.txt and ftrace.txt to the new
directory trace/.

I don't find any references to those documents in both source
files and documents, so no extra work needs to be done.

Signed-off-by: Li Zefan <[email protected]>
---
Documentation/{ => trace}/ftrace.txt | 0
Documentation/{tracers => trace}/mmiotrace.txt | 0
Documentation/{ => trace}/tracepoints.txt | 0
3 files changed, 0 insertions(+), 0 deletions(-)
rename Documentation/{ => trace}/ftrace.txt (100%)
rename Documentation/{tracers => trace}/mmiotrace.txt (100%)
rename Documentation/{ => trace}/tracepoints.txt (100%)

diff --git a/Documentation/ftrace.txt b/Documentation/trace/ftrace.txt
similarity index 100%
rename from Documentation/ftrace.txt
rename to Documentation/trace/ftrace.txt
diff --git a/Documentation/tracers/mmiotrace.txt b/Documentation/trace/mmiotrace.txt
similarity index 100%
rename from Documentation/tracers/mmiotrace.txt
rename to Documentation/trace/mmiotrace.txt
diff --git a/Documentation/tracepoints.txt b/Documentation/trace/tracepoints.txt
similarity index 100%
rename from Documentation/tracepoints.txt
rename to Documentation/trace/tracepoints.txt
--
1.5.4.rc3


2009-04-09 03:51:38

by Li Zefan

[permalink] [raw]
Subject: [PATCH][RESEND] tracing: consolidate documents

Move tracepoints.txt, ftrace.txt and mmiotrace.txt to the new
directory trace/

I don't find any references to those documents in both source
files and documents, so no extra work needs to be done.

Signed-off-by: Li Zefan <[email protected]>
---

Fix a typo in changelog, and CC more people.

---
Documentation/{ => trace}/ftrace.txt | 0
Documentation/{tracers => trace}/mmiotrace.txt | 0
Documentation/{ => trace}/tracepoints.txt | 0
3 files changed, 0 insertions(+), 0 deletions(-)
rename Documentation/{ => trace}/ftrace.txt (100%)
rename Documentation/{tracers => trace}/mmiotrace.txt (100%)
rename Documentation/{ => trace}/tracepoints.txt (100%)

diff --git a/Documentation/ftrace.txt b/Documentation/trace/ftrace.txt
similarity index 100%
rename from Documentation/ftrace.txt
rename to Documentation/trace/ftrace.txt
diff --git a/Documentation/tracers/mmiotrace.txt b/Documentation/trace/mmiotrace.txt
similarity index 100%
rename from Documentation/tracers/mmiotrace.txt
rename to Documentation/trace/mmiotrace.txt
diff --git a/Documentation/tracepoints.txt b/Documentation/trace/tracepoints.txt
similarity index 100%
rename from Documentation/tracepoints.txt
rename to Documentation/trace/tracepoints.txt
--
1.5.4.rc3

2009-04-09 03:58:37

by Li Zefan

[permalink] [raw]
Subject: Re: [PATCH][RESEND] tracing: consolidate documents

Li Zefan wrote:
> Move tracepoints.txt, ftrace.txt and mmiotrace.txt to the new
> directory trace/
>

Should we also move kmemtrace.txt to trace/, or leave it in vm/?

> I don't find any references to those documents in both source
> files and documents, so no extra work needs to be done.
>

2009-04-09 04:13:49

by Ingo Molnar

[permalink] [raw]
Subject: Re: [PATCH][RESEND] tracing: consolidate documents


* Li Zefan <[email protected]> wrote:

> Li Zefan wrote:
> > Move tracepoints.txt, ftrace.txt and mmiotrace.txt to the new
> > directory trace/
> >
>
> Should we also move kmemtrace.txt to trace/, or leave it in vm/?

Eduard, Pekka, any preferences?

Are symbolic links in Documentation/ frowned upon? I think it would
be best to have the file in both places:

We do want to direct people interested in Documentation/vm/ to
kmemtrace ... and we do want to let people who are interested in
Documentation/trace/ that there's kmemtrace.

Tracing and instrumentation is generally a multi-subsystem thing.

Ingo

2009-04-09 04:38:05

by Li Zefan

[permalink] [raw]
Subject: [tip:tracing/urgent] tracing: consolidate documents

Commit-ID: 9f690b04fdf3fa5d7d6abab0bfd8628c3b91d503
Gitweb: http://git.kernel.org/tip/9f690b04fdf3fa5d7d6abab0bfd8628c3b91d503
Author: Li Zefan <[email protected]>
AuthorDate: Thu, 9 Apr 2009 11:40:27 +0800
Committer: Ingo Molnar <[email protected]>
CommitDate: Thu, 9 Apr 2009 05:54:42 +0200

tracing: consolidate documents

Move tracepoints.txt, ftrace.txt and mmiotrace.txt to the new
directory trace/.

I didnt find any references to those documents in both source
files and documents, so no extra work needs to be done.

Signed-off-by: Li Zefan <[email protected]>
Cc: Steven Rostedt <[email protected]>
Cc: Frederic Weisbecker <[email protected]>
Cc: Pekka Paalanen <[email protected]>
Cc: Mathieu Desnoyers <[email protected]>
LKML-Reference: <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>


---
Documentation/{ => trace}/ftrace.txt | 0
Documentation/{tracers => trace}/mmiotrace.txt | 0
Documentation/{ => trace}/tracepoints.txt | 0
3 files changed, 0 insertions(+), 0 deletions(-)

diff --git a/Documentation/ftrace.txt b/Documentation/trace/ftrace.txt
similarity index 100%
rename from Documentation/ftrace.txt
rename to Documentation/trace/ftrace.txt
diff --git a/Documentation/tracers/mmiotrace.txt b/Documentation/trace/mmiotrace.txt
similarity index 100%
rename from Documentation/tracers/mmiotrace.txt
rename to Documentation/trace/mmiotrace.txt
diff --git a/Documentation/tracepoints.txt b/Documentation/trace/tracepoints.txt
similarity index 100%
rename from Documentation/tracepoints.txt
rename to Documentation/trace/tracepoints.txt

2009-04-09 05:17:00

by Pekka Enberg

[permalink] [raw]
Subject: Re: [PATCH][RESEND] tracing: consolidate documents

On Thu, Apr 9, 2009 at 7:13 AM, Ingo Molnar <[email protected]> wrote:
>
> * Li Zefan <[email protected]> wrote:
>
>> Li Zefan wrote:
>> > Move tracepoints.txt, ftrace.txt and mmiotrace.txt to the new
>> > directory trace/
>> >
>>
>> Should we also move kmemtrace.txt to trace/, or leave it in vm/?
>
> Eduard, Pekka, any preferences?
>
> Are symbolic links in Documentation/ frowned upon? I think it would
> be best to have the file in both places:
>
> We do want to direct people interested in Documentation/vm/ to
> kmemtrace ... and we do want to let people who are interested in
> Documentation/trace/ that there's kmemtrace.
>
> Tracing and instrumentation is generally a multi-subsystem thing.

I'm not sure a symbolic link is necessary. Just put it under trace/.

2009-04-09 05:29:45

by Ingo Molnar

[permalink] [raw]
Subject: Re: [PATCH][RESEND] tracing: consolidate documents


* Pekka Enberg <[email protected]> wrote:

> On Thu, Apr 9, 2009 at 7:13 AM, Ingo Molnar <[email protected]> wrote:
> >
> > * Li Zefan <[email protected]> wrote:
> >
> >> Li Zefan wrote:
> >> > Move tracepoints.txt, ftrace.txt and mmiotrace.txt to the new
> >> > directory trace/
> >> >
> >>
> >> Should we also move kmemtrace.txt to trace/, or leave it in vm/?
> >
> > Eduard, Pekka, any preferences?
> >
> > Are symbolic links in Documentation/ frowned upon? I think it would
> > be best to have the file in both places:
> >
> > We do want to direct people interested in Documentation/vm/ to
> > kmemtrace ... and we do want to let people who are interested in
> > Documentation/trace/ that there's kmemtrace.
> >
> > Tracing and instrumentation is generally a multi-subsystem thing.
>
> I'm not sure a symbolic link is necessary. Just put it under trace/.

ok - i've amended the commit and have added your Ack - thanks!

Ingo

2009-04-09 05:31:44

by Li Zefan

[permalink] [raw]
Subject: [tip:tracing/urgent] tracing: consolidate documents

Commit-ID: 66bb74888eb4bef4ba7c87c931ecb7ecca3a240c
Gitweb: http://git.kernel.org/tip/66bb74888eb4bef4ba7c87c931ecb7ecca3a240c
Author: Li Zefan <[email protected]>
AuthorDate: Thu, 9 Apr 2009 11:40:27 +0800
Committer: Ingo Molnar <[email protected]>
CommitDate: Thu, 9 Apr 2009 07:28:10 +0200

tracing: consolidate documents

Move kmemtrace.txt, tracepoints.txt, ftrace.txt and mmiotrace.txt to
the new trace/ directory.

I didnt find any references to those documents in both source
files and documents, so no extra work needs to be done.

Signed-off-by: Li Zefan <[email protected]>
Acked-by: Pekka Paalanen <[email protected]>
Cc: Steven Rostedt <[email protected]>
Cc: Frederic Weisbecker <[email protected]>
Cc: Mathieu Desnoyers <[email protected]>
LKML-Reference: <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>


---
Documentation/{ => trace}/ftrace.txt | 0
Documentation/{vm => trace}/kmemtrace.txt | 0
Documentation/{tracers => trace}/mmiotrace.txt | 0
Documentation/{ => trace}/tracepoints.txt | 0
4 files changed, 0 insertions(+), 0 deletions(-)

diff --git a/Documentation/ftrace.txt b/Documentation/trace/ftrace.txt
similarity index 100%
rename from Documentation/ftrace.txt
rename to Documentation/trace/ftrace.txt
diff --git a/Documentation/vm/kmemtrace.txt b/Documentation/trace/kmemtrace.txt
similarity index 100%
rename from Documentation/vm/kmemtrace.txt
rename to Documentation/trace/kmemtrace.txt
diff --git a/Documentation/tracers/mmiotrace.txt b/Documentation/trace/mmiotrace.txt
similarity index 100%
rename from Documentation/tracers/mmiotrace.txt
rename to Documentation/trace/mmiotrace.txt
diff --git a/Documentation/tracepoints.txt b/Documentation/trace/tracepoints.txt
similarity index 100%
rename from Documentation/tracepoints.txt
rename to Documentation/trace/tracepoints.txt

2009-04-09 07:31:51

by Mathieu Desnoyers

[permalink] [raw]
Subject: Re: [tip:tracing/urgent] tracing: consolidate documents

* Li Zefan ([email protected]) wrote:
> Commit-ID: 9f690b04fdf3fa5d7d6abab0bfd8628c3b91d503
> Gitweb: http://git.kernel.org/tip/9f690b04fdf3fa5d7d6abab0bfd8628c3b91d503
> Author: Li Zefan <[email protected]>
> AuthorDate: Thu, 9 Apr 2009 11:40:27 +0800
> Committer: Ingo Molnar <[email protected]>
> CommitDate: Thu, 9 Apr 2009 05:54:42 +0200
>
> tracing: consolidate documents
>
> Move tracepoints.txt, ftrace.txt and mmiotrace.txt to the new
> directory trace/.
>

We should probably move markers.txt while we are at it.

Mathieu

> I didnt find any references to those documents in both source
> files and documents, so no extra work needs to be done.
>
> Signed-off-by: Li Zefan <[email protected]>
> Cc: Steven Rostedt <[email protected]>
> Cc: Frederic Weisbecker <[email protected]>
> Cc: Pekka Paalanen <[email protected]>
> Cc: Mathieu Desnoyers <[email protected]>
> LKML-Reference: <[email protected]>
> Signed-off-by: Ingo Molnar <[email protected]>
>
>
> ---
> Documentation/{ => trace}/ftrace.txt | 0
> Documentation/{tracers => trace}/mmiotrace.txt | 0
> Documentation/{ => trace}/tracepoints.txt | 0
> 3 files changed, 0 insertions(+), 0 deletions(-)
>
> diff --git a/Documentation/ftrace.txt b/Documentation/trace/ftrace.txt
> similarity index 100%
> rename from Documentation/ftrace.txt
> rename to Documentation/trace/ftrace.txt
> diff --git a/Documentation/tracers/mmiotrace.txt b/Documentation/trace/mmiotrace.txt
> similarity index 100%
> rename from Documentation/tracers/mmiotrace.txt
> rename to Documentation/trace/mmiotrace.txt
> diff --git a/Documentation/tracepoints.txt b/Documentation/trace/tracepoints.txt
> similarity index 100%
> rename from Documentation/tracepoints.txt
> rename to Documentation/trace/tracepoints.txt

--
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68

2009-04-09 15:53:55

by Pekka Paalanen

[permalink] [raw]
Subject: Re: [tip:tracing/urgent] tracing: consolidate documents

On Thu, 9 Apr 2009 05:30:47 GMT
Li Zefan <[email protected]> wrote:

> Commit-ID: 66bb74888eb4bef4ba7c87c931ecb7ecca3a240c
> Gitweb: http://git.kernel.org/tip/66bb74888eb4bef4ba7c87c931ecb7ecca3a240c
> Author: Li Zefan <[email protected]>
> AuthorDate: Thu, 9 Apr 2009 11:40:27 +0800
> Committer: Ingo Molnar <[email protected]>
> CommitDate: Thu, 9 Apr 2009 07:28:10 +0200
>
> tracing: consolidate documents
>
> Move kmemtrace.txt, tracepoints.txt, ftrace.txt and mmiotrace.txt to
> the new trace/ directory.
>
> I didnt find any references to those documents in both source
> files and documents, so no extra work needs to be done.

There is one reference: kernel/trace/Kconfig, search for MMIOTRACE.
Fix that, and you have my ack on the mmiotrace.txt part.

> Signed-off-by: Li Zefan <[email protected]>
> Acked-by: Pekka Paalanen <[email protected]>

Hey, I didn't say anything yet. Maybe you meant Enberg?
There are at least two Pekkas here :-)

Thanks.


> Cc: Steven Rostedt <[email protected]>
> Cc: Frederic Weisbecker <[email protected]>
> Cc: Mathieu Desnoyers <[email protected]>
> LKML-Reference: <[email protected]>
> Signed-off-by: Ingo Molnar <[email protected]>
>
>
> ---
> Documentation/{ => trace}/ftrace.txt | 0
> Documentation/{vm => trace}/kmemtrace.txt | 0
> Documentation/{tracers => trace}/mmiotrace.txt | 0
> Documentation/{ => trace}/tracepoints.txt | 0
> 4 files changed, 0 insertions(+), 0 deletions(-)
>
> diff --git a/Documentation/ftrace.txt b/Documentation/trace/ftrace.txt
> similarity index 100%
> rename from Documentation/ftrace.txt
> rename to Documentation/trace/ftrace.txt
> diff --git a/Documentation/vm/kmemtrace.txt b/Documentation/trace/kmemtrace.txt
> similarity index 100%
> rename from Documentation/vm/kmemtrace.txt
> rename to Documentation/trace/kmemtrace.txt
> diff --git a/Documentation/tracers/mmiotrace.txt b/Documentation/trace/mmiotrace.txt
> similarity index 100%
> rename from Documentation/tracers/mmiotrace.txt
> rename to Documentation/trace/mmiotrace.txt
> diff --git a/Documentation/tracepoints.txt b/Documentation/trace/tracepoints.txt
> similarity index 100%
> rename from Documentation/tracepoints.txt
> rename to Documentation/trace/tracepoints.txt
>


--
Pekka Paalanen
http://www.iki.fi/pq/

2009-04-09 16:46:41

by Randy Dunlap

[permalink] [raw]
Subject: Re: [PATCH][RESEND] tracing: consolidate documents

Pekka Enberg wrote:
> On Thu, Apr 9, 2009 at 7:13 AM, Ingo Molnar <[email protected]> wrote:
>> * Li Zefan <[email protected]> wrote:
>>
>>> Li Zefan wrote:
>>>> Move tracepoints.txt, ftrace.txt and mmiotrace.txt to the new
>>>> directory trace/
>>>>
>>> Should we also move kmemtrace.txt to trace/, or leave it in vm/?
>> Eduard, Pekka, any preferences?
>>
>> Are symbolic links in Documentation/ frowned upon? I think it would
>> be best to have the file in both places:
>>
>> We do want to direct people interested in Documentation/vm/ to
>> kmemtrace ... and we do want to let people who are interested in
>> Documentation/trace/ that there's kmemtrace.
>>
>> Tracing and instrumentation is generally a multi-subsystem thing.
>
> I'm not sure a symbolic link is necessary. Just put it under trace/.

Thanks. I like that too.

--
~Randy

2009-04-09 16:58:40

by Pekka Enberg

[permalink] [raw]
Subject: Re: [tip:tracing/urgent] tracing: consolidate documents

On Thu, Apr 9, 2009 at 6:53 PM, Pekka Paalanen <[email protected]> wrote:
> On Thu, 9 Apr 2009 05:30:47 GMT
> Li Zefan <[email protected]> wrote:
>
>> Commit-ID: ?66bb74888eb4bef4ba7c87c931ecb7ecca3a240c
>> Gitweb: ? ? http://git.kernel.org/tip/66bb74888eb4bef4ba7c87c931ecb7ecca3a240c
>> Author: ? ? Li Zefan <[email protected]>
>> AuthorDate: Thu, 9 Apr 2009 11:40:27 +0800
>> Committer: ?Ingo Molnar <[email protected]>
>> CommitDate: Thu, 9 Apr 2009 07:28:10 +0200
>>
>> tracing: consolidate documents
>>
>> Move kmemtrace.txt, tracepoints.txt, ftrace.txt and mmiotrace.txt to
>> the new trace/ directory.
>>
>> I didnt find any references to those documents in both source
>> files and documents, so no extra work needs to be done.
>
> There is one reference: kernel/trace/Kconfig, search for MMIOTRACE.
> Fix that, and you have my ack on the mmiotrace.txt part.
>
>> Signed-off-by: Li Zefan <[email protected]>
>> Acked-by: Pekka Paalanen <[email protected]>
>
> Hey, I didn't say anything yet. Maybe you meant Enberg?
> There are at least two Pekkas here :-)

Haha! Yeah, I acked the kmemtrace part so Ingo is probably just confused. :-)

2009-04-10 00:36:15

by Li Zefan

[permalink] [raw]
Subject: Re: [tip:tracing/urgent] tracing: consolidate documents

>> tracing: consolidate documents
>>
>> Move kmemtrace.txt, tracepoints.txt, ftrace.txt and mmiotrace.txt to
>> the new trace/ directory.
>>
>> I didnt find any references to those documents in both source
>> files and documents, so no extra work needs to be done.
>
> There is one reference: kernel/trace/Kconfig, search for MMIOTRACE.
> Fix that, and you have my ack on the mmiotrace.txt part.
>

Oh, I forgot to grep Kconfig.. There is also a reference to
kmemtrace.txt in Kconfig. I'll fix it.

2009-04-10 13:04:42

by Ingo Molnar

[permalink] [raw]
Subject: Re: [tip:tracing/urgent] tracing: consolidate documents


* Pekka Paalanen <[email protected]> wrote:

> On Thu, 9 Apr 2009 05:30:47 GMT
> Li Zefan <[email protected]> wrote:
>
> > Commit-ID: 66bb74888eb4bef4ba7c87c931ecb7ecca3a240c
> > Gitweb: http://git.kernel.org/tip/66bb74888eb4bef4ba7c87c931ecb7ecca3a240c
> > Author: Li Zefan <[email protected]>
> > AuthorDate: Thu, 9 Apr 2009 11:40:27 +0800
> > Committer: Ingo Molnar <[email protected]>
> > CommitDate: Thu, 9 Apr 2009 07:28:10 +0200
> >
> > tracing: consolidate documents
> >
> > Move kmemtrace.txt, tracepoints.txt, ftrace.txt and mmiotrace.txt to
> > the new trace/ directory.
> >
> > I didnt find any references to those documents in both source
> > files and documents, so no extra work needs to be done.
>
> There is one reference: kernel/trace/Kconfig, search for MMIOTRACE.
> Fix that, and you have my ack on the mmiotrace.txt part.

This fix is committed now so your ack now takes effect :)

> > Signed-off-by: Li Zefan <[email protected]>
> > Acked-by: Pekka Paalanen <[email protected]>
>
> Hey, I didn't say anything yet. Maybe you meant Enberg?
> There are at least two Pekkas here :-)

Yeah, you should rename yourself and pick some unique name like
Ingo. Oh wait ...

Ingo