2009-04-15 08:52:46

by Eugene Teo

[permalink] [raw]
Subject: [PATCH] regulator: remove extraneous semicolon

An extraneous ";" after the if statement is a bad idea.

Signed-off-by: Eugene Teo <[email protected]>
---
drivers/regulator/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 01f7702..47fc6e6 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -540,8 +540,8 @@ static void drms_uA_update(struct regulator_dev *rdev)

err = regulator_check_drms(rdev);
if (err < 0 || !rdev->desc->ops->get_optimum_mode ||
- !rdev->desc->ops->get_voltage || !rdev->desc->ops->set_mode);
- return;
+ !rdev->desc->ops->get_voltage || !rdev->desc->ops->set_mode)
+ return;

/* get output voltage */
output_uV = rdev->desc->ops->get_voltage(rdev);


2009-04-15 09:51:20

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] regulator: remove extraneous semicolon

On Wed, Apr 15, 2009 at 04:52:22PM +0800, Eugene Teo wrote:
> An extraneous ";" after the if statement is a bad idea.
>
> Signed-off-by: Eugene Teo <[email protected]>

Someone sent the same patch a couple of days ago so that one might end
up getting merged instead but in any case

Acked-by: Mark Brown <[email protected]>

2009-04-15 15:59:23

by Liam Girdwood

[permalink] [raw]
Subject: Re: [PATCH] regulator: remove extraneous semicolon

On Wed, 2009-04-15 at 10:51 +0100, Mark Brown wrote:
> On Wed, Apr 15, 2009 at 04:52:22PM +0800, Eugene Teo wrote:
> > An extraneous ";" after the if statement is a bad idea.
> >
> > Signed-off-by: Eugene Teo <[email protected]>
>
> Someone sent the same patch a couple of days ago so that one might end
> up getting merged instead but in any case
>

Thanks, I've just applied the earlier patch as it was first in my inbox.

Liam