Observed the following build error:
CC arch/powerpc/platforms/pasemi/setup.o
arch/powerpc/platforms/pasemi/setup.c:48: error: redefinition of
‘smp_send_stop’
include/linux/smp.h:125: error: previous definition of ‘smp_send_stop’
was here
make[2]: *** [arch/powerpc/platforms/pasemi/setup.o] Error 1
make[1]: *** [arch/powerpc/platforms/pasemi] Error 2
make: *** [arch/powerpc/platforms] Error 2
Regards--
Subrata
A non-SMP version of smp_send_stop() is now included in smp.h.
Remove the unneeded def in the pasemi setup.c.
Fixes build errors like these when CONFIG_SMP=n:
arch/powerpc/platforms/pasemi/setup.c:48: error: redefinition of ‘smp_send_stop’
include/linux/smp.h:125: error: previous definition of 'smp_send_stop' was here
Reported-by: [email protected]
Signed-off-by: Geoff Levand <[email protected]>
---
diff --git a/arch/powerpc/platforms/pasemi/setup.c b/arch/powerpc/platforms/pasemi/setup.c
index c64fb5b..153051e 100644
--- a/arch/powerpc/platforms/pasemi/setup.c
+++ b/arch/powerpc/platforms/pasemi/setup.c
@@ -44,10 +44,6 @@
#include "pasemi.h"
-#if !defined(CONFIG_SMP)
-static void smp_send_stop(void) {}
-#endif
-
/* SDC reset register, must be pre-mapped at reset time */
static void __iomem *reset_reg;
On Fri, Apr 17, 2009 at 09:36:37AM -0700, Geoff Levand wrote:
> A non-SMP version of smp_send_stop() is now included in smp.h.
> Remove the unneeded def in the pasemi setup.c.
>
> Fixes build errors like these when CONFIG_SMP=n:
>
> arch/powerpc/platforms/pasemi/setup.c:48: error: redefinition of ???smp_send_stop???
> include/linux/smp.h:125: error: previous definition of 'smp_send_stop' was here
Thanks for taking care of this.
> Reported-by: [email protected]
> Signed-off-by: Geoff Levand <[email protected]>
Acked-by: Olof Johansson <[email protected]>
-Olof