2009-04-28 21:34:21

by Ed Goggin

Subject: Simple typo in reboot.c when enabling CONFIG_KDB_KDUMP

Patch 1 of 1

Simple typo when enabling CONFIG_KDB_KDUMP.

Signed-off-by: Ed Goggin <[email protected]>


--- linux-2.6.29/arch/x86/kernel/reboot.c 2009-04-28 14:37:30.000000000 -0400
+++ linux-2.6.29.fix/arch/x86/kernel/./reboot.c 2009-04-28 14:37:37.000000000 -0400
@@ -649,7 +649,7 @@ void halt_current_cpu(struct pt_regs *re
#ifdef CONFIG_X86_32
if (!user_mode_vm(regs)) {
crash_fixup_ss_esp(&fixed_regs, regs);
- regs = &fixed_Regs;
+ regs = &fixed_regs;
}
#endif
crash_save_cpu(regs, raw_smp_processor_id());

2009-04-29 05:32:53

by Ingo Molnar

Subject: Re: Simple typo in reboot.c when enabling CONFIG_KDB_KDUMP

* Edward Goggin <[email protected]> wrote:

> Patch 1 of 1
>
> Simple typo when enabling CONFIG_KDB_KDUMP.
>
> Signed-off-by: Ed Goggin <[email protected]>
>
>
> --- linux-2.6.29/arch/x86/kernel/reboot.c 2009-04-28 14:37:30.000000000 -0400
> +++ linux-2.6.29.fix/arch/x86/kernel/./reboot.c 2009-04-28 14:37:37.000000000 -0400
> @@ -649,7 +649,7 @@ void halt_current_cpu(struct pt_regs *re
> #ifdef CONFIG_X86_32
> if (!user_mode_vm(regs)) {
> crash_fixup_ss_esp(&fixed_regs, regs);
> - regs = &fixed_Regs;
> + regs = &fixed_regs;
> }
> #endif
> crash_save_cpu(regs, raw_smp_processor_id());

There's no such code in the current upstream kernel. Exactly which
kernel version (sha1) are you sending a patch against?

Ingo

2009-04-29 13:19:28

by Ed Goggin

Subject: RE: Simple typo in reboot.c when enabling CONFIG_KDB_KDUMP

Good point. Its after applying a KDB patch from SGI. I'll submit
the patch to Keith Owens at SGI intead.

> -----Original Message-----
> From: Ingo Molnar [mailto:[email protected]]
> Sent: Wednesday, April 29, 2009 1:33 AM
> To: Edward Goggin
> Cc: '[email protected]'
> Subject: Re: Simple typo in reboot.c when enabling CONFIG_KDB_KDUMP
>
>
> * Edward Goggin <[email protected]> wrote:
>
> > Patch 1 of 1
> >
> > Simple typo when enabling CONFIG_KDB_KDUMP.
> >
> > Signed-off-by: Ed Goggin <[email protected]>
> >
> >
> > --- linux-2.6.29/arch/x86/kernel/reboot.c 2009-04-28
> 14:37:30.000000000 -0400
> > +++ linux-2.6.29.fix/arch/x86/kernel/./reboot.c
> 2009-04-28 14:37:37.000000000 -0400
> > @@ -649,7 +649,7 @@ void halt_current_cpu(struct pt_regs
> *re #ifdef
> > CONFIG_X86_32
> > if (!user_mode_vm(regs)) {
> > crash_fixup_ss_esp(&fixed_regs, regs);
> > - regs = &fixed_Regs;
> > + regs = &fixed_regs;
> > }
> > #endif
> > crash_save_cpu(regs, raw_smp_processor_id());
>
> There's no such code in the current upstream kernel. Exactly
> which kernel version (sha1) are you sending a patch against?
>
> Ingo
> -