2009-06-08 20:59:33

by scameron

[permalink] [raw]
Subject: [patch 1/8] cciss: Use schedule_timeout_uninterruptible in SCSI error handling code



Use schedule_timeout_uninterruptible instead of schedule_timeout in the
scsi error handling code when waiting between TUR polls since we are not
interested in nor want to be interrupted by signals.

Signed-off-by: Stephen M. Cameron <[email protected]>

---

---


diff -puN drivers/block/cciss_scsi.c~use_uninterruptible_timeout drivers/block/cciss_scsi.c
--- linux-next/drivers/block/cciss_scsi.c~use_uninterruptible_timeout 2009-06-08 12:56:39.000000000 -0500
+++ linux-next-scameron/drivers/block/cciss_scsi.c 2009-06-08 12:57:17.000000000 -0500
@@ -1608,7 +1608,7 @@ static int wait_for_device_to_become_rea
/* Wait for a bit. do this first, because if we send
* the TUR right away, the reset will just abort it.
*/
- schedule_timeout_interruptible(waittime);
+ schedule_timeout_uninterruptible(waittime);
count++;

/* Increase wait time with each try, up to a point. */
_


2009-06-09 03:48:18

by Jens Axboe

[permalink] [raw]
Subject: Re: [patch 1/8] cciss: Use schedule_timeout_uninterruptible in SCSI error handling code

On Mon, Jun 08 2009, [email protected] wrote:
>
>
> Use schedule_timeout_uninterruptible instead of schedule_timeout in the
> scsi error handling code when waiting between TUR polls since we are not
> interested in nor want to be interrupted by signals.

Thanks Steve, applied 1-8.

--
Jens Axboe