2009-06-11 18:29:16

by Jesse Barnes

[permalink] [raw]
Subject: Re: [PATCH] msi-x: let drivers retry when not enough vectors

On Thu, 7 May 2009 11:28:41 +0300
"Michael S. Tsirkin" <[email protected]> wrote:

> pci_enable_msix currently returns -EINVAL if you ask
> for more vectors than supported by the device, which would
> typically cause fallback to regular interrupts.
>
> It's better to return the table size, making the driver retry
> MSI-X with less vectors.
>
> Signed-off-by: Michael S. Tsirkin <[email protected]>
> ---
>
> Hi Jesse,
> This came up when I was adding MSI-X support to virtio pci driver,
> which does not know the exact table size upfront.
> Could you consider this patch for 2.6.31 please?

Applied this one to my linux-next branch; hopefully Rusty won't mind
too much. :)

--
Jesse Barnes, Intel Open Source Technology Center