2009-04-24 02:46:28

by Huang, Ying

[permalink] [raw]
Subject: [PATCH 4/4] PCI: PCIE AER: Document for PCIE AER software error injection

This patch add a minimal HOWTO for PCIE AER software error injection
in Documentation/PCI/pcieaer-howto.txt.

Signed-off-by: Huang Ying <[email protected]>

---
Documentation/PCI/pcieaer-howto.txt | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)

--- a/Documentation/PCI/pcieaer-howto.txt
+++ b/Documentation/PCI/pcieaer-howto.txt
@@ -246,3 +246,24 @@ with the PCI Express AER Root driver?
A: It could call the helper functions to enable AER in devices and
cleanup uncorrectable status register. Pls. refer to section 3.3.

+
+4. Software error injection
+
+Debugging PCIE AER error recovery code is quite difficult because it
+is hard to trigger real hardware errors. Software based error
+injection can be used to fake various kinds of PCIE errors.
+
+First you should enable PCIE AER software error injection in kernel
+configuration, that is, following item should be in your .config.
+
+CONFIG_PCIEAER_INJECT=y or CONFIG_PCIEAER_INJECT=m
+
+After reboot with new kernel or insert the module, a device file named
+/dev/aer_inject should be created.
+
+Then, you need a user space tool named aer-inject, which can be gotten
+from:
+ http://www.kernel.org/pub/linux/kernel/people/yhuang/
+
+More information about aer-inject can be found in the document comes
+with its source code.

Attachments:
signature.asc (197.00 B)
This is a digitally signed message part

2009-04-24 08:14:57

by Andi Kleen

[permalink] [raw]
Subject: Re: [PATCH 4/4] PCI: PCIE AER: Document for PCIE AER software error injection

Hi Ying,

On Fri, Apr 24, 2009 at 10:45:31AM +0800, Huang Ying wrote:
> This patch add a minimal HOWTO for PCIE AER software error injection
> in Documentation/PCI/pcieaer-howto.txt.

I reviewed the patches and they all look good to me.
I also think they're a valuable addition to Linux.

You can add a

Reviewed-by: Andi Kleen <[email protected]>

to the whole series.

-Andi

2009-06-11 19:01:29

by Jesse Barnes

[permalink] [raw]
Subject: Re: [PATCH 4/4] PCI: PCIE AER: Document for PCIE AER software error injection

On Fri, 24 Apr 2009 10:45:31 +0800
Huang Ying <[email protected]> wrote:

> This patch add a minimal HOWTO for PCIE AER software error injection
> in Documentation/PCI/pcieaer-howto.txt.
>
> Signed-off-by: Huang Ying <[email protected]>
>
> ---
> Documentation/PCI/pcieaer-howto.txt | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)

Applied this one (though it doesn't make much sense until the other
one is applied too :).

-- Jesse Barnes, Intel Open Source Technology Center