2009-06-11 13:14:48

by Heiko Carstens

Subject: [PATCH] partitions: fix broken uevent_suppress conversion

From: Heiko Carstens <[email protected]>

git commit f67f129e "Driver core: implement uevent suppress in kobject"
contains this chunk for fs/partitions/check.c:

/* suppress uevent if the disk supresses it */
- if (!ddev->uevent_suppress)
+ if (!dev_get_uevent_suppress(pdev))
kobject_uevent(&pdev->kobj, KOBJ_ADD);

However that should have been

- if (!ddev->uevent_suppress)
+ if (!dev_get_uevent_suppress(ddev))

Cc: Ming Lei <[email protected]>
Signed-off-by: Heiko Carstens <[email protected]>
---
fs/partitions/check.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6/fs/partitions/check.c
===================================================================
--- linux-2.6.orig/fs/partitions/check.c
+++ linux-2.6/fs/partitions/check.c
@@ -426,7 +426,7 @@ struct hd_struct *add_partition(struct g
rcu_assign_pointer(ptbl->part[partno], p);

/* suppress uevent if the disk supresses it */
- if (!dev_get_uevent_suppress(pdev))
+ if (!dev_get_uevent_suppress(ddev))
kobject_uevent(&pdev->kobj, KOBJ_ADD);

return p;

2009-06-11 14:17:52

by Ming Lei

Subject: Re: [PATCH] partitions: fix broken uevent_suppress conversion

2009/6/11 Heiko Carstens <[email protected]>:
> From: Heiko Carstens <[email protected]>
>
> git commit f67f129e "Driver core: implement uevent suppress in kobject"
> contains this chunk for fs/partitions/check.c:
>
> ? ? ? ?/* suppress uevent if the disk supresses it */
> - ? ? ? if (!ddev->uevent_suppress)
> + ? ? ? if (!dev_get_uevent_suppress(pdev))
> ? ? ? ? ? ? ? ?kobject_uevent(&pdev->kobj, KOBJ_ADD);
>
> However that should have been
>
> - ? ? ? if (!ddev->uevent_suppress)
> + ? ? ? if (!dev_get_uevent_suppress(ddev))
>
> Cc: Ming Lei <[email protected]>
> Signed-off-by: Heiko Carstens <[email protected]>
> ---
> ?fs/partitions/check.c | ? ?2 +-
> ?1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6/fs/partitions/check.c
> ===================================================================
> --- linux-2.6.orig/fs/partitions/check.c
> +++ linux-2.6/fs/partitions/check.c
> @@ -426,7 +426,7 @@ struct hd_struct *add_partition(struct g
> ? ? ? ?rcu_assign_pointer(ptbl->part[partno], p);
>
> ? ? ? ?/* suppress uevent if the disk supresses it */
> - ? ? ? if (!dev_get_uevent_suppress(pdev))
> + ? ? ? if (!dev_get_uevent_suppress(ddev))
> ? ? ? ? ? ? ? ?kobject_uevent(&pdev->kobj, KOBJ_ADD);
>
> ? ? ? ?return p;
>

Thanks.

Acked-by: Ming Lei <[email protected]>

--
Lei Ming