2009-06-19 09:18:40

by Sergey Senozhatsky

[permalink] [raw]
Subject: blk-settings.c integer truncation

Hello.
I was asking
> Should BLK_BOUNCE_ANY be (-1UL)?

No. It should not.

git annotate gives for blkdev.h:
Andi Kleen 2008-04-21 09:51:05 +0200 705)#define BLK_BOUNCE_ANY (-1ULL)
...

...
(Martin K. Petersen 2009-05-22 17:17:51 -0400 311) unsigned long bounce_pfn;
...
(Martin K. Petersen 2009-05-22 17:17:50 -0400 1020)static inline unsigned long queue_bounce_pfn(struct request_queue *q)
(Martin K. Petersen 2009-05-22 17:17:50 -0400 1021){
(Martin K. Petersen 2009-05-22 17:17:51 -0400 1022) return q->limits.bounce_pfn;
(Martin K. Petersen 2009-05-22 17:17:50 -0400 1023)}
...

I think, commit need to be reworked a bit.

Sergey