2009-06-19 01:14:18

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: origin tree build warning

Hi Linus,

Today's linux-next build (x86_64 allmodconfig) produced this warning:

drivers/video/s1d13xxxfb.c:420: warning: 'bltbit_wait_bitset' defined but not used
drivers/video/s1d13xxxfb.c:463: warning: 'bltbit_fifo_status' defined but not used

Introduced by commit 3ed167af96ed098187ea41353fe02d1af20d38a1 ("fbdev:
s1d13xxxfb: add accelerated bitblt functions").

--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/


Attachments:
(No filename) (472.00 B)
(No filename) (197.00 B)
Download all attachments

2009-06-19 08:44:48

by Kristoffer Ericson

[permalink] [raw]
Subject: Re: linux-next: origin tree build warning

Greetings,

Hmm, this would be true if you are using the s1d13xxxfb driver without having supported 2D accel (essentially everything not 13506). Atleast
for bltbit_wait_bitset. The bltbit_fifo_status on the other hand is needed later on
for image blitting, which is coming.

The point is basicly this, all s1d13xxxfb cards should get their 2D acceleration
going so until then this is just an annoying but harmless warning.

Hope that answers your comment.

Best wishes
Kristoffer

On Fri, 19 Jun 2009 11:13:59 +1000
Stephen Rothwell <[email protected]> wrote:

> Hi Linus,
>
> Today's linux-next build (x86_64 allmodconfig) produced this warning:
>
> drivers/video/s1d13xxxfb.c:420: warning: 'bltbit_wait_bitset' defined but not used
> drivers/video/s1d13xxxfb.c:463: warning: 'bltbit_fifo_status' defined but not used
>
> Introduced by commit 3ed167af96ed098187ea41353fe02d1af20d38a1 ("fbdev:
> s1d13xxxfb: add accelerated bitblt functions").
>
> --
> Cheers,
> Stephen Rothwell [email protected]
> http://www.canb.auug.org.au/~sfr/
>


--
Kristoffer Ericson <[email protected]>