2009-07-08 14:48:37

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 0/44] includecheck: fix multiple includes

The following changes since commit faf80d62e44dc627efb741f48db50c1858d1667c:
Linus Torvalds (1):
Merge branch 'x86-fixes-for-linus' of git://git.kernel.org/.../tip/linux-2.6-tip

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/headers-check-2.6.git master

Jaswinder Singh Rajput (44):
includecheck fix: arm, misc.c
includecheck fix: arm, atomic.h
includecheck fix: arm, board-dm355-evm.c
includecheck fix: arm, board-dm355-leopard.c
includecheck fix: arm, board-dm644x-evm.c
includecheck fix: arm, board-dm646x-evm.c
includecheck fix: arm, board-sffsdr.c
includecheck fix: arm, mach-mx3/devices.c
includecheck fix: arm, mach-omap1/mcbsp.c
includecheck fix: arm, mach-omap2/mcbsp.c
includecheck fix: arm, plat-s3c64xx/pm.c
includecheck fix: arm, plat-stmp3xxx/pinmux.c
includecheck fix: mn10300, sys_mn10300.c
includecheck fix: powerpc, mpc7450-pmu.c
includecheck fix: powerpc, ppc970-pmu.c
includecheck fix: s390, sys_s390.c
includecheck fix: um, helper.c
includecheck fix: x86, dumpstack.c
includecheck fix: x86, traps.c
includecheck fix: x86, shadow.c
includecheck fix: Documentation, cfag12864b-example.c
includecheck fix: drivers/char, vt.c
includecheck fix: drivers/net, sja1000.c
includecheck fix: drivers/net, axnet_cs.c
includecheck fix: drivers/net, smc911x.h
includecheck fix: drivers/parisc, ccio-dma.c
includecheck fix: drivers/scsi, libfcoe.c
includecheck fix: drivers/scsi, ibmvscsi.c
includecheck fix: drivers/spi, amba-pl022.c
includecheck fix: drivers/staging, usbdrv.c
includecheck fix: drivers/staging, rt_linux.h
includecheck fix: drivers/video, vgacon.c
includecheck fix: drivers/xen, evtchn.c
includecheck fix: fs/xfs, xfs_iops.c
includecheck fix: include/acpi, acpi_bus.h
includecheck fix: include/drm, drm_memory.h
includecheck fix: include/linux, aio.h
includecheck fix: include/linux, ftrace.h
includecheck fix: include/linux, icmpv6.h
includecheck fix: include/linux, net_dropmon.h
includecheck fix: include/linux, rfkill.h
includecheck fix: kernel/trace, ring_buffer.c
includecheck fix: mm, nommu.c
includecheck fix: mm, shmem.c

Documentation/auxdisplay/cfag12864b-example.c | 1 -
arch/arm/boot/compressed/misc.c | 1 -
arch/arm/include/asm/atomic.h | 2 --
arch/arm/mach-davinci/board-dm355-evm.c | 1 -
arch/arm/mach-davinci/board-dm355-leopard.c | 1 -
arch/arm/mach-davinci/board-dm644x-evm.c | 1 -
arch/arm/mach-davinci/board-dm646x-evm.c | 1 -
arch/arm/mach-davinci/board-sffsdr.c | 1 -
arch/arm/mach-mx3/devices.c | 1 -
arch/arm/mach-omap1/mcbsp.c | 1 -
arch/arm/mach-omap2/mcbsp.c | 1 -
arch/arm/plat-s3c64xx/pm.c | 2 --
arch/arm/plat-stmp3xxx/pinmux.c | 1 -
arch/mn10300/kernel/sys_mn10300.c | 1 -
arch/powerpc/kernel/mpc7450-pmu.c | 1 -
arch/powerpc/kernel/ppc970-pmu.c | 1 -
arch/s390/kernel/sys_s390.c | 1 -
arch/um/os-Linux/helper.c | 1 -
arch/x86/kernel/dumpstack.c | 1 -
arch/x86/kernel/traps.c | 1 -
arch/x86/mm/kmemcheck/shadow.c | 1 -
drivers/char/vt.c | 1 -
drivers/net/can/sja1000/sja1000.c | 1 -
drivers/net/pcmcia/axnet_cs.c | 2 --
drivers/net/smc911x.h | 1 -
drivers/parisc/ccio-dma.c | 1 -
drivers/scsi/fcoe/libfcoe.c | 1 -
drivers/scsi/ibmvscsi/ibmvscsi.c | 1 -
drivers/spi/amba-pl022.c | 2 --
drivers/staging/otus/usbdrv.c | 3 ---
drivers/staging/rt2860/rt_linux.h | 4 ----
drivers/video/console/vgacon.c | 1 -
drivers/xen/evtchn.c | 1 -
fs/xfs/linux-2.6/xfs_iops.c | 1 -
include/acpi/acpi_bus.h | 1 -
include/drm/drm_memory.h | 2 --
include/linux/aio.h | 2 --
include/linux/ftrace.h | 1 -
include/linux/icmpv6.h | 2 --
include/linux/net_dropmon.h | 1 -
include/linux/rfkill.h | 1 -
kernel/trace/ring_buffer.c | 2 --
mm/nommu.c | 2 --
mm/shmem.c | 1 -
44 files changed, 0 insertions(+), 58 deletions(-)


2009-07-08 14:46:00

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 1/44] includecheck fix: arm, misc.c


fix the following 'make includecheck' warning:

arch/arm/boot/compressed/misc.c: linux/compiler.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
arch/arm/boot/compressed/misc.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/arm/boot/compressed/misc.c b/arch/arm/boot/compressed/misc.c
index 9e6e512..17153b5 100644
--- a/arch/arm/boot/compressed/misc.c
+++ b/arch/arm/boot/compressed/misc.c
@@ -29,7 +29,6 @@ unsigned int __machine_arch_type;

static void putstr(const char *ptr);

-#include <linux/compiler.h>
#include <mach/uncompress.h>

#ifdef CONFIG_DEBUG_ICEDCC
--
1.6.0.6


2009-07-08 14:46:19

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 2/44] includecheck fix: arm, atomic.h


fix the following 'make includecheck' warning:

arch/arm/include/asm/atomic.h: asm/system.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
arch/arm/include/asm/atomic.h | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/arch/arm/include/asm/atomic.h b/arch/arm/include/asm/atomic.h
index 9e07fe5..9ed2377 100644
--- a/arch/arm/include/asm/atomic.h
+++ b/arch/arm/include/asm/atomic.h
@@ -159,8 +159,6 @@ static inline void atomic_clear_mask(unsigned long mask, unsigned long *addr)

#else /* ARM_ARCH_6 */

-#include <asm/system.h>
-
#ifdef CONFIG_SMP
#error SMP not supported on pre-ARMv6 CPUs
#endif
--
1.6.0.6


2009-07-08 14:46:30

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 4/44] includecheck fix: arm, board-dm355-leopard.c


fix the following 'make includecheck' warning:

arch/arm/mach-davinci/board-dm355-leopard.c: mach/common.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
arch/arm/mach-davinci/board-dm355-leopard.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-davinci/board-dm355-leopard.c b/arch/arm/mach-davinci/board-dm355-leopard.c
index 28c9008..84ad5d1 100644
--- a/arch/arm/mach-davinci/board-dm355-leopard.c
+++ b/arch/arm/mach-davinci/board-dm355-leopard.c
@@ -36,7 +36,6 @@
#include <mach/serial.h>
#include <mach/nand.h>
#include <mach/mmc.h>
-#include <mach/common.h>

#define DAVINCI_ASYNC_EMIF_CONTROL_BASE 0x01e10000
#define DAVINCI_ASYNC_EMIF_DATA_CE0_BASE 0x02000000
--
1.6.0.6


2009-07-08 14:46:43

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 3/44] includecheck fix: arm, board-dm355-evm.c


fix the following 'make includecheck' warning:

arch/arm/mach-davinci/board-dm355-evm.c: mach/common.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
arch/arm/mach-davinci/board-dm355-evm.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-davinci/board-dm355-evm.c b/arch/arm/mach-davinci/board-dm355-evm.c
index 5ac2f56..d6ab64c 100644
--- a/arch/arm/mach-davinci/board-dm355-evm.c
+++ b/arch/arm/mach-davinci/board-dm355-evm.c
@@ -37,7 +37,6 @@
#include <mach/serial.h>
#include <mach/nand.h>
#include <mach/mmc.h>
-#include <mach/common.h>

#define DAVINCI_ASYNC_EMIF_CONTROL_BASE 0x01e10000
#define DAVINCI_ASYNC_EMIF_DATA_CE0_BASE 0x02000000
--
1.6.0.6


2009-07-08 14:46:53

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 6/44] includecheck fix: arm, board-dm646x-evm.c


fix the following 'make includecheck' warning:

arch/arm/mach-davinci/board-dm646x-evm.c: mach/common.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
arch/arm/mach-davinci/board-dm646x-evm.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-davinci/board-dm646x-evm.c b/arch/arm/mach-davinci/board-dm646x-evm.c
index e17de63..8657e72 100644
--- a/arch/arm/mach-davinci/board-dm646x-evm.c
+++ b/arch/arm/mach-davinci/board-dm646x-evm.c
@@ -47,7 +47,6 @@
#include <mach/i2c.h>
#include <mach/mmc.h>
#include <mach/emac.h>
-#include <mach/common.h>

#define DM646X_EVM_PHY_MASK (0x2)
#define DM646X_EVM_MDIO_FREQUENCY (2200000) /* PHY bus frequency */
--
1.6.0.6


2009-07-08 14:47:12

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 5/44] includecheck fix: arm, board-dm644x-evm.c


fix the following 'make includecheck' warning:

arch/arm/mach-davinci/board-dm644x-evm.c: mach/common.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
arch/arm/mach-davinci/board-dm644x-evm.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-davinci/board-dm644x-evm.c b/arch/arm/mach-davinci/board-dm644x-evm.c
index d9d4045..56c8cd0 100644
--- a/arch/arm/mach-davinci/board-dm644x-evm.c
+++ b/arch/arm/mach-davinci/board-dm644x-evm.c
@@ -45,7 +45,6 @@
#include <mach/nand.h>
#include <mach/mmc.h>
#include <mach/emac.h>
-#include <mach/common.h>

#define DM644X_EVM_PHY_MASK (0x2)
#define DM644X_EVM_MDIO_FREQUENCY (2200000) /* PHY bus frequency */
--
1.6.0.6


2009-07-08 14:47:28

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 7/44] includecheck fix: arm, board-sffsdr.c


fix the following 'make includecheck' warning:

arch/arm/mach-davinci/board-sffsdr.c: mach/common.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
arch/arm/mach-davinci/board-sffsdr.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-davinci/board-sffsdr.c b/arch/arm/mach-davinci/board-sffsdr.c
index 748a8e4..7acdfd8 100644
--- a/arch/arm/mach-davinci/board-sffsdr.c
+++ b/arch/arm/mach-davinci/board-sffsdr.c
@@ -52,7 +52,6 @@
#include <mach/serial.h>
#include <mach/psc.h>
#include <mach/mux.h>
-#include <mach/common.h>

#define SFFSDR_PHY_MASK (0x2)
#define SFFSDR_MDIO_FREQUENCY (2200000) /* PHY bus frequency */
--
1.6.0.6


2009-07-08 14:47:41

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 8/44] includecheck fix: arm, mach-mx3/devices.c


fix the following 'make includecheck' warning:

arch/arm/mach-mx3/devices.c: linux/dma-mapping.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
arch/arm/mach-mx3/devices.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-mx3/devices.c b/arch/arm/mach-mx3/devices.c
index d927edd..9e87e08 100644
--- a/arch/arm/mach-mx3/devices.c
+++ b/arch/arm/mach-mx3/devices.c
@@ -22,7 +22,6 @@
#include <linux/platform_device.h>
#include <linux/serial.h>
#include <linux/gpio.h>
-#include <linux/dma-mapping.h>
#include <mach/hardware.h>
#include <mach/irqs.h>
#include <mach/common.h>
--
1.6.0.6


2009-07-08 14:47:53

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 9/44] includecheck fix: arm, mach-omap1/mcbsp.c


fix the following 'make includecheck' warning:

arch/arm/mach-omap1/mcbsp.c: mach/irqs.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
arch/arm/mach-omap1/mcbsp.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap1/mcbsp.c b/arch/arm/mach-omap1/mcbsp.c
index a2d7814..505d98c 100644
--- a/arch/arm/mach-omap1/mcbsp.c
+++ b/arch/arm/mach-omap1/mcbsp.c
@@ -19,7 +19,6 @@

#include <mach/irqs.h>
#include <mach/dma.h>
-#include <mach/irqs.h>
#include <mach/mux.h>
#include <mach/cpu.h>
#include <mach/mcbsp.h>
--
1.6.0.6


2009-07-08 14:48:09

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 11/44] includecheck fix: arm, plat-s3c64xx/pm.c


fix the following 'make includecheck' warning:

arch/arm/plat-s3c64xx/pm.c: plat/regs-gpio.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
arch/arm/plat-s3c64xx/pm.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/arch/arm/plat-s3c64xx/pm.c b/arch/arm/plat-s3c64xx/pm.c
index 07a6516..47632fc 100644
--- a/arch/arm/plat-s3c64xx/pm.c
+++ b/arch/arm/plat-s3c64xx/pm.c
@@ -117,8 +117,6 @@ void s3c_pm_save_core(void)
* this.
*/

-#include <plat/regs-gpio.h>
-
static void s3c64xx_cpu_suspend(void)
{
unsigned long tmp;
--
1.6.0.6


2009-07-08 14:48:24

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 10/44] includecheck fix: arm, mach-omap2/mcbsp.c


fix the following 'make includecheck' warning:

arch/arm/mach-omap2/mcbsp.c: mach/irqs.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
arch/arm/mach-omap2/mcbsp.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/mcbsp.c b/arch/arm/mach-omap2/mcbsp.c
index a5c0f04..99b6e15 100644
--- a/arch/arm/mach-omap2/mcbsp.c
+++ b/arch/arm/mach-omap2/mcbsp.c
@@ -19,7 +19,6 @@

#include <mach/irqs.h>
#include <mach/dma.h>
-#include <mach/irqs.h>
#include <mach/mux.h>
#include <mach/cpu.h>
#include <mach/mcbsp.h>
--
1.6.0.6


2009-07-08 14:48:49

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 12/44] includecheck fix: arm, plat-stmp3xxx/pinmux.c


fix the following 'make includecheck' warning:

arch/arm/plat-stmp3xxx/pinmux.c: linux/sysdev.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
arch/arm/plat-stmp3xxx/pinmux.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/arm/plat-stmp3xxx/pinmux.c b/arch/arm/plat-stmp3xxx/pinmux.c
index d412003..6d6b1a4 100644
--- a/arch/arm/plat-stmp3xxx/pinmux.c
+++ b/arch/arm/plat-stmp3xxx/pinmux.c
@@ -22,7 +22,6 @@
#include <linux/sysdev.h>
#include <linux/string.h>
#include <linux/bitops.h>
-#include <linux/sysdev.h>
#include <linux/irq.h>

#include <mach/hardware.h>
--
1.6.0.6


2009-07-08 14:49:00

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 14/44] includecheck fix: powerpc, mpc7450-pmu.c


fix the following 'make includecheck' warning:

arch/powerpc/kernel/mpc7450-pmu.c: linux/string.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
arch/powerpc/kernel/mpc7450-pmu.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/powerpc/kernel/mpc7450-pmu.c b/arch/powerpc/kernel/mpc7450-pmu.c
index 75ff47f..c244133 100644
--- a/arch/powerpc/kernel/mpc7450-pmu.c
+++ b/arch/powerpc/kernel/mpc7450-pmu.c
@@ -10,7 +10,6 @@
*/
#include <linux/string.h>
#include <linux/perf_counter.h>
-#include <linux/string.h>
#include <asm/reg.h>
#include <asm/cputable.h>

--
1.6.0.6


2009-07-08 14:49:23

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 13/44] includecheck fix: mn10300, sys_mn10300.c

includecheck fix: mn10300, sys_mn10300.c

fix the following 'make includecheck' warning:

arch/mn10300/kernel/sys_mn10300.c: linux/syscalls.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
arch/mn10300/kernel/sys_mn10300.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/mn10300/kernel/sys_mn10300.c b/arch/mn10300/kernel/sys_mn10300.c
index bca5a84..6551ada 100644
--- a/arch/mn10300/kernel/sys_mn10300.c
+++ b/arch/mn10300/kernel/sys_mn10300.c
@@ -21,7 +21,6 @@
#include <linux/mman.h>
#include <linux/file.h>
#include <linux/utsname.h>
-#include <linux/syscalls.h>
#include <linux/tty.h>

#include <asm/uaccess.h>
--
1.6.0.6


2009-07-08 16:01:55

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 15/44] includecheck fix: powerpc, ppc970-pmu.c



fix the following 'make includecheck' warning:

arch/powerpc/kernel/ppc970-pmu.c: linux/string.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
arch/powerpc/kernel/ppc970-pmu.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/powerpc/kernel/ppc970-pmu.c b/arch/powerpc/kernel/ppc970-pmu.c
index 6637c87..833097a 100644
--- a/arch/powerpc/kernel/ppc970-pmu.c
+++ b/arch/powerpc/kernel/ppc970-pmu.c
@@ -10,7 +10,6 @@
*/
#include <linux/string.h>
#include <linux/perf_counter.h>
-#include <linux/string.h>
#include <asm/reg.h>
#include <asm/cputable.h>

--
1.6.0.6


2009-07-08 16:02:26

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 17/44] includecheck fix: um, helper.c


fix the following 'make includecheck' warning:

arch/um/os-Linux/helper.c: linux/limits.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
arch/um/os-Linux/helper.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/um/os-Linux/helper.c b/arch/um/os-Linux/helper.c
index 30860b8..b6b1096 100644
--- a/arch/um/os-Linux/helper.c
+++ b/arch/um/os-Linux/helper.c
@@ -15,7 +15,6 @@
#include "os.h"
#include "um_malloc.h"
#include "user.h"
-#include <linux/limits.h>

struct helper_data {
void (*pre_exec)(void*);
--
1.6.0.6


2009-07-08 16:02:38

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 18/44] includecheck fix: x86, dumpstack.c


fix the following 'make includecheck' warning:

arch/x86/kernel/dumpstack.c: linux/ftrace.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
arch/x86/kernel/dumpstack.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c
index c840571..2d8a371 100644
--- a/arch/x86/kernel/dumpstack.c
+++ b/arch/x86/kernel/dumpstack.c
@@ -15,7 +15,6 @@
#include <linux/bug.h>
#include <linux/nmi.h>
#include <linux/sysfs.h>
-#include <linux/ftrace.h>

#include <asm/stacktrace.h>

--
1.6.0.6


2009-07-08 16:02:50

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 19/44] includecheck fix: x86, traps.c


fix the following 'make includecheck' warning:

arch/x86/kernel/traps.c: asm/traps.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
arch/x86/kernel/traps.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c
index 5204332..de96b50 100644
--- a/arch/x86/kernel/traps.c
+++ b/arch/x86/kernel/traps.c
@@ -64,7 +64,6 @@
#else
#include <asm/processor-flags.h>
#include <asm/setup.h>
-#include <asm/traps.h>

asmlinkage int system_call(void);

--
1.6.0.6


2009-07-08 16:03:04

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 20/44] includecheck fix: x86, shadow.c


fix the following 'make includecheck' warning:

arch/x86/mm/kmemcheck/shadow.c: linux/module.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
arch/x86/mm/kmemcheck/shadow.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/x86/mm/kmemcheck/shadow.c b/arch/x86/mm/kmemcheck/shadow.c
index e773b6b..3f66b82 100644
--- a/arch/x86/mm/kmemcheck/shadow.c
+++ b/arch/x86/mm/kmemcheck/shadow.c
@@ -1,7 +1,6 @@
#include <linux/kmemcheck.h>
#include <linux/module.h>
#include <linux/mm.h>
-#include <linux/module.h>

#include <asm/page.h>
#include <asm/pgtable.h>
--
1.6.0.6


2009-07-08 16:03:24

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 22/44] includecheck fix: drivers/char, vt.c


fix the following 'make includecheck' warning:

drivers/char/vt.c: linux/device.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
drivers/char/vt.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/char/vt.c b/drivers/char/vt.c
index d9113b4..4330980 100644
--- a/drivers/char/vt.c
+++ b/drivers/char/vt.c
@@ -2963,7 +2963,6 @@ int __init vty_init(const struct file_operations *console_fops)
}

#ifndef VT_SINGLE_DRIVER
-#include <linux/device.h>

static struct class *vtconsole_class;

--
1.6.0.6


2009-07-08 16:04:31

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 26/44] includecheck fix: drivers/parisc, ccio-dma.c


fix the following 'make includecheck' warning:

drivers/parisc/ccio-dma.c: linux/proc_fs.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
drivers/parisc/ccio-dma.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/parisc/ccio-dma.c b/drivers/parisc/ccio-dma.c
index 0f0e0b9..a45b0c0 100644
--- a/drivers/parisc/ccio-dma.c
+++ b/drivers/parisc/ccio-dma.c
@@ -70,7 +70,6 @@
#undef CCIO_COLLECT_STATS
#endif

-#include <linux/proc_fs.h>
#include <asm/runway.h> /* for proc_runway_root */

#ifdef DEBUG_CCIO_INIT
--
1.6.0.6


2009-07-08 16:03:51

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 21/44] includecheck fix: Documentation, cfag12864b-example.c


fix the following 'make includecheck' warning:

Documentation/auxdisplay/cfag12864b-example.c: string.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
Documentation/auxdisplay/cfag12864b-example.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/Documentation/auxdisplay/cfag12864b-example.c b/Documentation/auxdisplay/cfag12864b-example.c
index 2caeea5..156bcaa 100644
--- a/Documentation/auxdisplay/cfag12864b-example.c
+++ b/Documentation/auxdisplay/cfag12864b-example.c
@@ -194,7 +194,6 @@ void cfag12864b_blit(void)
*/

#include <stdio.h>
-#include <string.h>

#define EXAMPLES 6

--
1.6.0.6


2009-07-08 16:03:39

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 23/44] includecheck fix: drivers/net, sja1000.c


fix the following 'make includecheck' warning:

drivers/net/can/sja1000/sja1000.c: linux/can/dev.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
drivers/net/can/sja1000/sja1000.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/net/can/sja1000/sja1000.c b/drivers/net/can/sja1000/sja1000.c
index 571f133..08ebee7 100644
--- a/drivers/net/can/sja1000/sja1000.c
+++ b/drivers/net/can/sja1000/sja1000.c
@@ -63,7 +63,6 @@
#include <linux/can.h>
#include <linux/can/dev.h>
#include <linux/can/error.h>
-#include <linux/can/dev.h>

#include "sja1000.h"

--
1.6.0.6


2009-07-08 16:04:12

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 24/44] includecheck fix: drivers/net, axnet_cs.c


fix the following 'make includecheck' warning:

drivers/net/pcmcia/axnet_cs.c: linux/etherdevice.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
drivers/net/pcmcia/axnet_cs.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/net/pcmcia/axnet_cs.c b/drivers/net/pcmcia/axnet_cs.c
index 0e38d80..5a17117 100644
--- a/drivers/net/pcmcia/axnet_cs.c
+++ b/drivers/net/pcmcia/axnet_cs.c
@@ -893,8 +893,6 @@ static const char version_8390[] = KERN_INFO \
#include <linux/in.h>
#include <linux/interrupt.h>

-#include <linux/etherdevice.h>
-
#define BUG_83C690

/* These are the operational function interfaces to board-specific
--
1.6.0.6


2009-07-08 16:04:43

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 28/44] includecheck fix: drivers/scsi, ibmvscsi.c


fix the following 'make includecheck' warning:

drivers/scsi/ibmvscsi/ibmvscsi.c: asm/firmware.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
index 9928704..d9b0e9d 100644
--- a/drivers/scsi/ibmvscsi/ibmvscsi.c
+++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
@@ -73,7 +73,6 @@
#include <linux/of.h>
#include <asm/firmware.h>
#include <asm/vio.h>
-#include <asm/firmware.h>
#include <scsi/scsi.h>
#include <scsi/scsi_cmnd.h>
#include <scsi/scsi_host.h>
--
1.6.0.6


2009-07-08 16:04:57

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 25/44] includecheck fix: drivers/net, smc911x.h


fix the following 'make includecheck' warning:

drivers/net/smc911x.h: mach/dma.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
drivers/net/smc911x.h | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/net/smc911x.h b/drivers/net/smc911x.h
index 8140f7c..05adb6a 100644
--- a/drivers/net/smc911x.h
+++ b/drivers/net/smc911x.h
@@ -236,7 +236,6 @@ static inline void SMC_outsl(struct smc911x_local *lp, int reg,
* Use a DMA for RX and TX packets.
*/
#include <linux/dma-mapping.h>
-#include <mach/dma.h>

static dma_addr_t rx_dmabuf, tx_dmabuf;
static int rx_dmalen, tx_dmalen;
--
1.6.0.6


2009-07-08 16:05:18

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 27/44] includecheck fix: drivers/scsi, libfcoe.c


fix the following 'make includecheck' warning:

drivers/scsi/fcoe/libfcoe.c: linux/netdevice.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
drivers/scsi/fcoe/libfcoe.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/fcoe/libfcoe.c b/drivers/scsi/fcoe/libfcoe.c
index f544340..c7d8ca4 100644
--- a/drivers/scsi/fcoe/libfcoe.c
+++ b/drivers/scsi/fcoe/libfcoe.c
@@ -29,7 +29,6 @@
#include <linux/ethtool.h>
#include <linux/if_ether.h>
#include <linux/if_vlan.h>
-#include <linux/netdevice.h>
#include <linux/errno.h>
#include <linux/bitops.h>
#include <net/rtnetlink.h>
--
1.6.0.6


2009-07-08 16:05:41

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 30/44] includecheck fix: drivers/staging, usbdrv.c


fix the following 'make includecheck' warning:

drivers/staging/otus/usbdrv.c: net/iw_handler.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
drivers/staging/otus/usbdrv.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/otus/usbdrv.c b/drivers/staging/otus/usbdrv.c
index 540cbbb..ec98518 100644
--- a/drivers/staging/otus/usbdrv.c
+++ b/drivers/staging/otus/usbdrv.c
@@ -113,9 +113,6 @@ extern u8_t zfLnxCreateThread(zdev_t *dev);

/* Definition of Wireless Extension */

-#if WIRELESS_EXT > 12
-#include <net/iw_handler.h>
-#endif
//wireless extension helper functions
extern int usbdrv_ioctl_setessid(struct net_device *dev, struct iw_point *erq);
extern int usbdrv_ioctl_setrts(struct net_device *dev, struct iw_param *rrq);
--
1.6.0.6


2009-07-08 16:05:54

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 32/44] includecheck fix: drivers/video, vgacon.c


fix the following 'make includecheck' warning:

drivers/video/console/vgacon.c: linux/slab.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
drivers/video/console/vgacon.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/video/console/vgacon.c b/drivers/video/console/vgacon.c
index 59d7d5e..74e96cf 100644
--- a/drivers/video/console/vgacon.c
+++ b/drivers/video/console/vgacon.c
@@ -180,7 +180,6 @@ static inline void vga_set_mem_top(struct vc_data *c)
}

#ifdef CONFIG_VGACON_SOFT_SCROLLBACK
-#include <linux/slab.h>
/* software scrollback */
static void *vgacon_scrollback;
static int vgacon_scrollback_tail;
--
1.6.0.6


2009-07-08 16:06:47

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 29/44] includecheck fix: drivers/spi, amba-pl022.c


fix the following 'make includecheck' warnings:

drivers/spi/amba-pl022.c: linux/delay.h is included more than once.
drivers/spi/amba-pl022.c: linux/errno.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
drivers/spi/amba-pl022.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/amba-pl022.c b/drivers/spi/amba-pl022.c
index da76797..c0f950a 100644
--- a/drivers/spi/amba-pl022.c
+++ b/drivers/spi/amba-pl022.c
@@ -38,14 +38,12 @@
#include <linux/interrupt.h>
#include <linux/spi/spi.h>
#include <linux/workqueue.h>
-#include <linux/errno.h>
#include <linux/delay.h>
#include <linux/clk.h>
#include <linux/err.h>
#include <linux/amba/bus.h>
#include <linux/amba/pl022.h>
#include <linux/io.h>
-#include <linux/delay.h>

/*
* This macro is used to define some register default values.
--
1.6.0.6


2009-07-08 16:07:01

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 34/44] includecheck fix: fs/xfs, xfs_iops.c


fix the following 'make includecheck' warning:

fs/xfs/linux-2.6/xfs_iops.c: xfs_acl.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
fs/xfs/linux-2.6/xfs_iops.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/fs/xfs/linux-2.6/xfs_iops.c b/fs/xfs/linux-2.6/xfs_iops.c
index 58973bb..793a146 100644
--- a/fs/xfs/linux-2.6/xfs_iops.c
+++ b/fs/xfs/linux-2.6/xfs_iops.c
@@ -43,7 +43,6 @@
#include "xfs_error.h"
#include "xfs_itable.h"
#include "xfs_rw.h"
-#include "xfs_acl.h"
#include "xfs_attr.h"
#include "xfs_buf_item.h"
#include "xfs_utils.h"
--
1.6.0.6


2009-07-08 16:06:34

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 33/44] includecheck fix: drivers/xen, evtchn.c


fix the following 'make includecheck' warning:

drivers/xen/evtchn.c: linux/errno.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
drivers/xen/evtchn.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/xen/evtchn.c b/drivers/xen/evtchn.c
index af03195..79bedba 100644
--- a/drivers/xen/evtchn.c
+++ b/drivers/xen/evtchn.c
@@ -38,7 +38,6 @@
#include <linux/string.h>
#include <linux/errno.h>
#include <linux/fs.h>
-#include <linux/errno.h>
#include <linux/miscdevice.h>
#include <linux/major.h>
#include <linux/proc_fs.h>
--
1.6.0.6


2009-07-08 16:06:14

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 31/44] includecheck fix: drivers/staging, rt_linux.h


fix the following 'make includecheck' warning:

drivers/staging/rt2860/rt_linux.h: linux/wireless.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
drivers/staging/rt2860/rt_linux.h | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rt2860/rt_linux.h b/drivers/staging/rt2860/rt_linux.h
index 85175c1..ed75673 100644
--- a/drivers/staging/rt2860/rt_linux.h
+++ b/drivers/staging/rt2860/rt_linux.h
@@ -66,10 +66,6 @@
#include <linux/ctype.h>
#include <linux/vmalloc.h>

-
-#ifdef RT30xx
-#include <linux/wireless.h>
-#endif
#include <net/iw_handler.h>

// load firmware
--
1.6.0.6


2009-07-08 16:07:28

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 35/44] includecheck fix: include/acpi, acpi_bus.h


fix the following 'make includecheck' warning:

include/acpi/acpi_bus.h: linux/device.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
include/acpi/acpi_bus.h | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h
index c65e4ce..2d8f6ef 100644
--- a/include/acpi/acpi_bus.h
+++ b/include/acpi/acpi_bus.h
@@ -356,7 +356,6 @@ void acpi_remove_dir(struct acpi_device *);
/*
* Bind physical devices with ACPI devices
*/
-#include <linux/device.h>
struct acpi_bus_type {
struct list_head list;
struct bus_type *bus;
--
1.6.0.6


2009-07-08 16:07:47

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 37/44] includecheck fix: include/linux, aio.h


fix the following 'make includecheck' warning:

include/linux/aio.h: linux/aio_abi.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
include/linux/aio.h | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/include/linux/aio.h b/include/linux/aio.h
index 47f7d93..aea219d 100644
--- a/include/linux/aio.h
+++ b/include/linux/aio.h
@@ -225,8 +225,6 @@ static inline void exit_aio(struct mm_struct *mm) { }

#define io_wait_to_kiocb(wait) container_of(wait, struct kiocb, ki_wait)

-#include <linux/aio_abi.h>
-
static inline struct kiocb *list_kiocb(struct list_head *h)
{
return list_entry(h, struct kiocb, ki_list);
--
1.6.0.6


2009-07-08 16:07:59

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 36/44] includecheck fix: include/drm, drm_memory.h

fix the following 'make includecheck' warning:

include/drm/drm_memory.h: linux/vmalloc.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
include/drm/drm_memory.h | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/include/drm/drm_memory.h b/include/drm/drm_memory.h
index 63e425b..15af9b3 100644
--- a/include/drm/drm_memory.h
+++ b/include/drm/drm_memory.h
@@ -44,8 +44,6 @@

#if __OS_HAS_AGP

-#include <linux/vmalloc.h>
-
#ifdef HAVE_PAGE_AGP
#include <asm/agp.h>
#else
--
1.6.0.6


2009-07-08 16:08:22

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 39/44] includecheck fix: include/linux, icmpv6.h


fix the following 'make includecheck' warning:

include/linux/icmpv6.h: linux/skbuff.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
include/linux/icmpv6.h | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/include/linux/icmpv6.h b/include/linux/icmpv6.h
index b6a8518..c0d8357 100644
--- a/include/linux/icmpv6.h
+++ b/include/linux/icmpv6.h
@@ -171,8 +171,6 @@ struct icmp6_filter {
#ifdef __KERNEL__

#include <linux/netdevice.h>
-#include <linux/skbuff.h>
-

extern void icmpv6_send(struct sk_buff *skb,
u8 type, u8 code,
--
1.6.0.6


2009-07-08 16:08:46

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 38/44] includecheck fix: include/linux, ftrace.h


fix the following 'make includecheck' warning:

include/linux/ftrace.h: linux/sched.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
include/linux/ftrace.h | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h
index dc3b132..3c0924a 100644
--- a/include/linux/ftrace.h
+++ b/include/linux/ftrace.h
@@ -446,7 +446,6 @@ static inline void unpause_graph_tracing(void) { }
#endif /* CONFIG_FUNCTION_GRAPH_TRACER */

#ifdef CONFIG_TRACING
-#include <linux/sched.h>

/* flags for current->trace */
enum {
--
1.6.0.6


2009-07-08 16:09:21

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 40/44] includecheck fix: include/linux, net_dropmon.h


fix the following 'make includecheck' warning:

include/linux/net_dropmon.h: linux/types.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
include/linux/net_dropmon.h | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/include/linux/net_dropmon.h b/include/linux/net_dropmon.h
index 3ceb0cc..2a73946 100644
--- a/include/linux/net_dropmon.h
+++ b/include/linux/net_dropmon.h
@@ -3,7 +3,6 @@

#include <linux/types.h>
#include <linux/netlink.h>
-#include <linux/types.h>

struct net_dm_drop_point {
__u8 pc[8];
--
1.6.0.6


2009-07-08 16:10:24

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 44/44] includecheck fix: mm, shmem.c


fix the following 'make includecheck' warning:

mm/shmem.c: linux/vfs.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
mm/shmem.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/mm/shmem.c b/mm/shmem.c
index d713239..34e56aa 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -49,7 +49,6 @@ static struct vfsmount *shm_mnt;
#include <linux/backing-dev.h>
#include <linux/shmem_fs.h>
#include <linux/writeback.h>
-#include <linux/vfs.h>
#include <linux/blkdev.h>
#include <linux/security.h>
#include <linux/swapops.h>
--
1.6.0.6


2009-07-08 16:09:45

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 42/44] includecheck fix: kernel/trace, ring_buffer.c


fix the following 'make includecheck' warning:

kernel/trace/ring_buffer.c: trace.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
kernel/trace/ring_buffer.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
index bf27bb7..636cee9 100644
--- a/kernel/trace/ring_buffer.c
+++ b/kernel/trace/ring_buffer.c
@@ -201,8 +201,6 @@ int tracing_is_on(void)
}
EXPORT_SYMBOL_GPL(tracing_is_on);

-#include "trace.h"
-
#define RB_EVNT_HDR_SIZE (offsetof(struct ring_buffer_event, array))
#define RB_ALIGNMENT 4U
#define RB_MAX_SMALL_DATA (RB_ALIGNMENT * RINGBUF_TYPE_DATA_TYPE_LEN_MAX)
--
1.6.0.6


2009-07-08 16:10:44

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 16/44] includecheck fix: s390, sys_s390.c


fix the following 'make includecheck' warning:

arch/s390/kernel/sys_s390.c: linux/syscalls.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
arch/s390/kernel/sys_s390.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/s390/kernel/sys_s390.c b/arch/s390/kernel/sys_s390.c
index c7ae4b1..e9d94f6 100644
--- a/arch/s390/kernel/sys_s390.c
+++ b/arch/s390/kernel/sys_s390.c
@@ -29,7 +29,6 @@
#include <linux/personality.h>
#include <linux/unistd.h>
#include <linux/ipc.h>
-#include <linux/syscalls.h>
#include <asm/uaccess.h>
#include "entry.h"

--
1.6.0.6


2009-07-08 16:10:57

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 43/44] includecheck fix: mm, nommu.c


fix the following 'make includecheck' warning:

mm/nommu.c: internal.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
mm/nommu.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/mm/nommu.c b/mm/nommu.c
index 53cab10..e1ae0f9 100644
--- a/mm/nommu.c
+++ b/mm/nommu.c
@@ -56,8 +56,6 @@ void no_printk(const char *fmt, ...)
no_printk(KERN_DEBUG FMT"\n", ##__VA_ARGS__)
#endif

-#include "internal.h"
-
void *high_memory;
struct page *mem_map;
unsigned long max_mapnr;
--
1.6.0.6


2009-07-08 16:11:43

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [PATCH 41/44] includecheck fix: include/linux, rfkill.h


fix the following 'make includecheck' warning:

include/linux/rfkill.h: linux/types.h is included more than once.

Signed-off-by: Jaswinder Singh Rajput <[email protected]>
---
include/linux/rfkill.h | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
index e73e242..2ce2983 100644
--- a/include/linux/rfkill.h
+++ b/include/linux/rfkill.h
@@ -99,7 +99,6 @@ enum rfkill_user_states {
#undef RFKILL_STATE_UNBLOCKED
#undef RFKILL_STATE_HARD_BLOCKED

-#include <linux/types.h>
#include <linux/kernel.h>
#include <linux/list.h>
#include <linux/mutex.h>
--
1.6.0.6


2009-07-08 16:19:55

by Randy Dunlap

[permalink] [raw]
Subject: Re: [PATCH 21/44] includecheck fix: Documentation, cfag12864b-example.c

On Wed, 08 Jul 2009 20:32:49 +0530 Jaswinder Singh Rajput wrote:

>
> fix the following 'make includecheck' warning:
>
> Documentation/auxdisplay/cfag12864b-example.c: string.h is included more than once.
>
> Signed-off-by: Jaswinder Singh Rajput <[email protected]>

Acked-by: Randy Dunlap <[email protected]>


> ---
> Documentation/auxdisplay/cfag12864b-example.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/Documentation/auxdisplay/cfag12864b-example.c b/Documentation/auxdisplay/cfag12864b-example.c
> index 2caeea5..156bcaa 100644
> --- a/Documentation/auxdisplay/cfag12864b-example.c
> +++ b/Documentation/auxdisplay/cfag12864b-example.c
> @@ -194,7 +194,6 @@ void cfag12864b_blit(void)
> */
>
> #include <stdio.h>
> -#include <string.h>
>
> #define EXAMPLES 6
>
> --


---
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/

2009-07-08 16:50:54

by Jeremy Fitzhardinge

[permalink] [raw]
Subject: Re: [PATCH 33/44] includecheck fix: drivers/xen, evtchn.c

On 07/08/09 08:42, Jaswinder Singh Rajput wrote:
> fix the following 'make includecheck' warning:
>
> drivers/xen/evtchn.c: linux/errno.h is included more than once.
>
> Signed-off-by: Jaswinder Singh Rajput <[email protected]>
>
Acked-by: Jeremy Fitzhardinge <[email protected]>

Thanks,
J

> ---
> drivers/xen/evtchn.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/xen/evtchn.c b/drivers/xen/evtchn.c
> index af03195..79bedba 100644
> --- a/drivers/xen/evtchn.c
> +++ b/drivers/xen/evtchn.c
> @@ -38,7 +38,6 @@
> #include <linux/string.h>
> #include <linux/errno.h>
> #include <linux/fs.h>
> -#include <linux/errno.h>
> #include <linux/miscdevice.h>
> #include <linux/major.h>
> #include <linux/proc_fs.h>
>

2009-07-08 17:28:17

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH 29/44] includecheck fix: drivers/spi, amba-pl022.c

2009/7/8 Jaswinder Singh Rajput <[email protected]>:

> fix the following 'make includecheck' warnings:
>
> ?drivers/spi/amba-pl022.c: linux/delay.h is included more than once.
> ?drivers/spi/amba-pl022.c: linux/errno.h is included more than once.

Acked-by: Linus Walleij <[email protected]>

David are you merging this?

Linus Walleij

2009-07-08 17:39:52

by David Brownell

[permalink] [raw]
Subject: Re: [PATCH 29/44] includecheck fix: drivers/spi, amba-pl022.c

On Wednesday 08 July 2009, Jaswinder Singh Rajput wrote:
>
> fix the following 'make includecheck' warnings:
>
> drivers/spi/amba-pl022.c: linux/delay.h is included more than once.
> drivers/spi/amba-pl022.c: linux/errno.h is included more than once.
>
> Signed-off-by: Jaswinder Singh Rajput <[email protected]>

Acked-by: David Brownell <[email protected]>


> ---
> drivers/spi/amba-pl022.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/spi/amba-pl022.c b/drivers/spi/amba-pl022.c
> index da76797..c0f950a 100644
> --- a/drivers/spi/amba-pl022.c
> +++ b/drivers/spi/amba-pl022.c
> @@ -38,14 +38,12 @@
> #include <linux/interrupt.h>
> #include <linux/spi/spi.h>
> #include <linux/workqueue.h>
> -#include <linux/errno.h>
> #include <linux/delay.h>
> #include <linux/clk.h>
> #include <linux/err.h>
> #include <linux/amba/bus.h>
> #include <linux/amba/pl022.h>
> #include <linux/io.h>
> -#include <linux/delay.h>
>
> /*
> * This macro is used to define some register default values.
> --
> 1.6.0.6
>
>
>
>

2009-07-08 17:44:36

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: Re: [PATCH 29/44] includecheck fix: drivers/spi, amba-pl022.c

On Wed, 2009-07-08 at 19:28 +0200, Linus Walleij wrote:
> 2009/7/8 Jaswinder Singh Rajput <[email protected]>:
>
> > fix the following 'make includecheck' warnings:
> >
> > drivers/spi/amba-pl022.c: linux/delay.h is included more than once.
> > drivers/spi/amba-pl022.c: linux/errno.h is included more than once.
>
> Acked-by: Linus Walleij <[email protected]>
>
> David are you merging this?
>

This is a big patchset, So better me or Sam will send this to Linus
after collecting some more ACKs.

Thanks,
--
JSR

2009-07-08 18:03:56

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: Re: [PATCH 0/44] includecheck: fix multiple includes

Hello all,

On Wed, 2009-07-08 at 19:58 +0530, Jaswinder Singh Rajput wrote:
> The following changes since commit faf80d62e44dc627efb741f48db50c1858d1667c:
> Linus Torvalds (1):
> Merge branch 'x86-fixes-for-linus' of git://git.kernel.org/.../tip/linux-2.6-tip
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/headers-check-2.6.git master
>
> Jaswinder Singh Rajput (44):

This is a big patchset, so it will be better that either me or Sam will
send it to Linus after collecting ACKs.

So far I received ACKs for:

includecheck fix: Documentation, cfag12864b-example.c
Acked-by: Randy Dunlap <[email protected]>

includecheck fix: drivers/spi, amba-pl022.c
Acked-by: Linus Walleij <[email protected]>
Acked-by: David Brownell <[email protected]>

includecheck fix: drivers/xen, evtchn.c
Acked-by: Jeremy Fitzhardinge <[email protected]>

includecheck fix: include/acpi, acpi_bus.h
Acked-by: Len Brown <[email protected]>

I am still waiting ACK/NAK for :

includecheck fix: arm, misc.c
includecheck fix: arm, atomic.h
includecheck fix: arm, board-dm355-evm.c
includecheck fix: arm, board-dm355-leopard.c
includecheck fix: arm, board-dm644x-evm.c
includecheck fix: arm, board-dm646x-evm.c
includecheck fix: arm, board-sffsdr.c
includecheck fix: arm, mach-mx3/devices.c
includecheck fix: arm, mach-omap1/mcbsp.c
includecheck fix: arm, mach-omap2/mcbsp.c
includecheck fix: arm, plat-s3c64xx/pm.c
includecheck fix: arm, plat-stmp3xxx/pinmux.c

includecheck fix: mn10300, sys_mn10300.c

includecheck fix: powerpc, mpc7450-pmu.c
includecheck fix: powerpc, ppc970-pmu.c

includecheck fix: s390, sys_s390.c

includecheck fix: um, helper.c

includecheck fix: x86, dumpstack.c
includecheck fix: x86, traps.c
includecheck fix: x86, shadow.c

includecheck fix: drivers/char, vt.c

includecheck fix: drivers/net, sja1000.c
includecheck fix: drivers/net, axnet_cs.c
includecheck fix: drivers/net, smc911x.h

includecheck fix: drivers/parisc, ccio-dma.c

includecheck fix: drivers/scsi, libfcoe.c
includecheck fix: drivers/scsi, ibmvscsi.c

includecheck fix: drivers/staging, usbdrv.c
includecheck fix: drivers/staging, rt_linux.h

includecheck fix: drivers/video, vgacon.c

includecheck fix: fs/xfs, xfs_iops.c

includecheck fix: include/drm, drm_memory.h

includecheck fix: include/linux, aio.h

includecheck fix: include/linux, ftrace.h

includecheck fix: include/linux, icmpv6.h
includecheck fix: include/linux, net_dropmon.h

includecheck fix: include/linux, rfkill.h

includecheck fix: kernel/trace, ring_buffer.c

includecheck fix: mm, nommu.c
includecheck fix: mm, shmem.c

Thanks,
--
JSR

2009-07-08 19:32:45

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [PATCH 41/44] includecheck fix: include/linux, rfkill.h

Hi Jaswinder,

> fix the following 'make includecheck' warning:
>
> include/linux/rfkill.h: linux/types.h is included more than once.
>
> Signed-off-by: Jaswinder Singh Rajput <[email protected]>
> ---
> include/linux/rfkill.h | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
> index e73e242..2ce2983 100644
> --- a/include/linux/rfkill.h
> +++ b/include/linux/rfkill.h
> @@ -99,7 +99,6 @@ enum rfkill_user_states {
> #undef RFKILL_STATE_UNBLOCKED
> #undef RFKILL_STATE_HARD_BLOCKED
>
> -#include <linux/types.h>
> #include <linux/kernel.h>
> #include <linux/list.h>
> #include <linux/mutex.h>

with the #ifdef __KERNEL__ in between it is kinda weird, but patch seems
correct.

Regards

Marcel

2009-07-08 21:16:29

by Russell King

[permalink] [raw]
Subject: Re: [PATCH 0/44] includecheck: fix multiple includes

On Wed, Jul 08, 2009 at 11:30:59PM +0530, Jaswinder Singh Rajput wrote:
> I am still waiting ACK/NAK for :
>
> includecheck fix: arm, misc.c
> includecheck fix: arm, atomic.h
> includecheck fix: arm, board-dm355-evm.c
> includecheck fix: arm, board-dm355-leopard.c
> includecheck fix: arm, board-dm644x-evm.c
> includecheck fix: arm, board-dm646x-evm.c
> includecheck fix: arm, board-sffsdr.c
> includecheck fix: arm, mach-mx3/devices.c
> includecheck fix: arm, mach-omap1/mcbsp.c
> includecheck fix: arm, mach-omap2/mcbsp.c
> includecheck fix: arm, plat-s3c64xx/pm.c
> includecheck fix: arm, plat-stmp3xxx/pinmux.c

You're still waiting because apparantly you never sent this set anywhere
near any ARM people before.

For the first two, I'll ack them:

Acked-by: Russell King <[email protected]>

The remainder look sane to me, but you'll have to seek acks from the
individual platform maintainer(s).

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:

2009-07-09 00:04:43

by Dave Airlie

[permalink] [raw]
Subject: Re: [PATCH 36/44] includecheck fix: include/drm, drm_memory.h


> fix the following 'make includecheck' warning:
>
> include/drm/drm_memory.h: linux/vmalloc.h is included more than once.
>
> Signed-off-by: Jaswinder Singh Rajput <[email protected]>

Acked-by: Dave Airlie <[email protected]>

Dave.
> ---
> include/drm/drm_memory.h | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/include/drm/drm_memory.h b/include/drm/drm_memory.h
> index 63e425b..15af9b3 100644
> --- a/include/drm/drm_memory.h
> +++ b/include/drm/drm_memory.h
> @@ -44,8 +44,6 @@
>
> #if __OS_HAS_AGP
>
> -#include <linux/vmalloc.h>
> -
> #ifdef HAVE_PAGE_AGP
> #include <asm/agp.h>
> #else
>

2009-07-09 04:03:57

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: Re: [PATCH 41/44] includecheck fix: include/linux, rfkill.h

Hello Marcel,

On Wed, 2009-07-08 at 12:32 -0700, Marcel Holtmann wrote:
> Hi Jaswinder,
>
> > fix the following 'make includecheck' warning:
> >
> > include/linux/rfkill.h: linux/types.h is included more than once.
> >
> > Signed-off-by: Jaswinder Singh Rajput <[email protected]>
> > ---
> > include/linux/rfkill.h | 1 -
> > 1 files changed, 0 insertions(+), 1 deletions(-)
> >
> > diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
> > index e73e242..2ce2983 100644
> > --- a/include/linux/rfkill.h
> > +++ b/include/linux/rfkill.h
> > @@ -99,7 +99,6 @@ enum rfkill_user_states {
> > #undef RFKILL_STATE_UNBLOCKED
> > #undef RFKILL_STATE_HARD_BLOCKED
> >
> > -#include <linux/types.h>
> > #include <linux/kernel.h>
> > #include <linux/list.h>
> > #include <linux/mutex.h>
>
> with the #ifdef __KERNEL__ in between it is kinda weird, but patch seems
> correct.
>

ACK or Reviewed-by ?

Thanks,
--
JSR

2009-07-09 04:30:37

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: Re: [PATCH 0/44] includecheck: fix multiple includes

On Wed, 2009-07-08 at 22:13 +0100, Russell King wrote:
> On Wed, Jul 08, 2009 at 11:30:59PM +0530, Jaswinder Singh Rajput wrote:
> > I am still waiting ACK/NAK for :
> >
> > includecheck fix: arm, misc.c
> > includecheck fix: arm, atomic.h
> > includecheck fix: arm, board-dm355-evm.c
> > includecheck fix: arm, board-dm355-leopard.c
> > includecheck fix: arm, board-dm644x-evm.c
> > includecheck fix: arm, board-dm646x-evm.c
> > includecheck fix: arm, board-sffsdr.c
> > includecheck fix: arm, mach-mx3/devices.c
> > includecheck fix: arm, mach-omap1/mcbsp.c
> > includecheck fix: arm, mach-omap2/mcbsp.c
> > includecheck fix: arm, plat-s3c64xx/pm.c
> > includecheck fix: arm, plat-stmp3xxx/pinmux.c
>
> You're still waiting because apparantly you never sent this set anywhere
> near any ARM people before.
>
> For the first two, I'll ack them:
>
> Acked-by: Russell King <[email protected]>
>
> The remainder look sane to me, but you'll have to seek acks from the
> individual platform maintainer(s).
>

OK, adding some more ARM people and ARM lists to get remaining ACK/NAK.

Patches are already posted to LKML and also available at :

http://git.kernel.org/?p=linux/kernel/git/jaswinder/headers-check-2.6.git;a=summary

In case if you are not able to find these patches let me know.

Thanks,
--
JSR

2009-07-09 05:47:49

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [PATCH 41/44] includecheck fix: include/linux, rfkill.h

Hi Jaswinder,

> > > fix the following 'make includecheck' warning:
> > >
> > > include/linux/rfkill.h: linux/types.h is included more than once.
> > >
> > > Signed-off-by: Jaswinder Singh Rajput <[email protected]>
> > > ---
> > > include/linux/rfkill.h | 1 -
> > > 1 files changed, 0 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
> > > index e73e242..2ce2983 100644
> > > --- a/include/linux/rfkill.h
> > > +++ b/include/linux/rfkill.h
> > > @@ -99,7 +99,6 @@ enum rfkill_user_states {
> > > #undef RFKILL_STATE_UNBLOCKED
> > > #undef RFKILL_STATE_HARD_BLOCKED
> > >
> > > -#include <linux/types.h>
> > > #include <linux/kernel.h>
> > > #include <linux/list.h>
> > > #include <linux/mutex.h>
> >
> > with the #ifdef __KERNEL__ in between it is kinda weird, but patch seems
> > correct.
> >
>
> ACK or Reviewed-by ?

both if you want to, but John already picked it up for wireless-testing
if I am not mistaken. So it is on its way into 2.6.32 somehow.

Regards

Marcel

2009-07-09 11:34:51

by dmitry pervushin

[permalink] [raw]
Subject: Re: [PATCH 0/44] includecheck: fix multiple includes

On Thu, 2009-07-09 at 09:58 +0530, Jaswinder Singh Rajput wrote:
> On Wed, 2009-07-08 at 22:13 +0100, Russell King wrote:
> > On Wed, Jul 08, 2009 at 11:30:59PM +0530, Jaswinder Singh Rajput wrote:
> > > I am still waiting ACK/NAK for :
for this:
> > > includecheck fix: arm, plat-stmp3xxx/pinmux.c
Acked-by: dmitry pervushin <[email protected]>
> >
> > You're still waiting because apparantly you never sent this set anywhere
> > near any ARM people before.
> >
> > For the first two, I'll ack them:
> >
> > Acked-by: Russell King <[email protected]>
> >
> > The remainder look sane to me, but you'll have to seek acks from the
> > individual platform maintainer(s).
> >
>
> OK, adding some more ARM people and ARM lists to get remaining ACK/NAK.
>
> Patches are already posted to LKML and also available at :
>
> http://git.kernel.org/?p=linux/kernel/git/jaswinder/headers-check-2.6.git;a=summary
>
> In case if you are not able to find these patches let me know.
>
> Thanks,
> --
> JSR
>
>

2009-07-09 14:18:20

by Kevin Hilman

[permalink] [raw]
Subject: Re: [PATCH 3/44] includecheck fix: arm, board-dm355-evm.c

Jaswinder Singh Rajput <[email protected]> writes:

> fix the following 'make includecheck' warning:
>
> arch/arm/mach-davinci/board-dm355-evm.c: mach/common.h is included more than once.
>
> Signed-off-by: Jaswinder Singh Rajput <[email protected]>

Acked-by: Kevin Hilman <[email protected]>

> ---
> arch/arm/mach-davinci/board-dm355-evm.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-davinci/board-dm355-evm.c b/arch/arm/mach-davinci/board-dm355-evm.c
> index 5ac2f56..d6ab64c 100644
> --- a/arch/arm/mach-davinci/board-dm355-evm.c
> +++ b/arch/arm/mach-davinci/board-dm355-evm.c
> @@ -37,7 +37,6 @@
> #include <mach/serial.h>
> #include <mach/nand.h>
> #include <mach/mmc.h>
> -#include <mach/common.h>
>
> #define DAVINCI_ASYNC_EMIF_CONTROL_BASE 0x01e10000
> #define DAVINCI_ASYNC_EMIF_DATA_CE0_BASE 0x02000000
> --
> 1.6.0.6

2009-07-09 14:18:35

by Kevin Hilman

[permalink] [raw]
Subject: Re: [PATCH 4/44] includecheck fix: arm, board-dm355-leopard.c

Jaswinder Singh Rajput <[email protected]> writes:

> fix the following 'make includecheck' warning:
>
> arch/arm/mach-davinci/board-dm355-leopard.c: mach/common.h is included more than once.
>
> Signed-off-by: Jaswinder Singh Rajput <[email protected]>

Acked-by: Kevin Hilman <[email protected]>

> ---
> arch/arm/mach-davinci/board-dm355-leopard.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-davinci/board-dm355-leopard.c b/arch/arm/mach-davinci/board-dm355-leopard.c
> index 28c9008..84ad5d1 100644
> --- a/arch/arm/mach-davinci/board-dm355-leopard.c
> +++ b/arch/arm/mach-davinci/board-dm355-leopard.c
> @@ -36,7 +36,6 @@
> #include <mach/serial.h>
> #include <mach/nand.h>
> #include <mach/mmc.h>
> -#include <mach/common.h>
>
> #define DAVINCI_ASYNC_EMIF_CONTROL_BASE 0x01e10000
> #define DAVINCI_ASYNC_EMIF_DATA_CE0_BASE 0x02000000
> --
> 1.6.0.6

2009-07-09 14:27:46

by Kevin Hilman

[permalink] [raw]
Subject: Re: [PATCH 5/44] includecheck fix: arm, board-dm644x-evm.c

Jaswinder Singh Rajput <[email protected]> writes:

> fix the following 'make includecheck' warning:
>
> arch/arm/mach-davinci/board-dm644x-evm.c: mach/common.h is included more than once.
>
> Signed-off-by: Jaswinder Singh Rajput <[email protected]>

Acked-by: Kevin Hilman <[email protected]>

> ---
> arch/arm/mach-davinci/board-dm644x-evm.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-davinci/board-dm644x-evm.c b/arch/arm/mach-davinci/board-dm644x-evm.c
> index d9d4045..56c8cd0 100644
> --- a/arch/arm/mach-davinci/board-dm644x-evm.c
> +++ b/arch/arm/mach-davinci/board-dm644x-evm.c
> @@ -45,7 +45,6 @@
> #include <mach/nand.h>
> #include <mach/mmc.h>
> #include <mach/emac.h>
> -#include <mach/common.h>
>
> #define DM644X_EVM_PHY_MASK (0x2)
> #define DM644X_EVM_MDIO_FREQUENCY (2200000) /* PHY bus frequency */
> --
> 1.6.0.6

2009-07-09 14:28:09

by Kevin Hilman

[permalink] [raw]
Subject: Re: [PATCH 6/44] includecheck fix: arm, board-dm646x-evm.c

Jaswinder Singh Rajput <[email protected]> writes:

> fix the following 'make includecheck' warning:
>
> arch/arm/mach-davinci/board-dm646x-evm.c: mach/common.h is included more than once.
>
> Signed-off-by: Jaswinder Singh Rajput <[email protected]>

Acked-by: Kevin Hilman <[email protected]>

> ---
> arch/arm/mach-davinci/board-dm646x-evm.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-davinci/board-dm646x-evm.c b/arch/arm/mach-davinci/board-dm646x-evm.c
> index e17de63..8657e72 100644
> --- a/arch/arm/mach-davinci/board-dm646x-evm.c
> +++ b/arch/arm/mach-davinci/board-dm646x-evm.c
> @@ -47,7 +47,6 @@
> #include <mach/i2c.h>
> #include <mach/mmc.h>
> #include <mach/emac.h>
> -#include <mach/common.h>
>
> #define DM646X_EVM_PHY_MASK (0x2)
> #define DM646X_EVM_MDIO_FREQUENCY (2200000) /* PHY bus frequency */
> --
> 1.6.0.6

2009-07-09 14:28:42

by Kevin Hilman

[permalink] [raw]
Subject: Re: [PATCH 7/44] includecheck fix: arm, board-sffsdr.c

Jaswinder Singh Rajput <[email protected]> writes:

> fix the following 'make includecheck' warning:
>
> arch/arm/mach-davinci/board-sffsdr.c: mach/common.h is included more than once.
>
> Signed-off-by: Jaswinder Singh Rajput <[email protected]>

Acked-by: Kevin Hilman <[email protected]>

> ---
> arch/arm/mach-davinci/board-sffsdr.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-davinci/board-sffsdr.c b/arch/arm/mach-davinci/board-sffsdr.c
> index 748a8e4..7acdfd8 100644
> --- a/arch/arm/mach-davinci/board-sffsdr.c
> +++ b/arch/arm/mach-davinci/board-sffsdr.c
> @@ -52,7 +52,6 @@
> #include <mach/serial.h>
> #include <mach/psc.h>
> #include <mach/mux.h>
> -#include <mach/common.h>
>
> #define SFFSDR_PHY_MASK (0x2)
> #define SFFSDR_MDIO_FREQUENCY (2200000) /* PHY bus frequency */
> --
> 1.6.0.6

2009-07-09 14:30:13

by Kevin Hilman

[permalink] [raw]
Subject: Re: [PATCH 9/44] includecheck fix: arm, mach-omap1/mcbsp.c

Jaswinder Singh Rajput <[email protected]> writes:

> fix the following 'make includecheck' warning:
>
> arch/arm/mach-omap1/mcbsp.c: mach/irqs.h is included more than once.
>
> Signed-off-by: Jaswinder Singh Rajput <[email protected]>

Tony's on vacation, so I'll ack these minor OMAP changes on his
behalf.

Acked-by: Kevin Hilman <[email protected]>


> ---
> arch/arm/mach-omap1/mcbsp.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap1/mcbsp.c b/arch/arm/mach-omap1/mcbsp.c
> index a2d7814..505d98c 100644
> --- a/arch/arm/mach-omap1/mcbsp.c
> +++ b/arch/arm/mach-omap1/mcbsp.c
> @@ -19,7 +19,6 @@
>
> #include <mach/irqs.h>
> #include <mach/dma.h>
> -#include <mach/irqs.h>
> #include <mach/mux.h>
> #include <mach/cpu.h>
> #include <mach/mcbsp.h>
> --
> 1.6.0.6

2009-07-09 14:30:31

by Kevin Hilman

[permalink] [raw]
Subject: Re: [PATCH 10/44] includecheck fix: arm, mach-omap2/mcbsp.c

Jaswinder Singh Rajput <[email protected]> writes:

> fix the following 'make includecheck' warning:
>
> arch/arm/mach-omap2/mcbsp.c: mach/irqs.h is included more than once.
>
> Signed-off-by: Jaswinder Singh Rajput <[email protected]>

Acked-by: Kevin Hilman <[email protected]>

> ---
> arch/arm/mach-omap2/mcbsp.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/mcbsp.c b/arch/arm/mach-omap2/mcbsp.c
> index a5c0f04..99b6e15 100644
> --- a/arch/arm/mach-omap2/mcbsp.c
> +++ b/arch/arm/mach-omap2/mcbsp.c
> @@ -19,7 +19,6 @@
>
> #include <mach/irqs.h>
> #include <mach/dma.h>
> -#include <mach/irqs.h>
> #include <mach/mux.h>
> #include <mach/cpu.h>
> #include <mach/mcbsp.h>
> --
> 1.6.0.6

2009-07-09 14:53:01

by Olaf Weber

[permalink] [raw]
Subject: Re: [PATCH 34/44] includecheck fix: fs/xfs, xfs_iops.c

Jaswinder Singh Rajput writes:

> fix the following 'make includecheck' warning:

> fs/xfs/linux-2.6/xfs_iops.c: xfs_acl.h is included more than once.

> Signed-off-by: Jaswinder Singh Rajput <[email protected]>

Acked-By: Olaf Weber <[email protected]>



> ---
> fs/xfs/linux-2.6/xfs_iops.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)

> diff --git a/fs/xfs/linux-2.6/xfs_iops.c b/fs/xfs/linux-2.6/xfs_iops.c
> index 58973bb..793a146 100644
> --- a/fs/xfs/linux-2.6/xfs_iops.c
> +++ b/fs/xfs/linux-2.6/xfs_iops.c
> @@ -43,7 +43,6 @@
> #include "xfs_error.h"
> #include "xfs_itable.h"
> #include "xfs_rw.h"
> -#include "xfs_acl.h"
> #include "xfs_attr.h"
> #include "xfs_buf_item.h"
> #include "xfs_utils.h"
> --
> 1.6.0.6

--
Olaf Weber SGI Phone: +31(0)30-6696752
Veldzigt 2b Fax: +31(0)30-6696799
Technical Lead 3454 PW de Meern Vnet: 955-7151
Storage Software The Netherlands Email: [email protected]

2009-07-09 16:28:20

by Cyrill Gorcunov

[permalink] [raw]
Subject: Re: [PATCH 20/44] includecheck fix: x86, shadow.c

[Jaswinder Singh Rajput - Wed, Jul 08, 2009 at 08:29:39PM +0530]
|
| fix the following 'make includecheck' warning:
|
| arch/x86/mm/kmemcheck/shadow.c: linux/module.h is included more than once.
|
| Signed-off-by: Jaswinder Singh Rajput <[email protected]>
| ---
| arch/x86/mm/kmemcheck/shadow.c | 1 -
| 1 files changed, 0 insertions(+), 1 deletions(-)
|
| diff --git a/arch/x86/mm/kmemcheck/shadow.c b/arch/x86/mm/kmemcheck/shadow.c
| index e773b6b..3f66b82 100644
| --- a/arch/x86/mm/kmemcheck/shadow.c
| +++ b/arch/x86/mm/kmemcheck/shadow.c
| @@ -1,7 +1,6 @@
| #include <linux/kmemcheck.h>
| #include <linux/module.h>
| #include <linux/mm.h>
| -#include <linux/module.h>
|
| #include <asm/page.h>
| #include <asm/pgtable.h>
| --
| 1.6.0.6
|

Better to CC Vegard on this.

-- Cyrill

2009-07-09 17:25:53

by Cyrill Gorcunov

[permalink] [raw]
Subject: Re: [PATCH 18/44] includecheck fix: x86, dumpstack.c

[Jaswinder Singh Rajput - Wed, Jul 08, 2009 at 08:27:05PM +0530]
|
| fix the following 'make includecheck' warning:
|
| arch/x86/kernel/dumpstack.c: linux/ftrace.h is included more than once.
|
| Signed-off-by: Jaswinder Singh Rajput <[email protected]>
| ---
| arch/x86/kernel/dumpstack.c | 1 -
| 1 files changed, 0 insertions(+), 1 deletions(-)
|
| diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c
| index c840571..2d8a371 100644
| --- a/arch/x86/kernel/dumpstack.c
| +++ b/arch/x86/kernel/dumpstack.c
| @@ -15,7 +15,6 @@
| #include <linux/bug.h>
| #include <linux/nmi.h>
| #include <linux/sysfs.h>
| -#include <linux/ftrace.h>
|
| #include <asm/stacktrace.h>
|
| --
| 1.6.0.6

Looks good to me.
Acked-by: Cyrill Gorcunov <[email protected]>

-- Cyrill

2009-07-09 18:20:23

by Thomas Gleixner

[permalink] [raw]
Subject: Re: [PATCH 20/44] includecheck fix: x86, shadow.c

On Thu, 9 Jul 2009, Cyrill Gorcunov wrote:
> | #include <linux/kmemcheck.h>
> | #include <linux/module.h>
> | #include <linux/mm.h>
> | -#include <linux/module.h>
> |
> | #include <asm/page.h>
> | #include <asm/pgtable.h>
> | --
> | 1.6.0.6
> |
>
> Better to CC Vegard on this.

Can we stop this kindergarden already? The patch is so obvious that it
just should be applied. I'll pick up all x86 ones and fold them in.

Thanks,

tglx

2009-07-09 18:29:22

by Pekka Enberg

[permalink] [raw]
Subject: Re: [PATCH 20/44] includecheck fix: x86, shadow.c

Hi Thomas,

> On Thu, 9 Jul 2009, Cyrill Gorcunov wrote:
>> | ?#include <linux/kmemcheck.h>
>> | ?#include <linux/module.h>
>> | ?#include <linux/mm.h>
>> | -#include <linux/module.h>
>> |
>> | ?#include <asm/page.h>
>> | ?#include <asm/pgtable.h>
>> | --
>> | 1.6.0.6
>> |
>>
>> Better to CC Vegard on this.

On Thu, Jul 9, 2009 at 9:18 PM, Thomas Gleixner<[email protected]> wrote:
> Can we stop this kindergarden already? The patch is so obvious that it
> just should be applied. I'll pick up all x86 ones and fold them in.

What kindergarten are you talking about? Technically Ingo "kicked"
kmemcheck out of the x86 tree so the patch should go through
kmemcheck.git which makes Cyrill's CC correction spot on.

Pekka

2009-07-09 18:44:00

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: [GIT-PULL] includecheck fixes

Linus,

Please pull includecheck fixes, these all are clean and safe patches
with relevant Acks.

The following changes since commit 34f25476ace556263784ea2f8173e22b25557a13:
Linus Torvalds (1):
Merge branch 'fixes' of git://git.kernel.org/.../davej/cpufreq

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/include-check-2.6.git master

Jaswinder Singh Rajput (42):
includecheck fix: arm, misc.c
includecheck fix: arm, atomic.h
includecheck fix: arm, board-dm355-evm.c
includecheck fix: arm, board-dm355-leopard.c
includecheck fix: arm, board-dm644x-evm.c
includecheck fix: arm, board-dm646x-evm.c
includecheck fix: arm, board-sffsdr.c
includecheck fix: arm, mach-mx3/devices.c
includecheck fix: arm, mach-omap1/mcbsp.c
includecheck fix: arm, mach-omap2/mcbsp.c
includecheck fix: arm, plat-s3c64xx/pm.c
includecheck fix: arm, plat-stmp3xxx/pinmux.c
includecheck fix: mn10300, sys_mn10300.c
includecheck fix: s390, sys_s390.c
includecheck fix: um, helper.c
includecheck fix: x86, dumpstack.c
includecheck fix: x86, traps.c
includecheck fix: x86, shadow.c
includecheck fix: Documentation, cfag12864b-example.c
includecheck fix: drivers/char, vt.c
includecheck fix: drivers/net, sja1000.c
includecheck fix: drivers/net, axnet_cs.c
includecheck fix: drivers/net, smc911x.h
includecheck fix: drivers/parisc, ccio-dma.c
includecheck fix: drivers/scsi, libfcoe.c
includecheck fix: drivers/scsi, ibmvscsi.c
includecheck fix: drivers/spi, amba-pl022.c
includecheck fix: drivers/staging, usbdrv.c
includecheck fix: drivers/staging, rt_linux.h
includecheck fix: drivers/video, vgacon.c
includecheck fix: drivers/xen, evtchn.c
includecheck fix: fs/xfs, xfs_iops.c
includecheck fix: include/acpi, acpi_bus.h
includecheck fix: include/drm, drm_memory.h
includecheck fix: include/linux, aio.h
includecheck fix: include/linux, ftrace.h
includecheck fix: include/linux, icmpv6.h
includecheck fix: include/linux, net_dropmon.h
includecheck fix: include/linux, rfkill.h
includecheck fix: kernel/trace, ring_buffer.c
includecheck fix: mm, nommu.c
includecheck fix: mm, shmem.c

Documentation/auxdisplay/cfag12864b-example.c | 1 -
arch/arm/boot/compressed/misc.c | 1 -
arch/arm/include/asm/atomic.h | 2 --
arch/arm/mach-davinci/board-dm355-evm.c | 1 -
arch/arm/mach-davinci/board-dm355-leopard.c | 1 -
arch/arm/mach-davinci/board-dm644x-evm.c | 1 -
arch/arm/mach-davinci/board-dm646x-evm.c | 1 -
arch/arm/mach-davinci/board-sffsdr.c | 1 -
arch/arm/mach-mx3/devices.c | 1 -
arch/arm/mach-omap1/mcbsp.c | 1 -
arch/arm/mach-omap2/mcbsp.c | 1 -
arch/arm/plat-s3c64xx/pm.c | 2 --
arch/arm/plat-stmp3xxx/pinmux.c | 1 -
arch/mn10300/kernel/sys_mn10300.c | 1 -
arch/s390/kernel/sys_s390.c | 1 -
arch/um/os-Linux/helper.c | 1 -
arch/x86/kernel/dumpstack.c | 1 -
arch/x86/kernel/traps.c | 1 -
arch/x86/mm/kmemcheck/shadow.c | 1 -
drivers/char/vt.c | 1 -
drivers/net/can/sja1000/sja1000.c | 1 -
drivers/net/pcmcia/axnet_cs.c | 2 --
drivers/net/smc911x.h | 1 -
drivers/parisc/ccio-dma.c | 1 -
drivers/scsi/fcoe/libfcoe.c | 1 -
drivers/scsi/ibmvscsi/ibmvscsi.c | 1 -
drivers/spi/amba-pl022.c | 2 --
drivers/staging/otus/usbdrv.c | 3 ---
drivers/staging/rt2860/rt_linux.h | 4 ----
drivers/video/console/vgacon.c | 1 -
drivers/xen/evtchn.c | 1 -
fs/xfs/linux-2.6/xfs_iops.c | 1 -
include/acpi/acpi_bus.h | 1 -
include/drm/drm_memory.h | 2 --
include/linux/aio.h | 2 --
include/linux/ftrace.h | 1 -
include/linux/icmpv6.h | 2 --
include/linux/net_dropmon.h | 1 -
include/linux/rfkill.h | 1 -
kernel/trace/ring_buffer.c | 2 --
mm/nommu.c | 2 --
mm/shmem.c | 1 -
42 files changed, 0 insertions(+), 56 deletions(-)

2009-07-09 18:51:14

by Ben Dooks

[permalink] [raw]
Subject: Re: [PATCH 0/44] includecheck: fix multiple includes

Jaswinder Singh Rajput wrote:
> On Wed, 2009-07-08 at 22:13 +0100, Russell King wrote:
>> On Wed, Jul 08, 2009 at 11:30:59PM +0530, Jaswinder Singh Rajput wrote:
>>> I am still waiting ACK/NAK for :
>>>
>>> includecheck fix: arm, misc.c
>>> includecheck fix: arm, atomic.h
>>> includecheck fix: arm, board-dm355-evm.c
>>> includecheck fix: arm, board-dm355-leopard.c
>>> includecheck fix: arm, board-dm644x-evm.c
>>> includecheck fix: arm, board-dm646x-evm.c
>>> includecheck fix: arm, board-sffsdr.c
>>> includecheck fix: arm, mach-mx3/devices.c
>>> includecheck fix: arm, mach-omap1/mcbsp.c
>>> includecheck fix: arm, mach-omap2/mcbsp.c
>>> includecheck fix: arm, plat-s3c64xx/pm.c
>>> includecheck fix: arm, plat-stmp3xxx/pinmux.c
>> You're still waiting because apparantly you never sent this set anywhere
>> near any ARM people before.
>>
>> For the first two, I'll ack them:
>>
>> Acked-by: Russell King <[email protected]>
>>
>> The remainder look sane to me, but you'll have to seek acks from the
>> individual platform maintainer(s).
>>

Ack for plat-s3c64xx/pm.c:
Acked-by: Ben Dooks <[email protected]>

--
Ben Dooks, Software Engineer, Simtec Electronics

http://www.simtec.co.uk/

2009-07-09 19:02:45

by Thomas Gleixner

[permalink] [raw]
Subject: Re: [PATCH 20/44] includecheck fix: x86, shadow.c

On Thu, 9 Jul 2009, Pekka Enberg wrote:
> On Thu, Jul 9, 2009 at 9:18 PM, Thomas Gleixner<[email protected]> wrote:
> > Can we stop this kindergarden already? The patch is so obvious that it
> > just should be applied. I'll pick up all x86 ones and fold them in.
>
> What kindergarten are you talking about? Technically Ingo "kicked"
> kmemcheck out of the x86 tree so the patch should go through
> kmemcheck.git which makes Cyrill's CC correction spot on.

I'm referring to the fact that these changes are so obvious that we do
neither need dozens separate commits nor the ack of everyone plus some
more. My inbox is full enough already.

Thanks,

tglx

2009-07-09 20:15:43

by Philip Balister

[permalink] [raw]
Subject: Re: [PATCH 0/44] includecheck: fix multiple includes

Jaswinder Singh Rajput wrote:
> On Wed, 2009-07-08 at 22:13 +0100, Russell King wrote:
>> On Wed, Jul 08, 2009 at 11:30:59PM +0530, Jaswinder Singh Rajput wrote:
>>> I am still waiting ACK/NAK for :
>>>
>>> includecheck fix: arm, misc.c
>>> includecheck fix: arm, atomic.h
>>> includecheck fix: arm, board-dm355-evm.c
>>> includecheck fix: arm, board-dm355-leopard.c
>>> includecheck fix: arm, board-dm644x-evm.c
>>> includecheck fix: arm, board-dm646x-evm.c
>>> includecheck fix: arm, board-sffsdr.c
>>> includecheck fix: arm, mach-mx3/devices.c
>>> includecheck fix: arm, mach-omap1/mcbsp.c
>>> includecheck fix: arm, mach-omap2/mcbsp.c
>>> includecheck fix: arm, plat-s3c64xx/pm.c
>>> includecheck fix: arm, plat-stmp3xxx/pinmux.c
>> You're still waiting because apparantly you never sent this set anywhere
>> near any ARM people before.
>>
>> For the first two, I'll ack them:
>>
>> Acked-by: Russell King <[email protected]>
>>
>> The remainder look sane to me, but you'll have to seek acks from the
>> individual platform maintainer(s).
>>

Ack for board-sffsdr.c:
Acked-by: Philip Balister <[email protected]>



>
> OK, adding some more ARM people and ARM lists to get remaining ACK/NAK.
>
> Patches are already posted to LKML and also available at :
>
> http://git.kernel.org/?p=linux/kernel/git/jaswinder/headers-check-2.6.git;a=summary
>
> In case if you are not able to find these patches let me know.
>
> Thanks,
> --
> JSR
>
>

2009-07-09 21:17:52

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH 29/44] includecheck fix: drivers/spi, amba-pl022.c

2009/7/8 Jaswinder Singh Rajput <[email protected]>:
> On Wed, 2009-07-08 at 19:28 +0200, Linus Walleij wrote:
>> 2009/7/8 Jaswinder Singh Rajput <[email protected]>:
>>
>> > fix the following 'make includecheck' warnings:
>> >
>> > ?drivers/spi/amba-pl022.c: linux/delay.h is included more than once.
>> > ?drivers/spi/amba-pl022.c: linux/errno.h is included more than once.
>>
>> Acked-by: Linus Walleij <[email protected]>
>>
>> David are you merging this?
>
> This is a big patchset, So better me or Sam will send this to Linus
> after collecting some more ACKs.

Not me I hope (damned I knew this would happen sooner or later).
return -ELINWAL

Having this name is very convenient, people review my drivers like
crazy.

Linus Walleij

2009-07-09 21:21:59

by Linus Torvalds

[permalink] [raw]
Subject: Re: [PATCH 29/44] includecheck fix: drivers/spi, amba-pl022.c


On Thu, 9 Jul 2009, Linus Walleij wrote:
>
> Having this name is very convenient, people review my drivers like
> crazy.

ROTFL.

the-other-Linus

2009-07-09 22:26:55

by Greg KH

[permalink] [raw]
Subject: Re: [GIT-PULL] includecheck fixes

On Fri, Jul 10, 2009 at 12:10:09AM +0530, Jaswinder Singh Rajput wrote:
> Linus,
>
> Please pull includecheck fixes, these all are clean and safe patches
> with relevant Acks.

Shouldn't stuff like this go through the trivial tree? And stuff like
that is relevant for the main pre-rc1 merge, not this late in the merge
cycle, right?

thanks,

greg k-h

2009-07-10 03:02:22

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: Re: [GIT-PULL] includecheck fixes

Hello Greg,

On Thu, 2009-07-09 at 15:26 -0700, Greg KH wrote:
> On Fri, Jul 10, 2009 at 12:10:09AM +0530, Jaswinder Singh Rajput wrote:
> > Linus,
> >
> > Please pull includecheck fixes, these all are clean and safe patches
> > with relevant Acks.
>
> Shouldn't stuff like this go through the trivial tree? And stuff like
> that is relevant for the main pre-rc1 merge, not this late in the merge
> cycle, right?
>

You did not specified what is your problem ? and where was you when we
discussed it earlier ?

Normally brain is above then the eyes, do you know why ?

To use your brain instead of follow things blindly.

The point of watching patches for some time means test and wait so that
they can show their real faces.

BTW, it is not late, it is not going to hit stable in next week or so.

Keeping these sane patches waiting for complete cycle will be insaner.

Thanks,
--
JSR

2009-07-10 03:23:19

by James Bottomley

[permalink] [raw]
Subject: Re: [GIT-PULL] includecheck fixes

On Fri, 2009-07-10 at 08:29 +0530, Jaswinder Singh Rajput wrote:
> Hello Greg,
>
> On Thu, 2009-07-09 at 15:26 -0700, Greg KH wrote:
> > On Fri, Jul 10, 2009 at 12:10:09AM +0530, Jaswinder Singh Rajput wrote:
> > > Linus,
> > >
> > > Please pull includecheck fixes, these all are clean and safe patches
> > > with relevant Acks.
> >
> > Shouldn't stuff like this go through the trivial tree? And stuff like
> > that is relevant for the main pre-rc1 merge, not this late in the merge
> > cycle, right?
> >
>
> You did not specified what is your problem ? and where was you when we
> discussed it earlier ?

The problem, as you have been told several times, is that maintainers
are very busy people and don't necessarily have time to deal with
mechanical replacement trivia like this.

The point is that Jiri Kosina takes that burden on himself to verify and
submit the changes like this, so something like this should go through
him.

> Normally brain is above then the eyes, do you know why ?
>
> To use your brain instead of follow things blindly.
>
> The point of watching patches for some time means test and wait so that
> they can show their real faces.

Abusing people who do real work, particularly when you manifestly do
not, is a gross breach of etiquette ... welcome to my killfile.

James

2009-07-10 03:36:47

by Greg KH

[permalink] [raw]
Subject: Re: [GIT-PULL] includecheck fixes

On Fri, Jul 10, 2009 at 08:29:15AM +0530, Jaswinder Singh Rajput wrote:
> Hello Greg,
>
> On Thu, 2009-07-09 at 15:26 -0700, Greg KH wrote:
> > On Fri, Jul 10, 2009 at 12:10:09AM +0530, Jaswinder Singh Rajput wrote:
> > > Linus,
> > >
> > > Please pull includecheck fixes, these all are clean and safe patches
> > > with relevant Acks.
> >
> > Shouldn't stuff like this go through the trivial tree? And stuff like
> > that is relevant for the main pre-rc1 merge, not this late in the merge
> > cycle, right?
> >
>
> You did not specified what is your problem ? and where was you when we
> discussed it earlier ?

Earlier when? I responded to your query about the individual patches
you copied me on, saying they were in my "to-apply" queue and I didn't
want them to go to Linus at this point in time. You seem quite rushed
about these patches, which is odd to me.

> Normally brain is above then the eyes, do you know why ?
>
> To use your brain instead of follow things blindly.
>
> The point of watching patches for some time means test and wait so that
> they can show their real faces.

Which is what I am asking you to do here. So why are you arguing with
this concept?

> BTW, it is not late, it is not going to hit stable in next week or so.
>
> Keeping these sane patches waiting for complete cycle will be insaner.

Accepting trivial patches like these, for which a full build cycle of
all arches has yet to be accomplished due to a lack of inclusion in the
-next tree, at a point in the development series in which bug fixes and
regressions are the only thing to be accepted, seems to be a risk, don't
you think?

But hey, I'm not Linus, it's up to him to decide to take untested stuff
like this or not, not me :)

best of luck,

greg k-h

2009-07-10 03:42:14

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: Re: [GIT-PULL] includecheck fixes

Hello James,

On Fri, 2009-07-10 at 03:22 +0000, James Bottomley wrote:
> On Fri, 2009-07-10 at 08:29 +0530, Jaswinder Singh Rajput wrote:
> > Hello Greg,
> >
> > On Thu, 2009-07-09 at 15:26 -0700, Greg KH wrote:
> > > On Fri, Jul 10, 2009 at 12:10:09AM +0530, Jaswinder Singh Rajput wrote:
> > > > Linus,
> > > >
> > > > Please pull includecheck fixes, these all are clean and safe patches
> > > > with relevant Acks.
> > >
> > > Shouldn't stuff like this go through the trivial tree? And stuff like
> > > that is relevant for the main pre-rc1 merge, not this late in the merge
> > > cycle, right?
> > >
> >
> > You did not specified what is your problem ? and where was you when we
> > discussed it earlier ?
>
> The problem, as you have been told several times, is that maintainers
> are very busy people and don't necessarily have time to deal with
> mechanical replacement trivia like this.
>

Am I asking you ?

If you are very busy and not able to handle things properly, so better
quit the maintainer-ship. Others can handle more better than you.

> The point is that Jiri Kosina takes that burden on himself to verify and
> submit the changes like this, so something like this should go through
> him.
>

Who will take burden of Jiri, I already send another PULL request to
Jiri.

> > Normally brain is above then the eyes, do you know why ?
> >
> > To use your brain instead of follow things blindly.
> >
> > The point of watching patches for some time means test and wait so that
> > they can show their real faces.
>
> Abusing people who do real work, particularly when you manifestly do
> not, is a gross breach of etiquette ... welcome to my killfile.
>

So what you mean, you can do any crap and no one can blame you ...
welcome to my killknife.

--
JSR

2009-07-10 03:55:41

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: Re: [GIT-PULL] includecheck fixes

On Thu, 2009-07-09 at 20:35 -0700, Greg KH wrote:
> On Fri, Jul 10, 2009 at 08:29:15AM +0530, Jaswinder Singh Rajput wrote:
> > Hello Greg,
> >
> > On Thu, 2009-07-09 at 15:26 -0700, Greg KH wrote:
> > > On Fri, Jul 10, 2009 at 12:10:09AM +0530, Jaswinder Singh Rajput wrote:
> > > > Linus,
> > > >
> > > > Please pull includecheck fixes, these all are clean and safe patches
> > > > with relevant Acks.
> > >
> > > Shouldn't stuff like this go through the trivial tree? And stuff like
> > > that is relevant for the main pre-rc1 merge, not this late in the merge
> > > cycle, right?
> > >
> >
> > You did not specified what is your problem ? and where was you when we
> > discussed it earlier ?
>
> Earlier when?

Check LKML emails of this thread, I have send half-dozen of emails to
you earlier.

Thanks,
--
JSR

2009-07-10 05:47:43

by Sascha Hauer

[permalink] [raw]
Subject: Re: [PATCH 0/44] includecheck: fix multiple includes

On Thu, Jul 09, 2009 at 09:58:31AM +0530, Jaswinder Singh Rajput wrote:
> On Wed, 2009-07-08 at 22:13 +0100, Russell King wrote:
> > On Wed, Jul 08, 2009 at 11:30:59PM +0530, Jaswinder Singh Rajput wrote:
> > > I am still waiting ACK/NAK for :
> > >
> > > includecheck fix: arm, misc.c
> > > includecheck fix: arm, atomic.h
> > > includecheck fix: arm, board-dm355-evm.c
> > > includecheck fix: arm, board-dm355-leopard.c
> > > includecheck fix: arm, board-dm644x-evm.c
> > > includecheck fix: arm, board-dm646x-evm.c
> > > includecheck fix: arm, board-sffsdr.c
> > > includecheck fix: arm, mach-mx3/devices.c
> > > includecheck fix: arm, mach-omap1/mcbsp.c
> > > includecheck fix: arm, mach-omap2/mcbsp.c
> > > includecheck fix: arm, plat-s3c64xx/pm.c
> > > includecheck fix: arm, plat-stmp3xxx/pinmux.c

For mach-mx3/devices.c:

Acked-by: Sascha Hauer <[email protected]>


--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

2009-07-10 07:20:28

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: Re: [PATCH 0/44] includecheck: fix multiple includes

Hello all,

On Wed, 2009-07-08 at 23:30 +0530, Jaswinder Singh Rajput wrote:
> Hello all,
>
> On Wed, 2009-07-08 at 19:58 +0530, Jaswinder Singh Rajput wrote:
> > The following changes since commit faf80d62e44dc627efb741f48db50c1858d1667c:
> > Linus Torvalds (1):
> > Merge branch 'x86-fixes-for-linus' of git://git.kernel.org/.../tip/linux-2.6-tip
> >
> > are available in the git repository at:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/headers-check-2.6.git master
> >
> > Jaswinder Singh Rajput (44):
>
> This is a big patchset, so it will be better that either me or Sam will
> send it to Linus after collecting ACKs.

> I am still waiting ACK/NAK for :
>

Thanks for all your ACKs and support.

Sorry guys, I give up and do not want to hear more crap from crapy
people just for nothing and withdrawing pull request.

If you want, apply these patches or just trashed it.

Thanks,
--
JSR

2009-07-10 08:10:47

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: Re: [PATCH 20/44] includecheck fix: x86, shadow.c

On Thu, 2009-07-09 at 21:01 +0200, Thomas Gleixner wrote:
> On Thu, 9 Jul 2009, Pekka Enberg wrote:
> > On Thu, Jul 9, 2009 at 9:18 PM, Thomas Gleixner<[email protected]> wrote:
> > > Can we stop this kindergarden already? The patch is so obvious that it
> > > just should be applied. I'll pick up all x86 ones and fold them in.
> >
> > What kindergarten are you talking about? Technically Ingo "kicked"
> > kmemcheck out of the x86 tree so the patch should go through
> > kmemcheck.git which makes Cyrill's CC correction spot on.
>
> I'm referring to the fact that these changes are so obvious that we do
> neither need dozens separate commits nor the ack of everyone plus some
> more. My inbox is full enough already.
>

Hey kindergarten kid,

What the hell you are talking about, I did not send even one email to
you.

Hey kid here is your today's lesson:

If you and your inbox is upset with x86 maintainers <[email protected]>
emails then quit x86 maintainer-ship.

If you and your inbox is upset with LKML emails then quit LKML.

If you upset with life then ...

--
JSR

2009-07-10 08:19:23

by Pekka Enberg

[permalink] [raw]
Subject: Re: [PATCH 20/44] includecheck fix: x86, shadow.c

On Fri, Jul 10, 2009 at 11:09 AM, Jaswinder Singh
Rajput<[email protected]> wrote:
> Hey kindergarten kid,
>
> What the hell you are talking about, I did not send even one email to
> you.
>
> Hey kid here is your today's lesson:
>
> If you and your inbox is upset with x86 maintainers <[email protected]>
> emails then quit x86 maintainer-ship.
>
> If you and your inbox is upset with LKML emails then quit LKML.
>
> If you upset with life then ...

Jaswinder, you might want wait for few days to calm down before
writing more emails on LKML. Yes, I do realize you're upset after Ingo
stopped nurturing your patches. But in the last 24 hours, you've told
two Linux kernel maintainers to quit (and insulted them in the
process) which is bit over the top, wouldn't you agree? If you
continue doing this, I suspect you will end up in more killfiles and
have all your patches ignored.

Pekka

2009-07-10 08:49:17

by Cong Wang

[permalink] [raw]
Subject: Re: [PATCH 17/44] includecheck fix: um, helper.c

On Wed, Jul 08, 2009 at 08:25:50PM +0530, Jaswinder Singh Rajput wrote:
>
>fix the following 'make includecheck' warning:
>
> arch/um/os-Linux/helper.c: linux/limits.h is included more than once.
>
>Signed-off-by: Jaswinder Singh Rajput <[email protected]>
>---
> arch/um/os-Linux/helper.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
>diff --git a/arch/um/os-Linux/helper.c b/arch/um/os-Linux/helper.c
>index 30860b8..b6b1096 100644
>--- a/arch/um/os-Linux/helper.c
>+++ b/arch/um/os-Linux/helper.c
>@@ -15,7 +15,6 @@
> #include "os.h"
> #include "um_malloc.h"
> #include "user.h"
>-#include <linux/limits.h>
>
> struct helper_data {
> void (*pre_exec)(void*);

Definitely yes.

Acked-by: WANG Cong <[email protected]>

2009-07-10 08:49:27

by Jiri Kosina

[permalink] [raw]
Subject: Re: [GIT-PULL] includecheck fixes

On Fri, 10 Jul 2009, Jaswinder Singh Rajput wrote:

> > > > > Please pull includecheck fixes, these all are clean and safe
> > > > > patches with relevant Acks.
> > > > Shouldn't stuff like this go through the trivial tree? And stuff
> > > > like that is relevant for the main pre-rc1 merge, not this late in
> > > > the merge cycle, right?
> > > You did not specified what is your problem ? and where was you when
> > > we discussed it earlier ?
> > The problem, as you have been told several times, is that maintainers
> > are very busy people and don't necessarily have time to deal with
> > mechanical replacement trivia like this.
> Am I asking you ? If you are very busy and not able to handle things
> properly, so better quit the maintainer-ship. Others can handle more
> better than you.

Come on Jaswinder ... trivial grammar/typo fixes are really not that
important stuff to argue about in longish threads. Let's rather find a
more interesting and important topic to flame each other about :) This is
really not worth it.

> > The point is that Jiri Kosina takes that burden on himself to verify
> > and submit the changes like this, so something like this should go
> > through him.
> Who will take burden of Jiri, I already send another PULL request to
> Jiri.

If you mean the "foo foo" replacement request, the repository you asked me
to pull from doesn't seem to have any extra patches on top of current
tree, so I guess you forgot to push.

Also you can't expect that I react to trivial patches very promptly. There
are a lot of more urgent things that I am taking care of, this is just an
"add-on".

Thanks,

--
Jiri Kosina
SUSE Labs

2009-07-24 14:58:20

by Eduardo Valentin

[permalink] [raw]
Subject: Re: [PATCH 0/44] includecheck: fix multiple includes

On Thu, Jul 09, 2009 at 06:28:31AM +0200, ext Jaswinder Singh Rajput wrote:
> On Wed, 2009-07-08 at 22:13 +0100, Russell King wrote:
> > On Wed, Jul 08, 2009 at 11:30:59PM +0530, Jaswinder Singh Rajput wrote:
> > > I am still waiting ACK/NAK for :
> > >
> > > includecheck fix: arm, misc.c
> > > includecheck fix: arm, atomic.h
> > > includecheck fix: arm, board-dm355-evm.c
> > > includecheck fix: arm, board-dm355-leopard.c
> > > includecheck fix: arm, board-dm644x-evm.c
> > > includecheck fix: arm, board-dm646x-evm.c
> > > includecheck fix: arm, board-sffsdr.c
> > > includecheck fix: arm, mach-mx3/devices.c
> > > includecheck fix: arm, mach-omap1/mcbsp.c
> > > includecheck fix: arm, mach-omap2/mcbsp.c
> > > includecheck fix: arm, plat-s3c64xx/pm.c
> > > includecheck fix: arm, plat-stmp3xxx/pinmux.c
> >
> > You're still waiting because apparantly you never sent this set anywhere
> > near any ARM people before.
> >
> > For the first two, I'll ack them:
> >
> > Acked-by: Russell King <[email protected]>
> >
> > The remainder look sane to me, but you'll have to seek acks from the
> > individual platform maintainer(s).
> >
>
> OK, adding some more ARM people and ARM lists to get remaining ACK/NAK.
>
> Patches are already posted to LKML and also available at :
>
> http://git.kernel.org/?p=linux/kernel/git/jaswinder/headers-check-2.6.git;a=summary
>
> In case if you are not able to find these patches let me know.
>
> Thanks,

In behalf of mach-omap[1,2]/mcbsp.c:

Acked-by: Eduardo Valentin <[email protected]>

> --
> JSR
>

--
Eduardo Valentin

2009-07-24 15:09:45

by Jaswinder Singh Rajput

[permalink] [raw]
Subject: Re: [PATCH 0/44] includecheck: fix multiple includes

Hello all,

On Fri, 2009-07-24 at 17:45 +0300, Eduardo Valentin wrote:
> On Thu, Jul 09, 2009 at 06:28:31AM +0200, ext Jaswinder Singh Rajput wrote:
> > On Wed, 2009-07-08 at 22:13 +0100, Russell King wrote:
> > > On Wed, Jul 08, 2009 at 11:30:59PM +0530, Jaswinder Singh Rajput wrote:
> > > > I am still waiting ACK/NAK for :
> > > >
> > > > includecheck fix: arm, misc.c
> > > > includecheck fix: arm, atomic.h
> > > > includecheck fix: arm, board-dm355-evm.c
> > > > includecheck fix: arm, board-dm355-leopard.c
> > > > includecheck fix: arm, board-dm644x-evm.c
> > > > includecheck fix: arm, board-dm646x-evm.c
> > > > includecheck fix: arm, board-sffsdr.c
> > > > includecheck fix: arm, mach-mx3/devices.c
> > > > includecheck fix: arm, mach-omap1/mcbsp.c
> > > > includecheck fix: arm, mach-omap2/mcbsp.c
> > > > includecheck fix: arm, plat-s3c64xx/pm.c
> > > > includecheck fix: arm, plat-stmp3xxx/pinmux.c
> > >
> > > You're still waiting because apparantly you never sent this set anywhere
> > > near any ARM people before.
> > >
> > > For the first two, I'll ack them:
> > >
> > > Acked-by: Russell King <[email protected]>
> > >
> > > The remainder look sane to me, but you'll have to seek acks from the
> > > individual platform maintainer(s).
> > >
> >
> > OK, adding some more ARM people and ARM lists to get remaining ACK/NAK.
> >
> > Patches are already posted to LKML and also available at :
> >
> > http://git.kernel.org/?p=linux/kernel/git/jaswinder/headers-check-2.6.git;a=summary
> >
> > In case if you are not able to find these patches let me know.
> >
> > Thanks,
>
> In behalf of mach-omap[1,2]/mcbsp.c:
>
> Acked-by: Eduardo Valentin <[email protected]>
>

These patches are still not applied anywhere, If you want you can apply
respective patch in your respective trees.

Thanks,
--
JSR